Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Mar 2022 17:58:26 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Ben Gardon <bgardon@google.com>
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Peter Xu <peterx@redhat.com>,
        David Matlack <dmatlack@google.com>,
        Jim Mattson <jmattson@google.com>,
        David Dunn <daviddunn@google.com>,
        Jing Zhang <jingzhangos@google.com>,
        Junaid Shahid <junaids@google.com>
Subject: Re: [PATCH 00/13] KVM: x86: Add a cap to disable NX hugepages on a VM
Message-ID: <Yio8QtuMd6COcnEw@google.com>
References: <20220310164532.1821490-1-bgardon@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220310164532.1821490-1-bgardon@google.com>
Precedence: bulk

On Thu, Mar 10, 2022, Ben Gardon wrote:
>   selftests: KVM: Wrap memslot IDs in a struct for readability
>   selftests: KVM: Add memslot parameter to VM vaddr allocation
>   selftests: KVM: Add memslot parameter to elf_load

I really, really, don't want to go down this path of proliferating memslot crud
throughout the virtual memory allocators.  I would much rather we solve this by
teaching the VM creation helpers to (optionally) use hugepages.  The amount of
churn required just so that one test can back code with hugepages is absurd, and
there's bound to be tests in the future that want to force hugepages as well.