Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp2096310pxp; Thu, 10 Mar 2022 19:54:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJymdV0FbK4HG63ROBh7zjXpZjeSAgCIqhD6Wy8y5wDpVmjcJt8BIuszLakAlUMNP9OUIesc X-Received: by 2002:a17:902:b581:b0:153:301c:3a71 with SMTP id a1-20020a170902b58100b00153301c3a71mr2938583pls.174.1646970863602; Thu, 10 Mar 2022 19:54:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646970863; cv=none; d=google.com; s=arc-20160816; b=SRochRuIc/w2e92G1Zyk8Hu5tL6YJHHL1nQQhWNoqBLnoOzQ/Y6nWX4lI4jkgjlCs1 g1s3md7rSQM0HoVGiMhOZdlUGbBOM1ljSNUmVQQj/9JNURGo6Nam5sBzCaOECIUDKyZS wJYPZY9Yc0AjtX+OcaUwbBCAd7mvHx4XdJWGOsn93HC+BTqNRj6ZGjJ706vZW86rN9Zw 9QOOzKPiWPZc5TGRcRGv8TcrxKdhUY9MY1js9Rx9NBTI+Lt7KRek25DOFmfNru0jdK8O sl//Q+r2c74OFkGqHNvMMuAbBz8mDVJ1LO20wTWR07+DJr9iKtcZyyWJDlU8+Oqhqy4W N+IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=MqayqFEJwoCcC7WjICTcMr036Vt05Jn4Iubv8Sc2mWQ=; b=unWMEA44p6QqDS9wm0lPa+1Xd3fDI82xF9YaB7ZjcXmEcNuJ1jfS77EKBI6ZRElQ8w US19IO9E7mBwYyb5w3DKIpWLWOIWutbK7x2G90WCkfoHiBRdmiZrBByldMifrDRraNpD Ptvq3RqFp8WLG3qzgEiZFcIIhqy4LyjKxfkwW1JDikZnHUfVEpqwdnNcntF9Ulv1Foqp aN23J9snDq3e0P4JTdIdi7TDDAYTNplz1uMcO7lD8Kn8TIHp26rivd53fPFISnPCUMZ5 t9NvGZ0m9Qo6KpMN/fEEgj+ovMEVJKk9MBhZILDLuDQNvj5emziRFAWdW+J1XP2zb8Iy 3LZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q184-20020a632ac1000000b0037026d51d89si6751476pgq.425.2022.03.10.19.54.07; Thu, 10 Mar 2022 19:54:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240336AbiCJI3L (ORCPT + 99 others); Thu, 10 Mar 2022 03:29:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240335AbiCJI3I (ORCPT ); Thu, 10 Mar 2022 03:29:08 -0500 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9B5B1354B7 for ; Thu, 10 Mar 2022 00:28:07 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R891e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0V6neRAP_1646900878; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0V6neRAP_1646900878) by smtp.aliyun-inc.com(127.0.0.1); Thu, 10 Mar 2022 16:28:04 +0800 From: Jiapeng Chong To: codrin.ciubotariu@microchip.com Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH v2] ASoC: atmel: mchp-pdmc: Remove unnecessary print function dev_err() Date: Thu, 10 Mar 2022 16:27:56 +0800 Message-Id: <20220310082756.1183-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./sound/soc/atmel/mchp-pdmc.c:991:2-9: line 991 is redundant because platform_get_irq() already prints an error. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Reviewed-by: Codrin Ciubotariu --- Changes in v2: -The braces be removed. sound/soc/atmel/mchp-pdmc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c index c44636f6207d..7b737e3f67b7 100644 --- a/sound/soc/atmel/mchp-pdmc.c +++ b/sound/soc/atmel/mchp-pdmc.c @@ -987,10 +987,8 @@ static int mchp_pdmc_probe(struct platform_device *pdev) return ret; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "failed to get irq: %d\n", irq); + if (irq < 0) return irq; - } dd->pclk = devm_clk_get(dev, "pclk"); if (IS_ERR(dd->pclk)) { -- 2.20.1.7.g153144c