Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423143AbXBUVUt (ORCPT ); Wed, 21 Feb 2007 16:20:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1423147AbXBUVUZ (ORCPT ); Wed, 21 Feb 2007 16:20:25 -0500 Received: from smtp.osdl.org ([65.172.181.24]:49228 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423143AbXBUVUD (ORCPT ); Wed, 21 Feb 2007 16:20:03 -0500 Date: Wed, 21 Feb 2007 13:19:27 -0800 From: Stephen Hemminger To: Oleg Nesterov Cc: Jarek Poplawski , Andrew Morton , "David S. Miller" , David Howells , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFT] bridge: eliminate port_check workqueue Message-ID: <20070221131927.07328dca@freekitty> In-Reply-To: <20070221200916.GA145@tv-sign.ru> References: <20070220221941.GA707@tv-sign.ru> <20070220162434.72d3ad7b@freekitty> <20070221082345.GB1662@ff.dom.local> <20070221142342.GB134@tv-sign.ru> <20070221105555.4d1b40a6@freekitty> <20070221200916.GA145@tv-sign.ru> Organization: Linux Foundation X-Mailer: Sylpheed-Claws 2.5.0-rc3 (GTK+ 2.10.6; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 43 On Wed, 21 Feb 2007 23:09:16 +0300 Oleg Nesterov wrote: > On 02/21, Stephen Hemminger wrote: > > > > This is what I was suggesting by getting rid of the work queue completely. > > Can't comment this patch, but if we can get rid of the work_struct - good! > > > -static void port_carrier_check(struct work_struct *work) > > +void br_port_carrier_check(struct net_bridge_port *p) > > { > > - struct net_bridge_port *p; > > - struct net_device *dev; > > - struct net_bridge *br; > > - > > - dev = container_of(work, struct net_bridge_port, > > - carrier_check.work)->dev; > > - work_release(work); > > May I ask you to redo this patch on top of > > [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR > http://marc.theaimsgroup.com/?l=linux-kernel&m=117183517612775 > > ? > > We are removing the _NAR stuff, it would be nice to do this in a separate > patch. > > Thanks! > > Oleg. I would rather put it in a bugfix patchset for 2.6.21 and 2.6.20-stable -- Stephen Hemminger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/