Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Mar 2022 12:36:46 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     patchwork-bot+netdevbpf@kernel.org
Cc:     Miaoqian Lin <linmq006@gmail.com>, claudiu.manoil@nxp.com,
        davem@davemloft.net, yangbo.lu@nxp.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ethtool: Fix refcount leak in gfar_get_ts_info
Message-ID: <20220310123646.6cd8eda5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <164694421005.25928.8192632263617789696.git-patchwork-notify@kernel.org>
References: <20220309091149.775-1-linmq006@gmail.com>
        <164694421005.25928.8192632263617789696.git-patchwork-notify@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 10 Mar 2022 20:30:10 +0000 patchwork-bot+netdevbpf@kernel.org
wrote:
> Hello:
> 
> This patch was applied to netdev/net.git (master)
> by Jakub Kicinski <kuba@kernel.org>:

No, it wasn't. Maybe I forgot to mark this version as Changes Requested
before applying v2.

> On Wed,  9 Mar 2022 09:11:49 +0000 you wrote:
> > The of_find_compatible_node() function returns a node pointer with
> > refcount incremented, We should use of_node_put() on it when done
> > Add the missing of_node_put() to release the refcount.
> > 
> > Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> > 
> > [...]  
> 
> Here is the summary with links:
>   - ethtool: Fix refcount leak in gfar_get_ts_info
>     https://git.kernel.org/netdev/net/c/2ac5b58e645c
> 
> You are awesome, thank you!