Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Marc Mattmueller <marc.mattmueller@netmodule.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] mmc: core: add reliable write setting to sysfs and
 update on read
Thread-Topic: [PATCH 2/2] mmc: core: add reliable write setting to sysfs and
 update on read
Thread-Index: AQHYM6Iq238/wKtYGUOfp7PikKmAbqy4qSIg
Date:   Thu, 10 Mar 2022 14:08:33 +0000
Message-ID: <DM6PR04MB65751B0413F8A2FDC72F05B9FC0B9@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <cover.1646820083.git.marc.mattmueller@netmodule.com>
 <d68d8c8edda35a050a6e92b0ff1d57dd3e7c61d6.1646820083.git.marc.mattmueller@netmodule.com>
In-Reply-To: <d68d8c8edda35a050a6e92b0ff1d57dd3e7c61d6.1646820083.git.marc.mattmueller@netmodule.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b9o9aUsayJ+RI9xiVkdvPdoU8Kfoe+g8B8f1Lxv3Jjat4q+2J3fwEY3yqa8c?=
 =?us-ascii?Q?XzUY/dlgvOmz1uAl0iwPQdX12EUCaR4vjdp31I2CDmf+n3DHQgUAlVslk+Ig?=
 =?us-ascii?Q?wyj0Fax8d/BDoQf0PwIBQVnjfmxXyRANfpJ6BUNh5hoybUQndKRbWkI4iSSX?=
 =?us-ascii?Q?uL5anyMKQKMp0Tl70gyYiety8ZuYgPqpY5vYJ7Zd9pPCUUTKlRTaWrb1OZsK?=
 =?us-ascii?Q?31S9lD8T7cm+da7Im/uhv/yoOWWZhRAOrvbTU13QmrN4dxuQZ4haVbOq4+cp?=
 =?us-ascii?Q?Yi+6vS2RE+QfTf6/tHZ+x+9mwH/tQNGJIt/n2vYG6E9UpV07NZgTqZ4pa2cV?=
 =?us-ascii?Q?PFZd10DJ2spnOb7gbe+yPdILqaOUYSqqaYl7K41qsIu3QEp3/swq50AErvuq?=
 =?us-ascii?Q?sRaHfAqILTEbmenfIycQat0jSDMuh0Nq9v10PmuX0MsLC72oLT9bSlt9PD1d?=
 =?us-ascii?Q?kEnbmjAK1eM8ZEWEzAQ8BygA1UDFMiTqJJdR/+u5WgIQienThx0qhccvK0Pg?=
 =?us-ascii?Q?+REYgUdRGcxDpAPGJXPuOZ9DkbNzaUkyC3/SO6bTki5rPxsUT6hBCR/3szXS?=
 =?us-ascii?Q?nIyskxG6+Mzus90KSYLB2ag50/VXIQizDJdLjl1YjHWFoCmI+97N2siOtC00?=
 =?us-ascii?Q?mfM5vIRxg/CQFaKVHBLOX3ow1R0Hgz3SMlDZWaVJTCssEdqE3J4s0JT6uV65?=
 =?us-ascii?Q?F8733BTxerSzIIJciDNlGOXN8XMKLn14aNBh3iEzG628vNwqUV4g4jJ+S5Qe?=
 =?us-ascii?Q?tveopBJMojCsUGdEfMMXpoPyv9uTG5QNESLrInaW9DNWryoqdLPozrJMaO1K?=
 =?us-ascii?Q?rwsGplMi/9npKFnbnmsqepYyCDqC9BuB+/seRicl0DB9mske+eG8P7BrmEjN?=
 =?us-ascii?Q?GTcjLWg/QLTc+dvNskxSeqYpI+y9OwamJHvTNVZz0W9fOSOLJEaP8Qm71LmD?=
 =?us-ascii?Q?G7X9DcXv7BW+Q+B3b6jGmsulJwuRuzBYgtT+F3kKALid9p8Dwsg5zV93SGGX?=
 =?us-ascii?Q?pnckgf3yCCdPRLo7ZnGNFycOSIiDPjb1nGgUMxHsTNOo1wNrmLOUNXNAADtJ?=
 =?us-ascii?Q?Bharlm1D6X0j49QS/39X2amFqUql9dAyFlsYHmlTEYdcKzpKN1TTZUxZBWHS?=
 =?us-ascii?Q?zMGbssy+ytv57ZqMfCVp+othBGoVgx3sewbbWYCsk+SzgJ9hHCqgxNhi0XIu?=
 =?us-ascii?Q?p8Jlj9WP5IERiSBlBKvYj2LHOcNn450UDB49rQsK1m83I6uS3EdgOOWw7fgC?=
 =?us-ascii?Q?cgtZ9cPnW47UajBhimGTWV7WTZH+EAnYovgHvezn980tLEJInMjLprxvkZsR?=
 =?us-ascii?Q?9xfoMUt0nnxVKDFxI7BAcBuXSoj+r/5B9plHDbMQfgqVbh+tPyv48sRqZ4He?=
 =?us-ascii?Q?tLU68tRUTxD1Z9MxPHWMw+/BjmCQLwPtm4zohYPP/X3EJ7N5Cx8NhphlkBEJ?=
 =?us-ascii?Q?XriunXa4lWo+tVjxf1VqSn4zvwjdb1Vf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65ed6b34-f5dc-4278-4d01-08da029f76a0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2022 14:08:33.9306
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2G3KQ2Go2hBAMcaEPekrBZsnja2CWEYJVDifb6DmmY1ZRXE2F6gKaiuHEDLVi88GYIrJejsV8ruiNMMtVp1wKQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB7762
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> The mmc reliable write setting (from ext_csd) was not available on the sy=
sfs.
> Thus, added rel_param and rel_write_set to sysfs and added the update of
> rel_write_set on sysfs read.
Here also - why adding ABI when its already available via mmc-utils?

Thanks,
Avri

>=20
> Signed-off-by: Marc Mattmueller <marc.mattmueller@netmodule.com>
> ---
>  drivers/mmc/core/mmc.c   | 29 +++++++++++++++++++++++++++++
>  include/linux/mmc/card.h |  1 +
>  include/linux/mmc/mmc.h  |  1 +
>  3 files changed, 31 insertions(+)
>=20
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index
> d9537c894e33..a64d1ecb0de9 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -364,6 +364,10 @@ static int
> mmc_update_ext_csd_runtime_params(struct mmc_card *card, u8
> *ext_csd)  {
>         int err =3D 0;
>=20
> +       /* eMMC v4.41 or later */
> +       if (card->ext_csd.rev >=3D 5)
> +               card->ext_csd.rel_wr_set =3D ext_csd[EXT_CSD_WR_REL_SET];
> +
>         /* eMMC v5 or later */
>         if (card->ext_csd.rev >=3D 7) {
>                 card->ext_csd.pre_eol_info =3D ext_csd[EXT_CSD_PRE_EOL_IN=
FO];
> @@ -587,6 +591,7 @@ static int mmc_decode_ext_csd(struct mmc_card
> *card, u8 *ext_csd)
>                 }
>=20
>                 card->ext_csd.rel_param =3D ext_csd[EXT_CSD_WR_REL_PARAM]=
;
> +               card->ext_csd.rel_wr_set =3D ext_csd[EXT_CSD_WR_REL_SET];
>                 card->ext_csd.rst_n_function =3D
> ext_csd[EXT_CSD_RST_N_FUNCTION];
>=20
>                 /*
> @@ -820,6 +825,7 @@ MMC_DEV_ATTR(name, "%s\n", card-
> >cid.prod_name);  MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
> MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);  MMC_DEV_ATTR(rev,
> "0x%x\n", card->ext_csd.rev);
> +MMC_DEV_ATTR(rel_param, "0x%02x\n", card->ext_csd.rel_param);
>  MMC_DEV_ATTR(serial, "0x%08x\n", card->cid.serial);
> MMC_DEV_ATTR(enhanced_area_offset, "%llu\n",
>                 card->ext_csd.enhanced_area_offset);
> @@ -886,6 +892,27 @@ static ssize_t pre_eol_info_show(struct device
> *dev,
>=20
>  static DEVICE_ATTR_RO(pre_eol_info);
>=20
> +static ssize_t rel_write_set_show(struct device *dev,
> +                                 struct device_attribute *attr,
> +                                 char *buf) {
> +       int err =3D 0;
> +       struct mmc_card *card =3D mmc_dev_to_card(dev);
> +
> +       /* before eMMC v4.41 */
> +       if (card->ext_csd.rev < 5)
> +               return sprintf(buf, "%s\n", "-");
> +
> +       /* eMMC v4.41 or later */
> +       err =3D mmc_update_csd(card);
> +       if (err)
> +               return (ssize_t)err;
> +
> +       return sprintf(buf, "0x%02x\n", card->ext_csd.rel_wr_set); }
> +
> +static DEVICE_ATTR_RO(rel_write_set);
> +
>  static ssize_t mmc_fwrev_show(struct device *dev,
>                               struct device_attribute *attr,
>                               char *buf) @@ -931,6 +958,8 @@ static struc=
t attribute
> *mmc_std_attrs[] =3D {
>         &dev_attr_oemid.attr,
>         &dev_attr_prv.attr,
>         &dev_attr_rev.attr,
> +       &dev_attr_rel_param.attr,
> +       &dev_attr_rel_write_set.attr,
>         &dev_attr_pre_eol_info.attr,
>         &dev_attr_life_time.attr,
>         &dev_attr_serial.attr,
> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index
> 37f975875102..21c47893fcb4 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -48,6 +48,7 @@ struct mmc_ext_csd {
>         u8                      sec_feature_support;
>         u8                      rel_sectors;
>         u8                      rel_param;
> +       u8                      rel_wr_set;
>         bool                    enhanced_rpmb_supported;
>         u8                      part_config;
>         u8                      cache_ctrl;
> diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h index
> d9a65c6a8816..42afd442a70a 100644
> --- a/include/linux/mmc/mmc.h
> +++ b/include/linux/mmc/mmc.h
> @@ -266,6 +266,7 @@ static inline bool mmc_ready_for_data(u32 status)
>  #define EXT_CSD_BKOPS_START            164     /* W */
>  #define EXT_CSD_SANITIZE_START         165     /* W */
>  #define EXT_CSD_WR_REL_PARAM           166     /* RO */
> +#define EXT_CSD_WR_REL_SET             167     /* R/W */
>  #define EXT_CSD_RPMB_MULT              168     /* RO */
>  #define EXT_CSD_FW_CONFIG              169     /* R/W */
>  #define EXT_CSD_BOOT_WP                        173     /* R/W */
> --
> 2.20.1