Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <99e859a3-5a8e-8dc2-5a04-0a63f69173a6@linux.intel.com>
Date:   Fri, 11 Mar 2022 10:24:01 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH v2 -next] i2c: designware: Remove code duplication
Content-Language: en-US
To:     Jan Dabros <jsd@semihalf.com>, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, andriy.shevchenko@linux.intel.com
Cc:     wsa@kernel.org, upstream@semihalf.com
References: <20220310220932.140973-1-jsd@semihalf.com>
From:   Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <20220310220932.140973-1-jsd@semihalf.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/11/22 00:09, Jan Dabros wrote:
> Simplify code by moving common part to one function.
> 
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v1->v2:
> * Add kudos for Andy who suggested this change
> * Get rid of extra function and move common code to psp_send_i2c_req
> * Update commit message and commit title
>    (was "i2c:designware: Add helper to remove redundancy")
>   drivers/i2c/busses/i2c-designware-amdpsp.c | 35 ++++++++++------------
>   1 file changed, 15 insertions(+), 20 deletions(-)
> 
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>