Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Mar 2022 19:55:41 -0800
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
Cc:     krzk+dt@kernel.org, agross@kernel.org, robh+dt@kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, quic_asutoshd@quicinc.com,
        quic_rampraka@quicinc.com, quic_pragalla@quicinc.com,
        quic_sartgarg@quicinc.com, quic_nitirawa@quicinc.com,
        quic_sayalil@quicinc.com
Subject: Re: [PATCH V2] arm64: dts: qcom: sc7280: Enable gcc HW reset
Message-ID: <YirIPRvcSSYhxiNv@ripper>
References: <1646923503-28847-1-git-send-email-quic_c_sbhanu@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1646923503-28847-1-git-send-email-quic_c_sbhanu@quicinc.com>
Precedence: bulk

On Thu 10 Mar 06:45 PST 2022, Shaik Sajida Bhanu wrote:

Without looking at what Krzysztof suggested, I think $subject should
reflect the fact that it's the reset of the two SDCC controllers that
you're adding.

Something like "arm64: dts:qcom: Add resets for SDCC controllers" would allow me to grasp the full
purpose of the patch by only reading the subject.

> Enable gcc HW reset for eMMC and SD card.
> 
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
> 
> Changes since V1:
> 	- Updated commit message, subject and comments in dtsi file as
> 	  suggested by Krzysztof Kozlowski.
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index c07765d..721abf5 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -881,6 +881,9 @@
>  			mmc-hs400-1_8v;
>  			mmc-hs400-enhanced-strobe;
>  
> +			/* Add gcc hw reset dt entry for eMMC */

When you read this comment 2 weeks from now it won't add any value.

> +			resets = <&gcc GCC_SDCC1_BCR>;
> +			reset-names = "core_reset";

Doesn't seem that this binding has been converted to YAML, but the .txt
binding doesn't mention "resets" and I don't see a reason for having a
reset-names for a single reset.

And please keep the empty line before the opp-table.

Regards,
Bjorn

>  			sdhc1_opp_table: opp-table {
>  				compatible = "operating-points-v2";
>  
> @@ -2686,6 +2689,9 @@
>  
>  			qcom,dll-config = <0x0007642c>;
>  
> +			/* Add gcc hw reset dt entry for SD card */
> +			resets = <&gcc GCC_SDCC2_BCR>;
> +			reset-names = "core_reset";
>  			sdhc2_opp_table: opp-table {
>  				compatible = "operating-points-v2";
>  
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
> of Code Aurora Forum, hosted by The Linux Foundation
>