Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7bf43ee7-549e-c98c-1ca9-b5060124c94b@kernel.org>
Date:   Fri, 11 Mar 2022 10:23:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH 3/3] serial: 8250_fintek.c: Clean up set_termios() message
Content-Language: en-US
To:     Trevor Woerner <twoerner@gmail.com>, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-serial@vger.kernel.org
References: <20220311070203.18159-3-twoerner@gmail.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20220311070203.18159-3-twoerner@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11. 03. 22, 8:02, Trevor Woerner wrote:
> Clean up the status message that is given in the case where a custom
> termios() is not installed.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>   drivers/tty/serial/8250/8250_fintek.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index 03ad2354d808..dcab23d1965e 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -333,7 +333,7 @@ static void fintek_8250_set_termios(struct uart_port *port,
>   	default:
>   		/* Don't change clocksource with unknown PID */
>   		dev_warn(port->dev,
> -			"%s: pid: %x Not support. use default set_termios.\n",
> +			"%s: chipID: %x not supported; using default set_termios.\n",
>   			__func__, pdata->pid);

So the variable calls it PID, the comment calls it PID and you change 
the report to chipID. Why?

thanks,
-- 
js
suse labs