Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Mar 2022 16:32:36 +0000
From:   Juri Lelli <juri.lelli@redhat.com>
To:     Daniel Bristot de Oliveira <bristot@kernel.org>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Clark Williams <williams@redhat.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH V3 00/15] rtla: Improved tracing support
Message-ID: <Yit5pMZVCPFAXE/e@localhost.localdomain>
References: <cover.1646247211.git.bristot@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1646247211.git.bristot@kernel.org>
Precedence: bulk

Hi,

On 02/03/22 20:01, Daniel Bristot de Oliveira wrote:
> This set introduces some tracing facilities to rtla tools:
> 
> - Add the possibility to change the tracing_thresh to osnoise,
> allowing a fine tune of OS noise detection.
> 
> - Add the auto-tracing feature (-a threshold us), which aims
> helping the first approach to a problem by setting common
> tracing features with a single parameter.
> 
> - Add -e/--event option, allowing osnoise and timerlat to
> enable additional trace events via (possible multiple)
> -e sys:event options.
> 
> - Add the --filter option to filter the previous -e event.
> 
> - Add the --trigger option to allow the usage of tracing
> trigger of the previously set -e event. If the trigger
> is hist: one, rtla automatically saves the hist file
> associated with the -e event.
> 
> And some more improvements:
> 
> - Add --dma-latency option to tune exit from idle latencies
> 
> - Some minor fixes
> 
> Changes from V2:
>  - Rebased to for-next
>  - Add --dma-latency
>  - Some more fixes
> Changes from V1:
>  - Add -e to osnoise/timerlat hist
>  - Add --trigger
>  - Add --filter
>  - Add support to save hist file
>  - Function name refactoring

I took this for a spin and it looked good to me!

Tested-by: Juri Lelli <juri.lelli@redhat.com>

Thanks,
Juri