Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Mar 2022 10:59:20 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, qwen@analogixsemi.com,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        mliu@analogixsemi.com, hsinyi@chromium.org, bliang@analogixsemi.com
Subject: Re: [PATCH] drm/bridge: anx7625: Fix not correct get property counts
Message-ID: <20220311025920.GA1346668@anxtwsw-Precision-3640-Tower>
References: <20220310091653.1298588-1-xji@analogixsemi.com>
 <YipJR6ERQM598/XE@ravnborg.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YipJR6ERQM598/XE@ravnborg.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zy6+8l14rm1ed/5/vxLMSe4AM9vp+lSF0F/jvJeycm9ti0eWPcmC8jsiMKi7?=
 =?us-ascii?Q?p23lTFlG+ExEjMze9ggI8NH8gHr+7kYr150KCj4IkVMrPQhP1DEgp+Obr6i8?=
 =?us-ascii?Q?p9HA0G0dcREBekDMkumrBEwbOhvNAOOSE7y84ckz8nQ/4yMpBa3oClFxrO/A?=
 =?us-ascii?Q?vTV9T0oQqtdPGKqvzt+v8RMLF5hFCVnTP2vjcl7NnrQV4Mw2pzqOuIV4vgZ8?=
 =?us-ascii?Q?5HcvGMbkGqmI11pqStqSh0VfqOurAUrDqsi8w9+vrgbhF0H1XoW1QFHZkqeq?=
 =?us-ascii?Q?9L0w/Mf77UA9L3fFr1NumUXOyrpZFGA8WcKNm2YfAd7ZyOnSvnzXTC4SdhC0?=
 =?us-ascii?Q?8XKsPYctzYFbg3RtJfv+wbrq2KMe6JY1Nt5Umb24eSlmykq16UIeNFx5Bi/c?=
 =?us-ascii?Q?k/E+aOFvN0NY9ijL8iNi7B3laQldq1J0qCbLaOSAYYxw46U6eQpELS6hH0g3?=
 =?us-ascii?Q?WE2vnvhXIVN9g6T6beNVYGBj57aA3Z40LltMWbCTjJp7+Gnzu93+ElfQxEcA?=
 =?us-ascii?Q?9LbUnNNEaEMkwg5Wd/wnFbJ6svorsqIaHOwQYE0iiajfrmdNsCtxLnniZk6H?=
 =?us-ascii?Q?4j/6OcJCY6CCIqUBlCzPCZeem89983ot9nWthQkQNVuCrAqm4vmGBZIjktPi?=
 =?us-ascii?Q?tv6e7ZGCzUvcq42wKXhcb8t0efgiLeOwWyn2rocU747j46sWEKTP25O1YLlP?=
 =?us-ascii?Q?zHpIwgjGEN2sV1yXwuX4uzGEPkGijEp2QACPg52o2eGt9T3Dr7R7YYt49Kby?=
 =?us-ascii?Q?WG43myooovjeAje/RpOrxkERrIfS1oIXnHMaw2qGxDQEdKHhPR32EScH3kHu?=
 =?us-ascii?Q?GkNxbEEu5DeDovjuwEkdl4Tz1Liqg/JguZX/1XibpGuUUKo3RSpt2i6OlAni?=
 =?us-ascii?Q?ZwJ68/+ZcfSzCBT3ZxwS7/8+hR5uFdd8TS1thRwoetnBjuyc4y/NV4VMloYf?=
 =?us-ascii?Q?pL7Wz272B31aQR7DSNNvyDxN5aAb4iqPb2bea7u7UdiVWA3a6bm5x7Y9MzXk?=
 =?us-ascii?Q?rR28fYod6vWL5oitv+APTBnurhbhScRsWGXNvx/fnFl3v/imc/mhLDQABDAY?=
 =?us-ascii?Q?hhqy1mQfOsv7F6UMSQ3Q4pXxejmt/txKYl+vtpAtLtBr2TzEwSUaDzi2jAQ9?=
 =?us-ascii?Q?uubqnmLhYPl5/MCYV9S1oXn9bmXhxPcm9tdTXgsBGUW3MYxRxn1S5Jd0JTae?=
 =?us-ascii?Q?O7BtqtcNVt6lLA9/ROngQ3ZAUaFF4Y6YNPCtimRWsy0BU3hBGNdvH7bwfl4N?=
 =?us-ascii?Q?3xXczsu0vSaUSGDPJsOZURmDwx6jYacpm7C+by/NfMMNRemf03mDecQM+S7X?=
 =?us-ascii?Q?8kZvmQqVVornv55HY3q/5jyt5v8jHLnKwPQNrLp8DyfiQbv9wT+ZAUgmDRmT?=
 =?us-ascii?Q?EMx4w+7WPrqTXJGsSdJNwsbhW2k10C+DuSGqoVfKG+wKZKChmGorrzpzplvZ?=
 =?us-ascii?Q?4kYKqZUO7Uefd7hd2rx1R2FW+j71VqIO?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cf39a02-f025-4d84-389d-08da030b27f4
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 02:59:28.0729
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gBOn88w6jrbmfpYhvJBrbWwxm3PYqZSkYz556yCpHIq6hmH7obStjtTzZtE6vhQMqGAOdVjdvupDjAvPcLonKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB1200
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 10, 2022 at 07:53:59PM +0100, Sam Ravnborg wrote:
> Hi Xin,
> 
> On Thu, Mar 10, 2022 at 05:16:53PM +0800, Xin Ji wrote:
> > The property length which returns from "of_get_property", divided by
> > sizeof(int) to get the total property counts.
> > 
> > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >  drivers/gpu/drm/bridge/analogix/anx7625.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index c6a9a02ed762..87081d5b408d 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1594,6 +1594,7 @@ static int anx7625_get_swing_setting(struct device *dev,
> >  
> >  	if (of_get_property(dev->of_node,
> >  			    "analogix,lane0-swing", &num_regs)) {
> > +		num_regs /= sizeof(int);
> 
> Since the property is an array maybe use: of_property_read_u8_array()
> 
> 	Sam
Hi Sam, OK, I'll use it to get property data.

Thanks,
Xin