Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <20220310210633.095f0245@suse.de>
References: <20220310142455.23127-1-vkarasulli@suse.de> <20220310142455.23127-3-vkarasulli@suse.de>
 <20220310210633.095f0245@suse.de>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Fri, 11 Mar 2022 18:03:57 +0900
Message-ID: <CAKYAXd_ij3WqJHQZvH458XRwLBtboiJnr-fK0hVPDi_j_8XDZQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] exfat currently unconditionally strips trailing
 periods '.' when performing path lookup, but allows them in the filenames
 during file creation. This is done intentionally, loosely following Windows
 behaviour and specifications which state:
To:     David Disseldorp <ddiss@suse.de>
Cc:     Vasant Karasulli <vkarasulli@suse.de>,
        Sungjong Seo <sj1557.seo@samsung.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Takashi Iwai <tiwai@suse.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

2022-03-11 5:06 GMT+09:00, David Disseldorp <ddiss@suse.de>:
> Thanks for reworking these changes, Vasant.
>
> Please trim the 1/2 and 2/2 patch subjects down to around 50 chars
> (including a "exfat: " prefix), with the details moved into the commit
> message body...
>
> On Thu, 10 Mar 2022 15:24:55 +0100, Vasant Karasulli wrote:
>
>>   #exFAT
>>   The concatenated file name has the same set of illegal characters as
>>   other FAT-based file systems (see Table 31).
>>
>>   #FAT
>>   ...
>>   Leading and trailing spaces in a long name are ignored.
>>   Leading and embedded periods are allowed in a name and are stored in
>>   the long name. Trailing periods are ignored.
>>
>> Note: Leading and trailing space ' ' characters are currently retained
>> by Linux kernel exfat, in conflict with the above specification.
>
> I think it makes sense to mention your findings from the Windows tests
> here. E.g. "Windows 10 also retains leading and trailing space
> characters".
Windows 10 do also strip them. So you can make another patch to strip
it as well as trailing periods.
>
>> Some implementations, such as fuse-exfat, don't perform path trailer
>> removal. When mounting images which contain trailing-dot paths, these
>> paths are unreachable, e.g.:
>>
>>   + mount.exfat-fuse /dev/zram0 /mnt/test/
>>   FUSE exfat 1.3.0
>>   + cd /mnt/test/
>>   + touch fuse_created_dots... '  fuse_created_spaces  '
>>   + ls -l
>>   total 0
>>   -rwxrwxrwx 1 root 0 0 Aug 18 09:45 '  fuse_created_spaces  '
>>   -rwxrwxrwx 1 root 0 0 Aug 18 09:45  fuse_created_dots...
>>   + cd /
>>   + umount /mnt/test/
>>   + mount -t exfat /dev/zram0 /mnt/test
>>   + cd /mnt/test
>>   + ls -l
>>   ls: cannot access 'fuse_created_dots...': No such file or directory
>>   total 0
>>   -rwxr-xr-x 1 root 0 0 Aug 18 09:45 '  fuse_created_spaces  '
>>   -????????? ? ?    ? ?            ?  fuse_created_dots...
>>   + touch kexfat_created_dots... '  kexfat_created_spaces  '
>>   + ls -l
>>   ls: cannot access 'fuse_created_dots...': No such file or directory
>>   total 0
>>   -rwxr-xr-x 1 root 0 0 Aug 18 09:45 '  fuse_created_spaces  '
>>   -rwxr-xr-x 1 root 0 0 Aug 18 09:45 '  kexfat_created_spaces  '
>>   -????????? ? ?    ? ?            ?  fuse_created_dots...
>>   -rwxr-xr-x 1 root 0 0 Aug 18 09:45  kexfat_created_dots
>>   + cd /
>>   + umount /mnt/test/
>>
>> With this change, the "keep_last_dots" mount option can be used to access
>> paths with trailing periods and disallow creating files with names with
>> trailing periods. E.g. continuing from the previous example:
>>
>>   + mount -t exfat -o keep_last_dots /dev/zram0 /mnt/test
>>   + cd /mnt/test
>>   + ls -l
>>   total 0
>>   -rwxr-xr-x 1 root 0 0 Aug 18 10:32 '  fuse_created_spaces  '
>>   -rwxr-xr-x 1 root 0 0 Aug 18 10:32 '  kexfat_created_spaces  '
>>   -rwxr-xr-x 1 root 0 0 Aug 18 10:32  fuse_created_dots...
>>   -rwxr-xr-x 1 root 0 0 Aug 18 10:32  kexfat_created_dots
>
> It'd be nice to demonstrate "keep_last_dots" creation here as well, e.g.
>
>   + echo > kexfat_created_dots_again...
>   sh: kexfat_created_dots_again...: Invalid argument
>
> @Namjae: not sure whether this is what you had in mind for preventing
> creation of invalid paths. What's your preference?
Look like what I wanted.

Thanks!
>
> Cheers, David
>