Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Liam Merwick <liam.merwick@oracle.com>
To:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, x86@kernel.org
Cc:     pbonzini@redhat.com, bp@alien8.de, thomas.lendacky@amd.com,
        brijesh.singh@amd.com, krish.sadhukhan@oracle.com,
        liam.merwick@oracle.com
Subject: [PATCH 5.4 3/4] x86/mm/pat: Don't flush cache if hardware enforces cache coherency across encryption domnains
Date:   Fri, 11 Mar 2022 11:29:26 +0000
Message-Id: <20220311112927.8400-4-liam.merwick@oracle.com>
In-Reply-To: <20220311112927.8400-1-liam.merwick@oracle.com>
References: <20220311112927.8400-1-liam.merwick@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QJq+TQnGwlLXErmiRkz4iyfAbYwfZJYllpc7nNO7KQoMFG30tH+TQSdS0veO?=
 =?us-ascii?Q?XCXK/JmpejKam7YuAV+utC17CCz71ypdL5JOF2W7epY5c4UdT1BdrDwNZ+ku?=
 =?us-ascii?Q?BaLmxmKJ+9ER+dlCBwDFRxIqPMCCyiYosZmO4Fs4rBazFWu2d3lFTU4byszF?=
 =?us-ascii?Q?QVe1ukwu/s2VoCbhFp2gLIdIZ/gwh4FVcDKzW8KsmbXsvJqtLkJgrvno6ARU?=
 =?us-ascii?Q?Y35ngpXCyYQgqRvsaSiWwlt/CSMKcxcEwoYlet85UgV/DvY7BCiH8Y9hGX3C?=
 =?us-ascii?Q?X+9OA2FlVK0OkZt2XCy1gPsjFesSVbBnsHP/HovKxTMhHxt9fwoOpN9bQ6z6?=
 =?us-ascii?Q?7XNmIw69mQpaPws58tGp0VY+6iBOmD2ERGPK4zUiyd0xiKb944qypN2x0El4?=
 =?us-ascii?Q?zBX5TM0Nc0LvytQW3HpZQx8S6MHEVjeAE3WYBJZh6839l9ATn/I39mJWenvU?=
 =?us-ascii?Q?VSEOarIKlkyYVSFKQWSzH7UznjR0CORVXh1W0yk7XR4cvLaHHoWi/AABHFmn?=
 =?us-ascii?Q?agl0lZ6nY2xYdFt1nP6W8ppHQ89D47+cUsKMrgVOUz+xWb6RZB1W9MtOojkg?=
 =?us-ascii?Q?pqQkGpebP30hHi65zrh3ppCqlhhdIRTA/XCa2n4w7OCiv5OrzS4OBkkLlQ3c?=
 =?us-ascii?Q?GRKm2Opw4Eon+TfkFCHeDak9ClNYgExeQS84E/JFkLxrb1MjVVpBerVWOc3s?=
 =?us-ascii?Q?6Fmsx3fDevte7fwgCAI4u/3dwhGmJgMxUuBhwE4fF7GR/YKg/c8ZchtYkrRt?=
 =?us-ascii?Q?yaAl9lbE0VjeZ50y0Q5QAdQL6M02dBObVhUU96S/99JFO5t8TCKjN9XmyQHU?=
 =?us-ascii?Q?O11bYQNrAvtDY8tP5DY8flYlx/f4QJDijAcPC04HVU+tdadqS/jzYvFTLGMX?=
 =?us-ascii?Q?OG2UKVvbPGyVHaZ8G1R8MRLvErp2+dLMni+yXG8eB8K7sxMn66BqvgNwXsqR?=
 =?us-ascii?Q?ST9kDtFsEudVF6oIZaCMMEljmmvB/bXmmTGygIb+lAmLIpH7D5YTpcKP+80b?=
 =?us-ascii?Q?ZvVLIgG+mAdnCNXgqUqE8ZUM6gf6YtKF3VAc7GO7DiyfcuW7dySmDZzo2O87?=
 =?us-ascii?Q?UxduD/8TpUag1c6NJzTRVcm5lo1l/m8XVba3i+AbRY+LYuHLIjYwvYBTqn5j?=
 =?us-ascii?Q?KnVscHpcvLqwavj0/YB/4Jj+OwweGFYNGCDRns9b4+yBgPQgpoCXgvMUfVvZ?=
 =?us-ascii?Q?9mbffZVmy3989BRsZivmbtqArbSCwyfHJb5h3enEEe0blYGXqQ+kfcjDZxkL?=
 =?us-ascii?Q?IjZiTMmOEN9aKQJTQL2AJbthEk0NS3qF0QlRru/B4wKEFvE+osDe+oo2Iwrx?=
 =?us-ascii?Q?HFQDo0KP+fhBBjROBGJGSRI0hwht6AaoGkONsLuH0RuZqbgqLN1Y/LROl4Wf?=
 =?us-ascii?Q?HGd+K6ElUXiNgVnNkSZJSzWSxmo1RpTsOGxFYlYG/b2Lke9Lw4KM4elxTtI3?=
 =?us-ascii?Q?0fS/L6czjKf8tun1r+iyq/wAwt3tBKMyn6l8vQMKdWnQ0ERFxjV65HmiI9Ys?=
 =?us-ascii?Q?mcwxUwHeNoBn6ctHrh40WmVfZoGUB3OynQuyeKSqQ2ZZbjLXRZD6fqkqMlb6?=
 =?us-ascii?Q?6ClQhg6apMR/Gh3HHH5yzCACKPdwsdhHC21zyZq2eiNE4EEuP6Wqk6Uecios?=
 =?us-ascii?Q?uxgEfXaM1pMviD5bvTAB5C8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 17770c70-6016-4fd5-c8ab-08da035284ba
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5030.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 11:30:17.8050
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3JwaBQiU4rW0XvKU5uRm1Il9bNTs/Zi3UwzPib3hrwnn7Wanx8xqak5Dh7odS18I1PE94PepnuBdQ0BFsy9ggg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1430
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10282 signatures=692556
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 bulkscore=0
 phishscore=0 malwarescore=0 suspectscore=0 mlxscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203110055
X-Proofpoint-GUID: EO9kJN-RBLY62hdUooQlLsP000CP1eO8
X-Proofpoint-ORIG-GUID: EO9kJN-RBLY62hdUooQlLsP000CP1eO8
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Krish Sadhukhan <krish.sadhukhan@oracle.com>

commit 75d1cc0e05af579301ce4e49cf6399be4b4e6e76 upstream.

In some hardware implementations, coherency between the encrypted and
unencrypted mappings of the same physical page is enforced. In such a
system, it is not required for software to flush the page from all CPU
caches in the system prior to changing the value of the C-bit for the
page. So check that bit before flushing the cache.

 [ bp: Massage commit message. ]

Suggested-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200917212038.5090-3-krish.sadhukhan@oracle.com
Signed-off-by: Liam Merwick <liam.merwick@oracle.com>
---
 arch/x86/mm/pageattr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index 281e584cfe39..d61313f5c5b9 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -1967,7 +1967,7 @@ static int __set_memory_enc_dec(unsigned long addr, int numpages, bool enc)
 	/*
 	 * Before changing the encryption attribute, we need to flush caches.
 	 */
-	cpa_flush(&cpa, 1);
+	cpa_flush(&cpa, !this_cpu_has(X86_FEATURE_SME_COHERENT));
 
 	ret = __change_page_attr_set_clr(&cpa, 1);
 
-- 
2.27.0