Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp697507pxp; Fri, 11 Mar 2022 12:40:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwx3/OPMPkQuObiFtbnMx/sf4Wuj4EFay/YuZRuvv2kdU9D/vQKqMtdcM40NVwz5pjkT8Zf X-Received: by 2002:a63:944:0:b0:374:5324:eea1 with SMTP id 65-20020a630944000000b003745324eea1mr9893002pgj.366.1647031242435; Fri, 11 Mar 2022 12:40:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647031242; cv=none; d=google.com; s=arc-20160816; b=FNWwNFk8L9ag/dd6E3E2TluzmLA7Se6HanUOx6H24L0BjonXTFizvOAtspB3mQJ4Pz qsNQHxKdjga5kJ0144bYv46AiNqfKc/p5S7FZMUEI6aFJaCp9UJkLV70XM5KY8yiCArB a+SxgLf5aOJC0SRLjjHt+Hm+Xlqqcc8ngARSk7ruzGhphF1RQJaSPbJI/xwYuE20QkHY qnCOTuX2YvJh9edilZ4PsejbVSuEamvPF5XX1Q2eQdPQwFMqJ6zWAKZpIZ98FFfSgG0y bwXcJHlLyT28hu80ziKVCh8BBdy4tGryC2Kuwq0DKmvYWWWc9ojVKhAQAxK2xNo2HbjZ IL9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:message-id:date:subject:cc:to :from; bh=PZik48CDl4NTh8V8pU0BjeRE5OMY5u/gVavkDrajapo=; b=WYfJilAQKcAqX7dVPmMP2vRKCn7btmhODOeo8LYuP5WNW7fJFVd9AgYnG6vEb2fUdJ pGhzCtZQcywRnZ84I7oqaOYLy2e7IKVxY53CxjYUwuoOTnJOLQRA6yeXzLv0v3k9ZgbF 7ozUOqHs7aAUm2XzbxXErVT2bU6+PbH60XQTM6uzcdYD6VVsPz1hA8RacOg5V5Ih0xCL 7ggvpqM4PTUt6/S8AC7NXPzV0nObu1TX4udk3FbSrDgNMZXR5UkM7f35TSw5RMcV/E89 eMawISUwGOsZp4KcFoe84kB70Ct/SQEwmwKJEstXBcmisTrdO7bckO+5JWf5ZCvSDpfs F5Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@embeddedTS.com header.s=mailanyone20220121 header.b=ElXUfmpR; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=embeddedts.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id h6-20020a17090a648600b001bd14e030d0si5623215pjj.168.2022.03.11.12.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 12:40:42 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@embeddedTS.com header.s=mailanyone20220121 header.b=ElXUfmpR; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=embeddedts.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 66C711D3AF0; Fri, 11 Mar 2022 12:37:53 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350866AbiCKSVU (ORCPT + 99 others); Fri, 11 Mar 2022 13:21:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232361AbiCKSVT (ORCPT ); Fri, 11 Mar 2022 13:21:19 -0500 Received: from smtp-out3.electric.net (smtp-out3.electric.net [208.70.128.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA12EADD44; Fri, 11 Mar 2022 10:20:13 -0800 (PST) Received: from 1nSjs1-0006JP-VO by out3d.electric.net with emc1-ok (Exim 4.94.2) (envelope-from ) id 1nSjs3-0006N2-T2; Fri, 11 Mar 2022 10:20:11 -0800 Received: by emcmailer; Fri, 11 Mar 2022 10:20:10 -0800 Received: from [66.210.251.27] (helo=mail.embeddedts.com) by out3d.electric.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSjs1-0006JP-VO; Fri, 11 Mar 2022 10:20:09 -0800 Received: from tsdebian.Massive (unknown [75.164.75.221]) by mail.embeddedts.com (Postfix) with ESMTPSA id F2ACF1CCE; Fri, 11 Mar 2022 11:20:08 -0700 (MST) From: Kris Bahnsen To: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Kris Bahnsen Subject: [PATCH] gpio: ts4900: Fix comment formatting and grammar Date: Fri, 11 Mar 2022 10:19:58 -0800 Message-Id: <20220311181958.4487-1-kris@embeddedTS.com> X-Mailer: git-send-email 2.11.0 X-Outbound-IP: 66.210.251.27 X-Env-From: kris@embeddedTS.com X-Proto: esmtps X-Revdns: wsip-66-210-251-27.ph.ph.cox.net X-HELO: mail.embeddedts.com X-TLS: TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256 X-Authenticated_ID: X-Virus-Status: Scanned by VirusSMART (c) X-Virus-Status: Scanned by VirusSMART (b) X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedTS.com; s=mailanyone20220121;h=Message-Id:Date:To:From; bh=PZik48CDl4NTh8V8pU0BjeRE5OMY5u/gVavkDrajapo=;b=ElXUfmpRjmprbRp2GNubtyCNDvC/UvS300xvrbE2g6a8DNpQvuKunSMl25PIAmmkwv+cwU77BaTlKXeUb0L3XsY0wdFKGrz1qoHdn6ORdUmEXt55l+3HfO6hLv26iM41wVViLY7fl6uBkbJqiNHX2jANI4Rz8v9UXkscnYMNxLG/RFlZX+UuuE/CDLf1sTLZBf5MPRCUEotsVRBMh/LqZ6oKRnvFFaxNQ/IqxWP2/HsAYndtLxEvZbloFrcKOb2s/PllNN51fBEv43oY1yWWiaGoKz4Lk2khZIY6374oGt/8fG0Jf3nm/rtyfJGg6U68e9mo1Glsj3ne0lfrE01OkQ==; X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-FM-Delivery-Delay: 15749372,23518412 X-PolicySMART: 13164782, 15749372, 26810492 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The issues were pointed out after the prior commit was applied Signed-off-by: Kris Bahnsen --- drivers/gpio/gpio-ts4900.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-ts4900.c b/drivers/gpio/gpio-ts4900.c index d918d2df4de2..ede605b8e098 100644 --- a/drivers/gpio/gpio-ts4900.c +++ b/drivers/gpio/gpio-ts4900.c @@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip, { struct ts4900_gpio_priv *priv = gpiochip_get_data(chip); - /* Only clear the OE bit here, requires a RMW. Prevents potential issue - * with OE and data getting to the physical pin at different times. + /* + * Only clear the OE bit here, requires a RMW. Prevents a potential issue + * with OE and DAT getting to the physical pin at different times. */ return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0); } @@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip, unsigned int reg; int ret; - /* If changing from an input to an output, we need to first set the - * proper data bit to what is requested and then set OE bit. This - * prevents a glitch that can occur on the IO line + /* + * If changing from an input to an output, we need to first set the + * GPIO's DAT bit to what is requested and then set the OE bit. This + * prevents a glitch that can occur on the IO line. */ regmap_read(priv->regmap, offset, ®); if (!(reg & TS4900_GPIO_OE)) { -- 2.11.0