Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com>
In-Reply-To: <20220210134049.32576-2-ariel.dalessandro@collabora.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 10 Mar 2022 09:29:23 -0300
Message-ID: <CAOMZO5DuB4d1243H46d1=heiNiz+pQVkjrGU+zV_r3GFKRTZfQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add
 tlv320aic31xx audio card node
To:     "Ariel D'Alessandro" <ariel.dalessandro@collabora.com>
Cc:     Linux-ALSA <alsa-devel@alsa-project.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, Sascha Hauer <kernel@pengutronix.de>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Michael Trimarchi <michael@amarulasolutions.com>,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Ariel,

On Thu, Feb 10, 2022 at 10:41 AM Ariel D'Alessandro
<ariel.dalessandro@collabora.com> wrote:

> +&i2c2 {
> +       clock-frequency = <400000>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c2>;
> +       status = "okay";
> +
> +       codec: tlv320dac3101@18 {
> +               #sound-dai-cells = <0>;
> +               compatible = "ti,tlv320dac3101";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_dac_rst>;
> +               reg = <0x18>;
> +
> +               ai31xx-micbias-vg = <MICBIAS_AVDDV>;
> +
> +               HPVDD-supply = <&buck4_reg>;
> +               SPRVDD-supply = <&vdd_input>;
> +               SPLVDD-supply = <&vdd_input>;
> +               AVDD-supply = <&buck4_reg>;
> +               IOVDD-supply = <&buck4_reg>;
> +               DVDD-supply = <&buck5_reg>;
> +               reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>;
> +
> +               clocks = <&clk IMX8MN_CLK_SAI3_ROOT>;
> +               clock-names = "mclk";

The clocks and clock-names properties are not documented in the codec bindings.

Also, the driver does not use call clk_get() on this mclk clock.

You should drop the clocks and clock-names properties.