Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Chen Jingwen <chenjingwen6@huawei.com>
To:     Chen Jingwen <chenjingwen6@huawei.com>,
        "linux-kernel @ vger . kernel . org" <linux-kernel@vger.kernel.org>,
        "keyrings @ vger . kernel . org" <keyrings@vger.kernel.org>,
        Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>,
        David Howells <dhowells@redhat.com>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>,
        James Morris <jmorris@namei.org>,
        "Serge E . Hallyn" <serge@hallyn.com>
Subject: strncmp might be wrong used in insert-sys-cert.c
Date:   Fri, 11 Mar 2022 15:23:39 +0800
Message-ID: <20220311072339.41306-1-chenjingwen6@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi, All.

When I scanned scripts/insert-sys-cert.c, I encounter that

>	    strncmp(cert_sym.content, cert, cert_size) == 0) {
>		warn("Certificate was already inserted.\n");
>		exit(EXIT_SUCCESS);

strncmp will stop if it sees b'\0'.  I think should use memcmp here.
For example, we have two _different_ certificates,
one was already inserted and another one is being processed by insert-sys-cert.
In case both certificates start with the same and follow a '\0',
another new one won't be overridden, which is not expected, right?

Chen Jingwen