Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220308130643.260683-1-cbranchereau@gmail.com>
 <20220308130643.260683-5-cbranchereau@gmail.com> <Yip8AiKNOILjf0uj@robh.at.kernel.org>
 <PC0L8R.DOJJ0CSJMHTW@crapouillou.net>
In-Reply-To: <PC0L8R.DOJJ0CSJMHTW@crapouillou.net>
From:   Rob Herring <robh@kernel.org>
Date:   Fri, 11 Mar 2022 09:02:42 -0600
Message-ID: <CAL_JsqJKfypZRq1D02+fyNABoHRrEYdySzfP7nW62Cv44QymBA@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Christophe Branchereau <cbranchereau@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "open list:MIPS" <linux-mips@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Mar 11, 2022 at 7:05 AM Paul Cercueil <paul@crapouillou.net> wrote:
>
> Hi Rob,
>
> Le jeu., mars 10 2022 at 16:30:26 -0600, Rob Herring <robh@kernel.org>
> a =C3=A9crit :
> > On Tue, Mar 08, 2022 at 02:06:43PM +0100, Christophe Branchereau
> > wrote:
> >>  Add binding for the leadtek ltk035c5444t, which is a 640x480
> >>  mipi-dbi over spi / 24-bit RGB panel based on the newvision
> >>  NV03052C chipset.
> >>
> >>  It is found in the Anbernic RG350M mips handheld.
> >>
> >>  Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com>
> >>  ---
> >>   .../panel/leadtek,ltk035c5444t-spi.yaml       | 59
> >> +++++++++++++++++++
> >>   1 file changed, 59 insertions(+)
> >>   create mode 100644
> >> Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-s=
pi.yaml
> >
> > We have 18 SPI based panels already:
> >
> > $ git grep -i 'spi.* {'
> > Documentation/devicetree/bindings/display/panel/
> > Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml:
> >   spi {
> > Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml:
> >   spi {
> > Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml:
> >   spi {
> > Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml:
> >   spi {
> > Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml:
> >    spi {
> > Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54n=
t.yaml:
> >    spi {
> > Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml:
> > spi {
> > Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml=
:
> >    spi {
> > Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml:
> >   spi0 {
> > Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml:
> >   spi {
> > Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml=
:
> >    spi {
> > Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml=
:
> >    spi {
> > Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml:
> >    spi {
> > Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml:
> >    spi {
> > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml:
> >    spi {
> > Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml:
> >   spi {
> > Documentation/devicetree/bindings/display/panel/tpo,td.yaml:    spi {
> > Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml:
> > spi {
> >
> > Most except for the Samsung ones look like they'd fit in our
> > definition
> > of 'simple panels' which primarily means 1 supply.
> >
> > So I think it is time for a panel-simple-spi.yaml binding to combine
> > all
> > these. But I'm not going to make the person adding the 19th case to do
> > that, and this otherwise looks fine:
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> I actually thought you sent a patch for this already (I remember you
> talking about it last a binding for a new SPI panel has been added).

It was just adding spi-peripheral-props.yaml reference that I sent.

> I will work on it next week - provided Cristophe's patch has been
> merged before.

Thanks!

Rob