Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <cover.1647006877.git.mchehab@kernel.org> <b7e9058b5caac542eb06b5ae313d72218ff848e3.1647006877.git.mchehab@kernel.org>
In-Reply-To: <b7e9058b5caac542eb06b5ae313d72218ff848e3.1647006877.git.mchehab@kernel.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 11 Mar 2022 15:18:49 +0100
Message-ID: <CAMuHMdWLaVdUR+pZpqof7bh3E2FEYOykEH+icLy07u9jYa-_rA@mail.gmail.com>
Subject: Re: [PATCH v2 10/38] media: platform: place Renesas drivers on a
 separate dir
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     =?UTF-8?Q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>,
        Cai Huoqing <caihuoqing@baidu.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Dillon Min <dillon.minfei@gmail.com>,
        Dmitry Osipenko <digetx@gmail.com>,
        Eugen Hristev <eugen.hristev@microchip.com>,
        Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Herman <herman.yim88@gmail.com>,
        Jacopo Mondi <jacopo@jmondi.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com>,
        Ming Qian <ming.qian@nxp.com>,
        Rui Miguel Silva <rmfrfs@gmail.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Suresh Udipi <sudipi@jp.adit-jv.com>,
        Tang Bin <tangbin@cmss.chinamobile.com>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Media Mailing List <linux-media@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Mauro,

On Fri, Mar 11, 2022 at 3:08 PM Mauro Carvalho Chehab
<mchehab@kernel.org> wrote:
> In order to cleanup the main platform media directory, move Renesas
> driver to its own directory.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/38] at: https://lore.kernel.org/all/cover.1647006877.git.mchehab@kernel.org/
>
>  MAINTAINERS                                   |  16 +--
>  drivers/media/platform/Kconfig                | 113 +----------------
>  drivers/media/platform/Makefile               |   9 +-
>  drivers/media/platform/renesas/Kconfig        | 119 ++++++++++++++++++
>  drivers/media/platform/renesas/Makefile       |  14 +++
>  .../media/platform/{ => renesas}/rcar-fcp.c   |   0
>  .../media/platform/{ => renesas}/rcar-isp.c   |   0
>  .../platform/{ => renesas}/rcar-vin/Kconfig   |   0
>  .../platform/{ => renesas}/rcar-vin/Makefile  |   0
>  .../{ => renesas}/rcar-vin/rcar-core.c        |   0
>  .../{ => renesas}/rcar-vin/rcar-csi2.c        |   0
>  .../{ => renesas}/rcar-vin/rcar-dma.c         |   0
>  .../{ => renesas}/rcar-vin/rcar-v4l2.c        |   0
>  .../{ => renesas}/rcar-vin/rcar-vin.h         |   0
>  .../media/platform/{ => renesas}/rcar_drif.c  |   0
>  .../media/platform/{ => renesas}/rcar_fdp1.c  |   0
>  .../media/platform/{ => renesas}/rcar_jpu.c   |   0
>  .../platform/{ => renesas}/renesas-ceu.c      |   0
>  drivers/media/platform/{ => renesas}/sh_vou.c |   0
>  19 files changed, 144 insertions(+), 127 deletions(-)
>  create mode 100644 drivers/media/platform/renesas/Kconfig
>  create mode 100644 drivers/media/platform/renesas/Makefile
>  rename drivers/media/platform/{ => renesas}/rcar-fcp.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-isp.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/Kconfig (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/Makefile (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-core.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-csi2.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-dma.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-v4l2.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar-vin/rcar-vin.h (100%)
>  rename drivers/media/platform/{ => renesas}/rcar_drif.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar_fdp1.c (100%)
>  rename drivers/media/platform/{ => renesas}/rcar_jpu.c (100%)
>  rename drivers/media/platform/{ => renesas}/renesas-ceu.c (100%)
>  rename drivers/media/platform/{ => renesas}/sh_vou.c (100%)

Looks like you missed the vsp1 driver code and its entry in the
MAINTAINERS file...

> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig

> -
> -config VIDEO_RENESAS_VSP1
> -       tristate "Renesas VSP1 Video Processing Engine"
> -       depends on V4L_MEM2MEM_DRIVERS
> -       depends on VIDEO_V4L2
> -       depends on ARCH_RENESAS || COMPILE_TEST
> -       depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> -       select MEDIA_CONTROLLER
> -       select VIDEO_V4L2_SUBDEV_API
> -       select VIDEOBUF2_DMA_CONTIG
> -       select VIDEOBUF2_VMALLOC
> -       help
> -         This is a V4L2 driver for the Renesas VSP1 video processing engine.
> -
> -         To compile this driver as a module, choose M here: the module
> -         will be called vsp1.
> -
>  config VIDEO_ROCKCHIP_RGA
>         tristate "Rockchip Raster 2d Graphic Acceleration Unit"
>         depends on V4L_MEM2MEM_DRIVERS

> --- /dev/null
> +++ b/drivers/media/platform/renesas/Kconfig

> +
> +config VIDEO_RENESAS_VSP1
> +       tristate "Renesas VSP1 Video Processing Engine"
> +       depends on V4L_MEM2MEM_DRIVERS
> +       depends on VIDEO_V4L2
> +       depends on ARCH_RENESAS || COMPILE_TEST
> +       depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> +       select MEDIA_CONTROLLER
> +       select VIDEO_V4L2_SUBDEV_API
> +       select VIDEOBUF2_DMA_CONTIG
> +       select VIDEOBUF2_VMALLOC
> +       help
> +         This is a V4L2 driver for the Renesas VSP1 video processing engine.
> +
> +         To compile this driver as a module, choose M here: the module
> +         will be called vsp1.
> +

... but you did move its Kconfig entry.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds