Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Wu, Hao" <hao.wu@intel.com>
To:     "matthew.gerlach@linux.intel.com" <matthew.gerlach@linux.intel.com>,
        "Xu, Yilun" <yilun.xu@intel.com>,
        "Weight, Russell H" <russell.h.weight@intel.com>,
        "Muddebihal, Basheer Ahmed" <basheer.ahmed.muddebihal@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Zhang, Tianfei" <tianfei.zhang@intel.com>
Subject: RE: [PATCH v2 2/2] drivers: fpga: dfl-pci: Add PCIE device IDs for
 Intel DFL cards
Thread-Topic: [PATCH v2 2/2] drivers: fpga: dfl-pci: Add PCIE device IDs for
 Intel DFL cards
Thread-Index: AQHYLpZSrJ/Kjay1fkqud42wnyDFRKy5j7bw
Date:   Fri, 11 Mar 2022 04:20:51 +0000
Message-ID: <DM6PR11MB381933873A813AC366EC987C850C9@DM6PR11MB3819.namprd11.prod.outlook.com>
References: <20220303003534.3307971-1-matthew.gerlach@linux.intel.com>
 <20220303003534.3307971-3-matthew.gerlach@linux.intel.com>
In-Reply-To: <20220303003534.3307971-3-matthew.gerlach@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.401.20
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0Uj2LStZKBJiO9dBoUR/QujtVCoLsd2z5jisBTAxu0FTX8idTrvC9n3gglT/?=
 =?us-ascii?Q?qjOhfRw0BKVDl9wLw1E0lQqnbA2EvxqfC94mYpxnq/LGxVLZP018RGcm3SBf?=
 =?us-ascii?Q?K0rWKNWURcq2qOf9jdDlwHaukW3OKhx9kd7Tj9L6KJ/n8KaSrnBniQ9wlHi0?=
 =?us-ascii?Q?Fy/P5lySdVhzUwhsSYtXeL2IGdtyUiM+Ln4jP5EewwGmzD/aVrNLQXnT2Y0C?=
 =?us-ascii?Q?ohGNyVWfj7VCxFboAYo7q88hLSMbrGtx1hqzwy+Y3Js2El4Hamy8RJSeAStF?=
 =?us-ascii?Q?sGS3SwauhidMGSoX3R8v0LY07Fd+FYneANtuf54/OEdnGfjMiHLNwvWIGgRf?=
 =?us-ascii?Q?fvVnufjh1Oqqo3Z74XFeKey+Fr9Q8vtdUvJM+0iODr0K0nw0R5AD0BadQEoK?=
 =?us-ascii?Q?vBVsXxxmtSKqvMZtd2KxSMZ/u/W/0kLbd2gq3UmtGi+KCQBrlOLLXpR2Gcwj?=
 =?us-ascii?Q?2jSVobrGm83wNn82zOs1FnvRMGCdl4pZdt35WWugPgc3wzz3qRZa3D/CPqEX?=
 =?us-ascii?Q?1nEbBWemb2SRRUN+PD5evned0Z+ktAhdgBVyux8xrWsKLFl3lwVVzEfXFm3W?=
 =?us-ascii?Q?ypaYflwVnpgWwkuu49T7KOv1+o0P5QcmWaEbnJCz2BUvj2lj5cuEIw7p2Fci?=
 =?us-ascii?Q?tOMIPsMVIRAHA/+T6hLExsCp0rFIczMr6qWZ7ND7F8mhlbJBcem45tUgmWt1?=
 =?us-ascii?Q?pi2VC0RQIu+WHoX3OCDWHNNv6BSAq+dyMjkZM4NQxZ1WznOUF29oGubjeuiC?=
 =?us-ascii?Q?oQRZv/Tde/U6FE5fjEk1cI0PktmtwahGrvwKWOz70KFueKR+M8S02jeUERym?=
 =?us-ascii?Q?kg1bYyjWu6doz/5DuXq7PpwmXjWtLW7pXX9UVdaATRbIzNqVCgH7ABQFuLXp?=
 =?us-ascii?Q?IOhYdROaziyqHyI9xjIc2IwQMpL/z/xKe2zr8DDq1nGbe5RL5CkoXztSIey1?=
 =?us-ascii?Q?jQusGvL8Sjf1r+gAYNZYsmCFY6Y4oOsi+iQE+mOKK+WwriUTFMgwIOuXKYIi?=
 =?us-ascii?Q?dIyxbNgqucUl2hT3SxJRDjfq1CZb+bn6kdVfuJB8G3vIAVCoFK4ggY8977L+?=
 =?us-ascii?Q?FbHjSfwjwZQyK+1/yeYMfUaqyaBgBmtT7THw8kda+d463E+MsQbDx2irwN38?=
 =?us-ascii?Q?gmYpFso5dRm2nmjCx8pJlGMUh+wIhunToaB8ZHHUQJvK9A2Njmr3q4k1RjAd?=
 =?us-ascii?Q?bj5moAWVvlGK300yRlPNfUQm5PhOXfQWi0WQmSGuAsViI+HnN2GtZDDk12mL?=
 =?us-ascii?Q?6T8cVNCC26RuNkn7Mbfpy0BrYzgl8tAdZUp8IIG26aYImj26iaRb6omhuYxn?=
 =?us-ascii?Q?f0g8nsBW7MZdB66E+HDyt5l/NzCodVQEczrGJbmwlPuCHVVq+ePnwRg//Qc5?=
 =?us-ascii?Q?YgXN+Ixodcj9pLWH0HZqySJDeMel2INj6NNUi0hRlgPNvVImPTmuCb9r5esW?=
 =?us-ascii?Q?2Wx2fY0aV5ZFFYoUrOsZjYybCGSCjjlMbZlWyZWxMlS1//ZRBujT9KsJLNzm?=
 =?us-ascii?Q?AUBEKV5A+5arn+aMaeEBI0yd+x83ZxsD0aBD68/+4JhJHQ1kNMW/DcOqengI?=
 =?us-ascii?Q?ZzFlFWe7Wu2nyEHaYI8MfN9+/nktEihstqJjbFtSNmIU810udGkUi7f46jXV?=
 =?us-ascii?Q?n2XO4loGYfzqv+lvfW8jsCo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3819.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4dec3c39-295c-40e3-b267-08da0316873b
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2022 04:20:51.8878
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o/xxP+03xh4LhcT9KZNwgstfIIJ/35Zlx1p8piuqZi0lsC+AUK1dgoNqLOL6gxQjjtZ/8pjmspSTKg/sDVPVqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1559
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH v2 2/2] drivers: fpga: dfl-pci: Add PCIE device IDs for I=
ntel DFL
> cards

Please remove "drivers"

>=20
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>=20
> Add the PCIE device IDs for Intel cards with Device Feature Lists
> (DFL) to the pci_dev_table for the dfl-pci driver.
>=20
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> ---
> v2: changed names from INTEL_OFS to INTEL_DFL
> ---
>  drivers/fpga/dfl-pci.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> index 717ac9715970..8faf284509e7 100644
> --- a/drivers/fpga/dfl-pci.c
> +++ b/drivers/fpga/dfl-pci.c
> @@ -77,12 +77,14 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
>  #define PCIE_DEVICE_ID_INTEL_PAC_D5005		0x0B2B
>  #define PCIE_DEVICE_ID_SILICOM_PAC_N5010	0x1000
>  #define PCIE_DEVICE_ID_SILICOM_PAC_N5011	0x1001
> +#define PCIE_DEVICE_ID_INTEL_DFL		0xbcce
>=20
>  /* VF Device */
>  #define PCIE_DEVICE_ID_VF_INT_5_X		0xBCBF
>  #define PCIE_DEVICE_ID_VF_INT_6_X		0xBCC1
>  #define PCIE_DEVICE_ID_VF_DSC_1_X		0x09C5
>  #define PCIE_DEVICE_ID_INTEL_PAC_D5005_VF	0x0B2C
> +#define PCIE_DEVICE_ID_INTEL_DFL_VF		0xbccf
>=20
>  static struct pci_device_id cci_pcie_id_tbl[] =3D {
>  	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_INT_5_X),},
> @@ -96,6 +98,8 @@ static struct pci_device_id cci_pcie_id_tbl[] =3D {
>  	{PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCIE_DEVICE_ID_INTEL_PAC_D5005_VF),},
>  	{PCI_DEVICE(PCI_VENDOR_ID_SILICOM_DENMARK,
> PCIE_DEVICE_ID_SILICOM_PAC_N5010),},
>  	{PCI_DEVICE(PCI_VENDOR_ID_SILICOM_DENMARK,
> PCIE_DEVICE_ID_SILICOM_PAC_N5011),},
> +	{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL),},
> +	{PCI_DEVICE(PCI_VENDOR_ID_INTEL,
> PCIE_DEVICE_ID_INTEL_DFL_VF),},
>  	{0,}

Actually we never know if future devices will pick this id or not, so
we don't have to enforce such a "generic" id and name here. Hm..
Maybe just OFS, I guess that if you have a newer generation card
than OFS, you may probably want to use a new ID for the same
reason that you don't pick the existing ones. : )

How do you think?

Thanks
Hao

>  };
>  MODULE_DEVICE_TABLE(pci, cci_pcie_id_tbl);
> --
> 2.25.1