Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 10 Mar 2022 17:09:19 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 10/24] EDAC/amd64: Define function to get Interleave
 Address Bit
Message-ID: <Yioir2htNGGz/QG7@zn.tnic>
References: <20220127204115.384161-1-yazen.ghannam@amd.com>
 <20220127204115.384161-11-yazen.ghannam@amd.com>
 <YgpGyceWKsIVYuGv@zn.tnic>
 <YikmMHYpdehehD9F@yaz-ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YikmMHYpdehehD9F@yaz-ubuntu>
Precedence: bulk

On Wed, Mar 09, 2022 at 10:12:00PM +0000, Yazen Ghannam wrote:
> Similar goal as in other places. When the function seems sufficiently long
> (subjective I know), break it up into helper functions.
> 
> I've been trying to decide based on logical steps. Do you have any general
> recommendations or rule-of-thumb?

Documentation/process/coding-style.rst, 6) Functions has some good ideas
about it. To me, a function should do one thing and one thing only but
yes, the decision is subjective.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette