Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <8fc192be-348d-0102-22ab-57b974e9d840@intel.com>
Date:   Thu, 10 Mar 2022 10:50:16 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH v2 2/2] intel_idle: Add a new flag to initialize the AMX
 state
Content-Language: en-CA
To:     "Rafael J. Wysocki" <rafael@kernel.org>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Borislav Petkov <bp@alien8.de>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
References: <20220309223431.26560-1-chang.seok.bae@intel.com>
 <20220309223431.26560-3-chang.seok.bae@intel.com>
 <CAJZ5v0g2ZU8PY8QkGD1Nb6VH37pm=ho8ZYa3h3UBRWDoH+xqnQ@mail.gmail.com>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <CAJZ5v0g2ZU8PY8QkGD1Nb6VH37pm=ho8ZYa3h3UBRWDoH+xqnQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWRLUzU5TmpPSnZ1TUpUNWx0c21PckVNYXBUbDZTZnBZa0NhMWgxOXcyajZr?=
 =?utf-8?B?eTZQaUxpby9Xa2hlYWlUZy9VYmxVbnRnTjlKOHZnd0s4QVF3eTZBUnNlTmZz?=
 =?utf-8?B?eWZlNHBMcFRoRGo3OEh2eUlaLzgzU2N3WjBWcXkzeVBxSkZUcnIwcVd4MC94?=
 =?utf-8?B?QzQ2WE1BczIvT1d5TFMzMCswSHhOaXhGVUR1K09tdTByeTVWZzd6d0w0TVh2?=
 =?utf-8?B?V1plVFUrZHYxK0VaMWlIb216NW9UaU1aM3d0Mm5hTDhTNlZELzR2eFF4V2lY?=
 =?utf-8?B?N1kyeExHcTRid2JaZENSZG1mdTN4dTdrN21lM0tPaUhiRHBlNHJyU0JiUHpO?=
 =?utf-8?B?Qk5HTzRMRC9WNzNHUnp1clplaGxBN0pLd29iWmRQMXd0aUJLNjR0ZndHbDE3?=
 =?utf-8?B?dmJORloraTN1TXR6eTczM2x3Wm1lZldTZ3hvMksyK2JlZHRsQ25RUmtFaUFS?=
 =?utf-8?B?eHA0NTZzTk1kdkhqUDErSzcxYnNTZzd6Skp3UmljSWNBeERJNWpXbC9uSTJ6?=
 =?utf-8?B?eGdmaythSlMxVkRyWnlnNkR5UHNCb3VmdFhOL1N2RUdRYU8vMFNwVm9hbTAw?=
 =?utf-8?B?T1VvOTlrZHZmM2gvQkZqZE1UK0grNi9kTkVLM0gvKzhYWkhxYmc0M0ZIVWpv?=
 =?utf-8?B?TFRGWnJFRCtyaTFhVHFmemtiVXByR3I5d1FhdU5SRGlrbXduTFJRQXovS3hp?=
 =?utf-8?B?T1VkMEtCbEhPY3RteXNlTFJ4b1VHMWZVdm9pRkNTK2NzaXhYRWtLYnRoTWw4?=
 =?utf-8?B?L2RiVVlYNTJqV2lpb2RIdHZJdVJCTXdqeGtYRmlkT0ZhR0Z0ang2VjRPNXVS?=
 =?utf-8?B?WGxHMzBMQ01jUTNYanVkTGp3d3JxUlpaZk9WeGdjS2tJaTFlT0QyR3UveWd5?=
 =?utf-8?B?R2tLUnpReDF2ZHpBL1h5am1iNnNtY1pVV2JPM3VSSW9LNU94WFNPQ0x5MHZ2?=
 =?utf-8?B?cmZMWUNxaEJRdVNueElZM0YvdFJCRTBYc001SUEybjN1V3JjeFFPUUFLL0xR?=
 =?utf-8?B?MFdXOVZOV3ZlWGtsSGJlR1N5WTMyKzFBdEx4T2toYWNSVWNMU1ZjTFRGRkFZ?=
 =?utf-8?B?REgrWHd2UUdHSWlMbFBiblc3ZGhCOEZ1SUt4c2s0MHZ4ZG9ISmVWZXJMUmJJ?=
 =?utf-8?B?YlFiZ0ZOVGdBdm5YdEd6K2NPVU93NW9oaThOWFJoRGtZUzkxbEk2YVF3WHVy?=
 =?utf-8?B?bUxpL3d0VTgrSXdRS1RFaUxQdTBvMy9SeHB3alp1ZytKMVUvRmpQM3huVXVp?=
 =?utf-8?B?cUljQ3ZWcEdNaWNZSmhidm1oQzgzUG1LTUdxVVZQQWZxRGdsYk13ZFIxTEJY?=
 =?utf-8?B?bU5QczlwMjBieHpMM2k3S1hzUFVNejBXNjVYVkZjSTZaZTNvY1BUaGtZWExp?=
 =?utf-8?B?WC8yZGNTYldrcVVET25YYnVZK1ViV0xCOW5VblJBWCs3REZSeWVDakxpS3RC?=
 =?utf-8?B?c2ttSXZ0RWs2ajNOTjhGNTFVTldDYlB5bHVROVY2OC9LQ0sxOEd5YjhsVUJJ?=
 =?utf-8?B?cEh0MUI2VlJybUlyeVBhTGdKcjVEcDlsMkdhUjVudnJTL2dqYXcwMURNSDVt?=
 =?utf-8?B?UFMySGRRWElCTTVTbWFoVkdsb2R2S1gzVS9aUWMvUE9wc3g0eWNHMXV4VFZU?=
 =?utf-8?B?aS9rSTI0M0RIWndZQWRrUHRScS9kVjlWZW05Mzc0Y3dqOVpVRFN6T1NNcHQ0?=
 =?utf-8?B?WDZ6SmJEK1FSS1ZvTzUwSVV6MXJIL1ZMK3NtWnc4REc3Tk5QQ1J3VzFWMlFj?=
 =?utf-8?B?TDd0NE4yR3FiTmp2aHpVV0RTUHFubDZIV3FzbVdzZFJEcy81Y0h3cFhJSm1h?=
 =?utf-8?B?enlBcFlNZzc1K1dSUUNQaTlvQWo5dDJDQWZzYktLVXp1eGRIVk9qN0JoMlNm?=
 =?utf-8?B?NDJZbmFEQUVTVEtpKzJUYnVaUTFoTmlvMEYxaytvWTloQXRmeWo5NkczaGg2?=
 =?utf-8?B?RXlLS3RUN1hPWUxFQ21IQnZJd05yMVMzcXR2MjB0cEhWTkhneHN1NkJJbU8x?=
 =?utf-8?B?NVpUYlYzM2NnPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f54b2d0a-fd0b-4283-9093-08da02c6d2b7
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 18:50:18.9621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: evP+1CSg2Y6Z2QybHB5xGt5Ol/SfyiuIVvO96V8uHMPNacw/xpiIzdl/8rlz0XsjACnxTRqsi5aCHQoP/goeWWfWzoNJiLNiweDtBAO0SAo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3404
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/10/2022 10:34 AM, Rafael J. Wysocki wrote:
> On Wed, Mar 9, 2022 at 11:42 PM Chang S. Bae <chang.seok.bae@intel.com> wrote:
>>
[...]
>> @@ -792,7 +805,8 @@ static struct cpuidle_state spr_cstates[] __initdata = {
>>          {
>>                  .name = "C6",
>>                  .desc = "MWAIT 0x20",
>> -               .flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED,
>> +               .flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED | \
> 
> Why is the backslash at the end of the line needed?

No, it is not needed.

Sorry, I think I was mindlessly following the style in this new c-state 
table:
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/tree/drivers/idle/intel_idle.c?h=linux-next#n787

Thanks,
Chang