Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <8b9e7ef4-10b9-1061-d12f-76fd62e1ae2d@redhat.com>
Date:   Fri, 11 Mar 2022 08:18:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] mm/hmm/test: simplify hmm test code: use miscdevice
 instead of char dev
Content-Language: en-US
To:     John Hubbard <jhubbard@nvidia.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Cc:     apopple@nvidia.com, rcampbell@nvidia.com, jgg@ziepe.ca,
        vbabka@suse.cz
References: <20220311033050.22724-1-mpenttil@redhat.com>
 <179e3540-b9bf-5fd2-cfa4-f7274b6c33d1@nvidia.com>
From:   =?UTF-8?Q?Mika_Penttil=c3=a4?= <mpenttil@redhat.com>
In-Reply-To: <179e3540-b9bf-5fd2-cfa4-f7274b6c33d1@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 11.3.2022 8.15, John Hubbard wrote:
> On 3/10/22 19:30, mpenttil@redhat.com wrote:
>> From: Mika Penttilä <mpenttil@redhat.com>
>>
>> HMM selftests use an in-kernel pseudo device to emulate device private
>> memory. The pseudo device registers a major device range for two pseudo
>> device instances. User space has a script that reads /proc/devices in
>> order to find the assigned major number, and sends that to mknod(1),
>> once for each node.
>>
>> This duplicates a fair amount of boilerplate that misc device can do
>> instead.
>>
>> Change this to use misc device, which makes the device node names appear
>> for us. This also enables udev-like processing if desired.
>>
>> Delete the /proc/devices parsing from the user-space test script, now
>> that it is unnecessary.
>>
>> v2:
>>          - Cleanups per review comments from John Hubbard
>>          - Added Tested-by and Ccs
> 
> The three lines above, starting with "v2:", belong after the "---". That
> way, they are not included in the commit log. That's the convention.
> 
> I think Andrew can fix it up for you, no need to spin a new patch for
> that.
> 
> Anyway, this looks good now, so please feel free to add:
> 
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>


Thanks John!

> 
> 
> thanks,