Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Hans Schultz <schultz.hans@gmail.com>
To:     Hans Schultz <schultz.hans@gmail.com>, davem@davemloft.net,
        kuba@kernel.org
Cc:     netdev@vger.kernel.org,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH iproute2-next V2 0/4] Add support for locked bridge
 ports (for 802.1X)
In-Reply-To: <20220228133650.31358-1-schultz.hans+netdev@gmail.com>
References: <20220228133650.31358-1-schultz.hans+netdev@gmail.com>
Date:   Fri, 11 Mar 2022 09:54:07 +0100
Message-ID: <86v8wkdg40.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On m=C3=A5n, feb 28, 2022 at 14:36, Hans Schultz <schultz.hans@gmail.com> w=
rote:
> This patch set is to complement the kernel locked port patches, such
> that iproute2 can be used to lock/unlock a port and check if a port
> is locked or not. To lock or unlock a port use the command:
>
> bridge link set dev DEV locked {on | off}
>
>
> To show the detailed setting of a port, including if the locked flag is
> enabled for the port(s), use the command:
>
> bridge -d link show [dev DEV]
>
>
> Hans Schultz (4):
>   bridge: link: add command to set port in locked mode
>   ip: iplink_bridge_slave: add locked port flag support
>   man8/bridge.8: add locked port feature description and cmd syntax
>   man8/ip-link.8: add locked port feature description and cmd syntax
>
>  bridge/link.c                | 13 +++++++++++++
>  include/uapi/linux/if_link.h |  1 +
>  ip/iplink_bridge_slave.c     |  9 +++++++++
>  man/man8/bridge.8            | 11 +++++++++++
>  man/man8/ip-link.8.in        |  6 ++++++
>  5 files changed, 40 insertions(+)
>
> --=20
> 2.30.2

Hi!

Would it be an idea to add a switch to iproute2 commands that would list
the supported features of the current version of the command (or all of
iproute2)  instead of having to deduce it indirectly?

F.ex. a feature I am adding will only work indirectly with iproute2, and
thus it will be difficult to determine if the feature is available or
not.

Hans