Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp754034pxp; Fri, 11 Mar 2022 14:14:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJyPNbRjTgMoGkhINm0LRuWxxb8CDDx70dY2KtgtaMMFTWpFaVc2koC0C2fN4kljqMbB8kRQ X-Received: by 2002:a62:7b55:0:b0:4f6:adc7:c306 with SMTP id w82-20020a627b55000000b004f6adc7c306mr12184001pfc.29.1647036855088; Fri, 11 Mar 2022 14:14:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647036855; cv=none; d=google.com; s=arc-20160816; b=ca99dAnko5PmXJoJv3G4CJtlZ53AIAfZgFQkrwq/qi9Y3ciHZ9R3LXBM9lmZjHgX3e zwGQL1jhXv/vg3iSNsxmQs4SsNXG+safc6fy7ooti3MPiX1wHRLX5A3rtz9DzXDtoxKU 1Ii0ch+EQbz9wMl9sCnvl9oHuepQzbccDWu+YnIZIHvWj2uWr0tYIUWK1rRDTYB0BLoF +9zERCc5JYxC2xL8tb0oulUfV/oHF5QtpXuisncR5+BARdS4uaMwDQ6uXCElcrVDD53O obSSicMpDKCnUXskOmfpKHPNbq0fGSag04+2Qnx5qI011sGaugiMV9YfIRi6nic13s3t 2EjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=FB6xomPY64jUpZu9dmUXFN9bddMNt8Vm5I5LWavAGS0=; b=H6u+GUGUHpPDgvKXoi2ArSZBIAC4I815gPBLflngOk+cpbnnSRAgFTj0tw2s+INvYu DjoAIdW/PLr49/zxoaMgtJISWXO7tJwprHDbfXKJ97LFonn++VfW6QG28h/NQSANN7wt vgNda5Abvd3nwVoJ0H8Z6FFgxrh/qQ1N0yjqvctqoDDErZ9YRVqRp7Um+NKHDMu/S5lk rgP3asOijKrHjU2sKv18Tbj8qMUjB2zKKfIuW1g9gWb7aJwkgeRutu9tY92yEwdT/F/H q+3iIaPZhsjI4BYv9SMFRMHO3CyF2fiQ9kQz7eGAVKKLl/rE9D+9RL5weXCRrPCIOFUu aXpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=TRzawf2m; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l184-20020a6388c1000000b0037c9021a3desi8433992pgd.211.2022.03.11.14.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 14:14:15 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=TRzawf2m; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 597F1219E8A; Fri, 11 Mar 2022 13:23:28 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343895AbiCJVJP (ORCPT + 99 others); Thu, 10 Mar 2022 16:09:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343879AbiCJVJK (ORCPT ); Thu, 10 Mar 2022 16:09:10 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 365BC4D270; Thu, 10 Mar 2022 13:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FB6xomPY64jUpZu9dmUXFN9bddMNt8Vm5I5LWavAGS0=; b=TRzawf2mWrbNgqP14p+c3NbZie SW9NQ/H5gn+77T5ym3xwXXMorG3xmCG05eMrb9MZMEhbaN9Bqcql4XYxHmXvIyLCyMOSznmAyQGqx pz1RdiKi4MAd8ZC8jFUqMu/4WnyiahzXqbIV4xQ/+iVCycogdSoOIih9tCmGtiKF1em2eq/E4UZrk Llx9OAFcdsva2m6GxTJbZAsmZtob0R5yCtA3o1sZUi0HnPpyTnnrTCdI7w+3XttxQAU0n6zTjAqJv luZxTGnYksr5TP9xL6qPFh1oKU/H8w6AW9vHXiwD3d/0asZ9a1BgxBZ6eEGxxs9JWWCXctpjGxbr6 KbdDXQgg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSQ0r-00E2ut-Cy; Thu, 10 Mar 2022 21:07:57 +0000 Date: Thu, 10 Mar 2022 13:07:57 -0800 From: Luis Chamberlain To: Daniel Thompson Cc: Aaron Tomlin , christophe.leroy@csgroup.eu, hch@infradead.org, cl@linux.com, mbenes@suse.cz, akpm@linux-foundation.org, jeyu@kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, void@manifault.com, atomlin@atomlin.com, allen.lkml@gmail.com, joe@perches.com, msuchanek@suse.de, oleksandr@natalenko.name, jason.wessel@windriver.com, pmladek@suse.com Subject: Re: [PATCH] kdb: Remove redundant module related references Message-ID: References: <20220307174741.2889588-1-atomlin@redhat.com> <20220308105203.2981099-1-atomlin@redhat.com> <20220309120640.uumh46n2l37jaddf@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309120640.uumh46n2l37jaddf@maple.lan> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 12:06:40PM +0000, Daniel Thompson wrote: > On Tue, Mar 08, 2022 at 10:52:03AM +0000, Aaron Tomlin wrote: > > Hi Luis, Christoph, Daniel, > > > > Is this patch ok or would you rather another iteration of the series? > > Either way is fine for me. Thanks. > > Another iteration makes more sense to me. Iteration yes, but separating the patches no into another series no. > The removal of kdb_modules is semantically part of your module clean > up patch set and should certainly be included in it. > > The removal of the spurious #include's in other kdb files is a > good change but it is fully independent of the module rework. AFAICT > those fixes are good with or without your changes. This suggests > these changes can be separate from the main patch set. Small fixes get piled in first on the series. But this is not a fix. This effort will not be merged separately too. This won't go into the next merge window either, because: 1) There is no rush 2) It is too late as all this needs proper testing and its too late to claim enough testing So given this is all related to the move I see no reason to treat this as a separate series. Your review of the v11 would be nice. Luis