Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp754474pxp; Fri, 11 Mar 2022 14:14:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvDnJzxdlNDJUVEiwsjyVqaaF/YeMhi0m+Nq62FtoqsE5wR77kfZq7P6LCAMtOt2pP9yZr X-Received: by 2002:a17:902:7781:b0:153:35ef:e3d1 with SMTP id o1-20020a170902778100b0015335efe3d1mr5304132pll.116.1647036894831; Fri, 11 Mar 2022 14:14:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647036894; cv=none; d=google.com; s=arc-20160816; b=Q+U1hbf5DkymcTbZotfW2NVPDj31Z4SvRFRfphKRiHeW8dNeDw8Sq2ile5ECmyjQSn 5W8EVeHrx4qtnXKIbA8J8i5yESrQgGnEEfqOsIAakMYgSwSlJhj/bHtCtQGiy9d3Jc/R 3oKUm3clrxe0y1d39V9KKCF6ZquMu1a02BtVKiyIM3oSRS3T9HCqGTdLZjTlX5WN6KNC PHoAOHLgWwHGlTHK9fRgeCIKhzNjcimH70lZl6EjX5ulydlgTkDitNSW6Je5dPAgZ3kL P4pbJZO2VhL5BVw7ShwBGGlwCKizBloTs6oL7uo4Je9LtRAYhxubI6I9pk1NP5VWSxFD 5ssQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8i9PcoBgS4Z5fTHkHhwCw2b7OCjvoaGKsCGSTw+C1tM=; b=fpYqUCAxb92MBvbCY2N2+r7sMtOOj1D1NO9KM+BMyrEIbSRRhsemI3JvoyKG79dPfJ 1ZQhSvNws5L9Hocf3DJIayHSoScD6MUuqGS5ggtwuWn0X7UCbz14MvKUVaJY/3UOs6rQ nFWIj1TeT1SLbOudT47hjf1wSyEBScENtPOM9veuRJvfACAy+/o7GATe/TNFoBsTvUO5 bLnpMXtDCifKLkUaRJUC+tOl0UCyIcv6tZWU/DeqFd5SwRjZRyYGcP/ILbWQGojKY1xi jZ0/e1wB4kY6Fo7gzofcYq508K77qfedNOwsv7XoNeBDGCS3Wvcl1p6JJiWla4VHlm5B SJcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=FHz7R3Sc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id z190-20020a627ec7000000b004e16e279ec2si8324649pfc.328.2022.03.11.14.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 14:14:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=FHz7R3Sc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 97D78221BA2; Fri, 11 Mar 2022 13:24:10 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245363AbiCJSSK (ORCPT + 99 others); Thu, 10 Mar 2022 13:18:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234784AbiCJSSJ (ORCPT ); Thu, 10 Mar 2022 13:18:09 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83B3113D900 for ; Thu, 10 Mar 2022 10:17:08 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id fs4-20020a17090af28400b001bf5624c0aaso6021176pjb.0 for ; Thu, 10 Mar 2022 10:17:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8i9PcoBgS4Z5fTHkHhwCw2b7OCjvoaGKsCGSTw+C1tM=; b=FHz7R3ScT4P/6jx0UHpLjssNo+wzcUAnkAq0eNZlWWEK3aYGOxTGOxoQ/SFYQ4gitQ IzTn31mtdV3LRCsbXyZSNMjDZxDVwh14jEA1Mz6aZXSZSmLrPmfX8dxOIT0DkyfXgObJ sadA5/c2IF8P5u2OaXSS9m3nK92vT8MhshqvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8i9PcoBgS4Z5fTHkHhwCw2b7OCjvoaGKsCGSTw+C1tM=; b=G9yBgob8JeA9LZYZ1iidbcVKHynUkIjoTAdalRCTufioiUUlqeGEIO3yV0+YyYYCho PrwcrqwmgCx9/z4lBNvbtL2JUOvSwkpDaUpdimkHPFY4vfJlZFPJUUDRi46QwMbBpVRB RAihBxk9LUNRjKEATPF+bpVfzVqc3yMUdaSjViufAOPxlRCvmGiX/+FAWgg6Epg4OW7v k9Cvt3euicZQ2ddPx6wrek8nxDZeMX8wb7KDqcP0muAnOdH/NIY6w3uywhSlMBIQFl71 xBndgA98UTGvOokZHu61S/6VrZkKyIeEfjM+rcb+OGHnxV6uBkhZ5FOH527hZinJHFQP 9tcg== X-Gm-Message-State: AOAM53129j9SdYMt9ih8mRDa7jlxYn7ajRe35hjpSi97KekngGEXyvdB TLwSHskvxlcAh11DO8ElWjvqug== X-Received: by 2002:a17:902:9a4b:b0:14f:fe0b:5546 with SMTP id x11-20020a1709029a4b00b0014ffe0b5546mr6364220plv.46.1646936227861; Thu, 10 Mar 2022 10:17:07 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w5-20020a17090a4f4500b001bf3bdf39a8sm6785842pjl.4.2022.03.10.10.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 10:17:07 -0800 (PST) From: Kees Cook To: luc.vanoostenryck@gmail.com, nathan@kernel.org, shuah@kernel.org, mark.rutland@arm.com, akpm@linux-foundation.org, tglx@linutronix.de, ndesaulniers@google.com, linux@roeck-us.net, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will@kernel.org, npiggin@gmail.com, arnd@arndb.de, masahiroy@kernel.org, ojeda@kernel.org, Dan Li , elver@google.com, samitolvanen@google.com Cc: Kees Cook , linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: (subset) [PATCH v3 1/2] AARCH64: Add gcc Shadow Call Stack support Date: Thu, 10 Mar 2022 10:15:37 -0800 Message-Id: <164693613561.1275052.17242543278628621803.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220303074323.86282-1-ashimida@linux.alibaba.com> References: <20220303073340.86008-1-ashimida@linux.alibaba.com> <20220303074323.86282-1-ashimida@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Mar 2022 23:43:23 -0800, Dan Li wrote: > Shadow call stacks will be available in GCC >= 12, this patch makes > the corresponding kernel configuration available when compiling > the kernel with the gcc. > > Note that the implementation in GCC is slightly different from Clang. > With SCS enabled, functions will only pop x30 once in the epilogue, > like: > > [...] I'm taking this one now so it'll make the merge window. We can hammer out the lkdtm test after that. Applied to for-next/hardening, thanks! [1/2] arm64: Add gcc Shadow Call Stack support https://git.kernel.org/kees/c/afcf5441b9ff -- Kees Cook