Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Xin Ji <xji@analogixsemi.com>
To:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Robert Foss <robert.foss@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Xin Ji <xji@analogixsemi.com>
Cc:     bliang@analogixsemi.com, qwen@analogixsemi.com,
        hsinyi@chromium.org, mliu@analogixsemi.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] drm/bridge: anx7625: Fix not correct get property counts
Date:   Fri, 11 Mar 2022 18:35:25 +0800
Message-Id: <20220311103525.1431890-1-xji@analogixsemi.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5LXWKM+pbpOzKdTiTRqGOC4WEQ6gRiKTwb/+FTT9sy0mpJqVGZ020VOu6szB?=
 =?us-ascii?Q?pNTdgJhSKfg54tAFy0diwlN1QCxArRDAVVNnC9G0u80RoXBZwxDZNLhLph7M?=
 =?us-ascii?Q?V0xeEn1Ilabvbi5y3YdJhpfCWvuprCchsa4LSz3zngZ9tgV9Qa604ab9iX5K?=
 =?us-ascii?Q?T89sjdRBGJ/XlkTNW7irHw0BGS8eCbNxZm5/VaOgKtE5wUIK83yNtroPwGsi?=
 =?us-ascii?Q?Lx3f3dwwZmfj8jKwIn1ecrX5i2sgwFhIjK/RYFu+9ZAF++yuz6L8n161YKjr?=
 =?us-ascii?Q?QqFZEKFInJXjqCkS+CDl96dTQ1ewbqkjchCE7kNIMfLTDT9Ds+9PNbAZSHHr?=
 =?us-ascii?Q?h2SUv5EvgjMNKlXhhXdJP1qvdh24/5hoXfOAH8FhCWfgOSwPw4MozUp9eWzg?=
 =?us-ascii?Q?2GPZbKlUnYv2SkxUQLXImp6hGKgIlaNWgTLnxWw67xFWIAm1lEYPgKDhUsVN?=
 =?us-ascii?Q?PlyAaGVLsvLk2g4Bfl95QVvDb40MLFc7jS0JCsqiMBwrTvD496HowwnyCuT7?=
 =?us-ascii?Q?CjNje0kaLh3rcQTxWJhT8woA241oeVvfJr1X9dPQI8IBUllyIvR3aozbjLP5?=
 =?us-ascii?Q?cBn5+SNB8CFmAGaiq1rxUXD71SLQXE0wyw8pxv4dNqOEywfkCNkcNMdLZbxY?=
 =?us-ascii?Q?6M0r5qapLHyKfnbivdFOQJ+/xDTrEtW02tRed9sYyH8aeHV+dV1x4+T17RRl?=
 =?us-ascii?Q?2PiOhbrSk+/UaNjCGn6PYszbIP3IXZymWKuQDeShV3ufRbpexDUyFM0xfk9C?=
 =?us-ascii?Q?e1WKcgUTtMy9jM8YimUxKQAOf6PM1mBKbxIGFpBm1q4TjaJlglqoSX0xfnoi?=
 =?us-ascii?Q?xPp5JqIzHxIYnvpCQPqqIEcHSTR3wH1twtgjgZNQsGJZbt5ULuZigHKMLdHE?=
 =?us-ascii?Q?bgWRwG3SJB+R6FL6Y0ec48yO+WbGfmp26IFvf0U6hlq+7Wdlq77Typ/aEe7L?=
 =?us-ascii?Q?G0sJV88bfqPJ7x0vDMp8i7vTuS7fDNha4abaZ+5PZGGezWv7d2R6BSbRnyr5?=
 =?us-ascii?Q?OyetJoKTueC6WnOB4v8OgHYbR1NvkegxyXxtrRDPKkVNu+1r9dia2pm9msbg?=
 =?us-ascii?Q?qIEJo5r/Y8qxGt7NC67hYUk4FhL8JVkAgelZQ1WXTxlrnYHm98YtSjjVIXTU?=
 =?us-ascii?Q?sNfLZJkZRo98ItCyNNmkgL46wm3WW5RufMcmur7Ek/gaUlDpDJ+zaRhqjQXJ?=
 =?us-ascii?Q?q3aQyf89rDau3Xmd8oSjaGrMagnNSn1OmJNz1gN9OmYQczUMhXwdfIF/qtnh?=
 =?us-ascii?Q?g8+Sea32IEr7uqPaZ+6oq54xmvdfKgPAXpVHnq+M4J+uPv5TX3FXUCHHRfqq?=
 =?us-ascii?Q?94S3ZFVYKJj7GpNgiF3+kLFknpk/+JDIeGOg0kZ0ZwVeAvFfeL0QJQs1tGhd?=
 =?us-ascii?Q?QK0jd2rqou6Ek1hsHPAoQ4nKEW++QLnF9+g/WUFgjr7GgO5t8xM13iv7Y3u3?=
 =?us-ascii?Q?UlzCz5Ud40/cn+BMVhd6eKgTW2jQGMC/yweARcJztlq+LpE/B54rxOg/1Tdd?=
 =?us-ascii?Q?r+LvuydRk4ciIJfo86U6mylvwPoPfKhQJ4fM+yuOWzwh82IKHTD+XT4Suoyr?=
 =?us-ascii?Q?qBoD53euLi3cM6IetCMb6A/jj6pA8tXMd5K9zKEgh9zvt0drusHgv9xhy+wk?=
 =?us-ascii?Q?+QtmOPGgf8gexk8Nt7lpNVU=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40e6b493-3d9c-4a56-4524-08da034aeea1
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 10:35:59.5011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lr/RdxyzyKMIe16/BN8NakpfLPa2RlzztRV7HjsDwYPOaGuFWs+unpdT45TGqDW/z/GJ+XDxl6gTjxPxTutydg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7021
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The property length which returns from "of_get_property", it means array
bytes count if the property has prefix as "/bits/ 8". The driver should
call function "of_property_read_u8_array" to get correct array value.

Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
Signed-off-by: Xin Ji <xji@analogixsemi.com>

---
V1 -> V2: Fix Sam comment, use of_property_read_u8_array to get array
value
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++----
 drivers/gpu/drm/bridge/analogix/anx7625.h | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index c6a9a02ed762..628cbf769141 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -1598,8 +1598,8 @@ static int anx7625_get_swing_setting(struct device *dev,
 			num_regs = DP_TX_SWING_REG_CNT;
 
 		pdata->dp_lane0_swing_reg_cnt = num_regs;
-		of_property_read_u32_array(dev->of_node, "analogix,lane0-swing",
-					   pdata->lane0_reg_data, num_regs);
+		of_property_read_u8_array(dev->of_node, "analogix,lane0-swing",
+					  pdata->lane0_reg_data, num_regs);
 	}
 
 	if (of_get_property(dev->of_node,
@@ -1608,8 +1608,8 @@ static int anx7625_get_swing_setting(struct device *dev,
 			num_regs = DP_TX_SWING_REG_CNT;
 
 		pdata->dp_lane1_swing_reg_cnt = num_regs;
-		of_property_read_u32_array(dev->of_node, "analogix,lane1-swing",
-					   pdata->lane1_reg_data, num_regs);
+		of_property_read_u8_array(dev->of_node, "analogix,lane1-swing",
+					  pdata->lane1_reg_data, num_regs);
 	}
 
 	return 0;
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.h b/drivers/gpu/drm/bridge/analogix/anx7625.h
index edbbfe410a56..2c340f16f2c3 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.h
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.h
@@ -426,9 +426,9 @@ struct anx7625_platform_data {
 	int mipi_lanes;
 	int audio_en;
 	int dp_lane0_swing_reg_cnt;
-	int lane0_reg_data[DP_TX_SWING_REG_CNT];
 	int dp_lane1_swing_reg_cnt;
-	int lane1_reg_data[DP_TX_SWING_REG_CNT];
+	u8 lane0_reg_data[DP_TX_SWING_REG_CNT];
+	u8 lane1_reg_data[DP_TX_SWING_REG_CNT];
 	u32 low_power_mode;
 	struct device_node *mipi_host_node;
 };
-- 
2.25.1