Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp768228pxp; Fri, 11 Mar 2022 14:36:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJxvqG3wOMZSJdGRaqKFEpuhyKcxLXBW3Vh8hF10unjvnBiLvWhhGD/BB8Bqdc8Ur4nHTYPv X-Received: by 2002:aa7:8316:0:b0:4f7:915:3ecb with SMTP id bk22-20020aa78316000000b004f709153ecbmr12163393pfb.15.1647038209657; Fri, 11 Mar 2022 14:36:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647038209; cv=none; d=google.com; s=arc-20160816; b=0CUepK4RD2Dh5HRFtaDAlaoC24TwL4eGegzG6wpufIX1yoqhDO7Pwiudozo3kb+zo8 8kNS1NuSy3WrDOTvHRKuDBbJlXZZijPrWhhZNqaFo2SWoX+ajsnFT22g6Pr2aA+qaSs5 bsKjWGgcZFcunVtpJ2XdDaj1klCYXsRRQXWcerS8xWyVg8zcuIkJJptXcm27m+M1SmVc ERMXhfiWPOX941RZPkbEJnrADXa4JWKCkS4K/6lmC3YTrD/qhsEI3+FA42GTPexuKIZW P98k3vQjZU8h+7jd1cOLYo9Jx9WQcYmDhOK7YAQc1c/iNhIOVwoabThLuSeuj/C9NAgV go8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Bd9zHMo9zm+iZxOyIilS0I6e6pMj3bxl5ZDk+SOXKgg=; b=RSkBEAZ9vYGvLybay+KfS4GdPJx9ItsdUf3n+dij/0ewAgLA9OPCyJzUkNiAp3Sh7n sTwjyUrhrDDMqVaZAEmCxqwAdvU4TMhllgNpRzf71OqJgODJNOe4lOVT+wrIrQsK3YgD wsPkUBQZ1nMPHWDN136wEleGQj3K3vxG5xaBYvQ/fdP2X4jNLxXiHQ9gQpYgF5ntEQEX FXpHs+bPYcAPCetVaIHxQdKxRUP5x2KdW/a3Y53lQUgJs7muW1lTkbcB1s/LNdzRO5h3 T37ycipa/2g6J8KLN+5MEUOK8ivjTyriHMLvue43ktEaltUbgf+UUky6VRmSItFqFgxs 9oaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id a11-20020a056a000c8b00b004f7a02d2707si1044929pfv.349.2022.03.11.14.36.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 14:36:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 66EA6326470; Fri, 11 Mar 2022 13:42:18 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344832AbiCKATF (ORCPT + 99 others); Thu, 10 Mar 2022 19:19:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236938AbiCKATD (ORCPT ); Thu, 10 Mar 2022 19:19:03 -0500 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F7DB9F6E2; Thu, 10 Mar 2022 16:18:00 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0V6qSMeb_1646957877; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V6qSMeb_1646957877) by smtp.aliyun-inc.com(127.0.0.1); Fri, 11 Mar 2022 08:17:58 +0800 From: Yang Li To: davem@davemloft.net Cc: kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] ethernet: 8390: Remove unnecessary print function dev_err() Date: Fri, 11 Mar 2022 08:17:56 +0800 Message-Id: <20220311001756.12234-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/net/ethernet/8390/mcf8390.c:414:2-9: line 414 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/net/ethernet/8390/mcf8390.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/8390/mcf8390.c b/drivers/net/ethernet/8390/mcf8390.c index 90cd7bdf06f5..21047ae1bc3d 100644 --- a/drivers/net/ethernet/8390/mcf8390.c +++ b/drivers/net/ethernet/8390/mcf8390.c @@ -410,10 +410,8 @@ static int mcf8390_probe(struct platform_device *pdev) int ret, irq; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "no IRQ specified?\n"); + if (irq < 0) return -ENXIO; - } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (mem == NULL) { -- 2.20.1.7.g153144c