Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp771006pxp; Fri, 11 Mar 2022 14:41:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJzhssBZJDmWiMNt6KIWKfGCYd2mhbNajd5Czap0RqyBQBMx42beeS187Yx9dVrHgTcxfcxx X-Received: by 2002:a17:903:110d:b0:14f:72a1:7b18 with SMTP id n13-20020a170903110d00b0014f72a17b18mr12445025plh.111.1647038494929; Fri, 11 Mar 2022 14:41:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647038494; cv=none; d=google.com; s=arc-20160816; b=A6K4IPEInQ9EZ4rV+zn6UqjatD6plN730cHcZY+skldkvunu0xtHWa7qrckcb0eQVJ qnJjRt7rrbuMWL1OTq9f/Jr/1kMy0VHKEoM1DmtR+2Wiy83uqSwjdVys3A0OMbMPzXAU manRiql4PnAKYV3uFiZPCEmN1Wgu9lbuhw8XgBhMKzvu3em/ZQRbs6YGS05rb9+MKhx8 CAHosAkJCTh32a/XmawWXA8p6wXk3nj7iv7y9SDvoMMwsICsBXNb7lbTb7lcKaaanDth rXdh69tXd5s9cirFbQVgExpAmGlSKNU7ozlLDQkUwLkFlp30c+unY9s7GT2KzkMkMP1y pbqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=9Fsxced+cP/JAU6qIJzXyFDQ+HLcljGI9FeqA2TwMJo=; b=dOlMUN0RU7oEB36J6QWenWYTiVqQXEvifW51zQYpCvB/w4NyVBFwCsf1KUG79VZyxo R9A4VvjJkuD+d/mKsy3JXtjW5qhk0k585WBqNVo/v8DCj2v1f6n5LJ9iUhbfPzJL2S8F /AmzyzwWznbt5VA8JAuuxA7dIK1czFvUjam9XSzjCp7Bs25k7Ute/kEIJU5FMZdJGwOs Aoh1P6eyCrOhNnbf3GYRBcjZgmW+x2GZnmKPfhdIeW+sTNsi3txyBgCG54BF6Tu2BIBm YZqOA7TXksAupmO9Y5ksA/XIVsqOhVhrs1EQCW+G85XZYkOARwJ1GN9keFmc7oM8bhmS 2h2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=KIDm4YiG; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j191-20020a6380c8000000b003810c492c47si2931909pgd.459.2022.03.11.14.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 14:41:34 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=KIDm4YiG; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 335F336691; Fri, 11 Mar 2022 13:44:59 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350562AbiCKSBU (ORCPT + 99 others); Fri, 11 Mar 2022 13:01:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344592AbiCKSBR (ORCPT ); Fri, 11 Mar 2022 13:01:17 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F351D3068; Fri, 11 Mar 2022 10:00:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9Fsxced+cP/JAU6qIJzXyFDQ+HLcljGI9FeqA2TwMJo=; b=KIDm4YiGuH+nwsiNGJW1PBi3GW 7nzmByTGtnRb9hV3Fwwu30Ih39CCBejNxk+AezmWDSt0QlL+Y8SuLt48mjpA75/B/GQiF0YeHedJa fUxDGUv3V72Wl6hb5hjku6ieBi2KPta1cHgg9UxgBTnCI0+TdT4WA8E5v16pLOrr9Gegb9TIPpDlQ xIgY5hMrl653Vez8uUhG+kfes/oHxFrSkNDLgd2eTxiaQuWMKy9D1DSQXbnmR5QWZbbvo7P0Q4YeY hU52+7VnJKmUwG6Hz5lMxGHotXoiM/p9AIeVphA7GXyH9tjxHyBMMZS0DINuQJE22BYLiAmJXHC3B fopZVllA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nSjYb-00HZXL-Na; Fri, 11 Mar 2022 18:00:05 +0000 Date: Fri, 11 Mar 2022 10:00:05 -0800 From: Luis Chamberlain To: Daniel Thompson Cc: Aaron Tomlin , christophe.leroy@csgroup.eu, cl@linux.com, mbenes@suse.cz, akpm@linux-foundation.org, jeyu@kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, void@manifault.com, atomlin@atomlin.com, allen.lkml@gmail.com, joe@perches.com, msuchanek@suse.de, oleksandr@natalenko.name, jason.wessel@windriver.com, pmladek@suse.com, hch@infradead.org Subject: Re: [PATCH v11 13/14] module: Move kdb module related code out of main kdb code Message-ID: References: <20220310102413.3438665-1-atomlin@redhat.com> <20220310102625.3441888-1-atomlin@redhat.com> <20220310102625.3441888-2-atomlin@redhat.com> <20220311161736.2i53cjovg3plbiqu@maple.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220311161736.2i53cjovg3plbiqu@maple.lan> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 11, 2022 at 04:17:36PM +0000, Daniel Thompson wrote: > On Thu, Mar 10, 2022 at 10:26:24AM +0000, Aaron Tomlin wrote: > > No functional change. > > > > This patch migrates the kdb 'lsmod' command support out of main > > kdb code into its own file under kernel/module. In addition to > > the above, a minor style warning i.e. missing a blank line after > > declarations, was resolved too. The new file was added to > > MAINTAINERS. Finally we remove linux/module.h as it is entirely > > redundant. > > > > Signed-off-by: Aaron Tomlin > > Reviewed-by: Daniel Thompson > > Likewise w.r.t. to landing this via the modules tree, that's fine: > Acked-by: Daniel Thompson Groovy thanks, this won't go in for the upcoming merge window, it will wait until the next kernel release as we have tons of testing to do still. Thanks! Luis