Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp772923pxp; Fri, 11 Mar 2022 14:45:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJxftx3Lq8ddhvPJiDk81CD3H41LtQrh7Tz/w7ZCL/wxGZjetL+rlhqXplVnkQEBnRrKnbYZ X-Received: by 2002:a17:902:8341:b0:151:8349:5cd with SMTP id z1-20020a170902834100b00151834905cdmr12475734pln.170.1647038727631; Fri, 11 Mar 2022 14:45:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647038727; cv=none; d=google.com; s=arc-20160816; b=qfpEwjAlTos2wjvnJj/g/hvlvWqTJp5TODwzX5ORGbSVq01Rw/LFHp/fI0SzAXKFSu GKzeHpvmNyV0pcJ8uD47fgBsqG2sEwYjG3Qq5D+Mq01XYidURcGDJUO0rt1Yfpk+vzOP apGw+CQdh45LsHX0t/R05+SblQyHE8SPgi0IRhy/IbPEEmi1RbwYoZgR4AR5vM1hgO0s 7VStvI1Reen4yTjIn4rk3WvrpHnT5bqhsguo9//pM/c1lNBAejDIuqECHuTx5nxf2DoM QU2UBPipCWxVYfXFDfYAeZ3u3UsX9b7TbjgkcegcOj+mLEU5yD3rTC1pjV8SpQYaARor joyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1+6eqdKYc4rP0HEIT0sdcy/dhFKXMZL+CYgIjkgrS64=; b=Iaa7KE6KE4/EL48taq5DZOgzdp7QB4Q1iV+Ek4TNuwEvvN32ScF+chO//SFO/Odsbe Ipsm5LnGqhFQ3fyZ//lTwWc7o3L1GLy5ylQT6+nef53VWlU+MkZum/w8YVnq1pSd7v+x hN4X37QbWclwaEhIXAWBJ1G/sfYNJ65H7tWm/tezPp3pXhUL8y5Z8FPgHnLGrEFRK/JN Z0HDvvi0i2Lg+VOjUTUW7IAdV+XZrL1tCrfKETJjn/13a7sLPZtDAK0BXsvrIn4UEmsk 7P0aJY+zxG6FRu6aQLiiw8uUXEki9ouBaVPqEoRI85I9D0fgv/i1oBGUrcmodxRoJesm uyTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ETab7GX5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id n5-20020a6546c5000000b00374956cb045si9163421pgr.784.2022.03.11.14.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 14:45:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ETab7GX5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9C1E937C3BA; Fri, 11 Mar 2022 13:58:20 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344463AbiCJOkz (ORCPT + 99 others); Thu, 10 Mar 2022 09:40:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244172AbiCJO2e (ORCPT ); Thu, 10 Mar 2022 09:28:34 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AC34C2E78; Thu, 10 Mar 2022 06:23:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D28ADB82678; Thu, 10 Mar 2022 14:23:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2801CC340E8; Thu, 10 Mar 2022 14:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646922201; bh=O/puTpS0vTBgPhZGErm9BWdP2JhT+u4Mnv+wuMe7TjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ETab7GX5Gyj3ySFWakyMkyDiz2rFdQtoX+cs/s5sJeCOLwztIwxR0N81uP1dAn2qO To0BBFb1gJaOosumL1tSEsZJJi5XXbMVRUCqPuh7WJZR0EkHcahqRG8oUzWLYUdIGe 1F3EMBLYcYgqHxn/44H+qEsGL9DWQoe3NKlNrWLY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steven Price , Will Deacon , Marc Zyngier Subject: [PATCH 4.19 11/33] arm/arm64: Provide a wrapper for SMCCC 1.1 calls Date: Thu, 10 Mar 2022 15:18:38 +0100 Message-Id: <20220310140808.079209100@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220310140807.749164737@linuxfoundation.org> References: <20220310140807.749164737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steven Price commit 541625ac47ce9d0835efaee0fcbaa251b0000a37 upstream. SMCCC 1.1 calls may use either HVC or SMC depending on the PSCI conduit. Rather than coding this in every call site, provide a macro which uses the correct instruction. The macro also handles the case where no conduit is configured/available returning a not supported error in res, along with returning the conduit used for the call. This allow us to remove some duplicated code and will be useful later when adding paravirtualized time hypervisor calls. Signed-off-by: Steven Price Acked-by: Will Deacon Signed-off-by: Marc Zyngier Signed-off-by: Greg Kroah-Hartman --- include/linux/arm-smccc.h | 58 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) --- a/include/linux/arm-smccc.h +++ b/include/linux/arm-smccc.h @@ -311,5 +311,63 @@ asmlinkage void __arm_smccc_hvc(unsigned #define SMCCC_RET_NOT_SUPPORTED -1 #define SMCCC_RET_NOT_REQUIRED -2 +/* + * Like arm_smccc_1_1* but always returns SMCCC_RET_NOT_SUPPORTED. + * Used when the SMCCC conduit is not defined. The empty asm statement + * avoids compiler warnings about unused variables. + */ +#define __fail_smccc_1_1(...) \ + do { \ + __declare_args(__count_args(__VA_ARGS__), __VA_ARGS__); \ + asm ("" __constraints(__count_args(__VA_ARGS__))); \ + if (___res) \ + ___res->a0 = SMCCC_RET_NOT_SUPPORTED; \ + } while (0) + +/* + * arm_smccc_1_1_invoke() - make an SMCCC v1.1 compliant call + * + * This is a variadic macro taking one to eight source arguments, and + * an optional return structure. + * + * @a0-a7: arguments passed in registers 0 to 7 + * @res: result values from registers 0 to 3 + * + * This macro will make either an HVC call or an SMC call depending on the + * current SMCCC conduit. If no valid conduit is available then -1 + * (SMCCC_RET_NOT_SUPPORTED) is returned in @res.a0 (if supplied). + * + * The return value also provides the conduit that was used. + */ +#define arm_smccc_1_1_invoke(...) ({ \ + int method = arm_smccc_1_1_get_conduit(); \ + switch (method) { \ + case SMCCC_CONDUIT_HVC: \ + arm_smccc_1_1_hvc(__VA_ARGS__); \ + break; \ + case SMCCC_CONDUIT_SMC: \ + arm_smccc_1_1_smc(__VA_ARGS__); \ + break; \ + default: \ + __fail_smccc_1_1(__VA_ARGS__); \ + method = SMCCC_CONDUIT_NONE; \ + break; \ + } \ + method; \ + }) + +/* Paravirtualised time calls (defined by ARM DEN0057A) */ +#define ARM_SMCCC_HV_PV_TIME_FEATURES \ + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \ + ARM_SMCCC_SMC_64, \ + ARM_SMCCC_OWNER_STANDARD_HYP, \ + 0x20) + +#define ARM_SMCCC_HV_PV_TIME_ST \ + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \ + ARM_SMCCC_SMC_64, \ + ARM_SMCCC_OWNER_STANDARD_HYP, \ + 0x21) + #endif /*__ASSEMBLY__*/ #endif /*__LINUX_ARM_SMCCC_H*/