Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp784981pxp; Fri, 11 Mar 2022 15:04:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJzyFF4vSiCaG7Vh5uyd90rV7gTf3JBeX0QB3+RQYqSH7+5YbaqYrc3Jz4GfuQUnkC6bbazI X-Received: by 2002:a17:902:ccc1:b0:151:fbe6:4982 with SMTP id z1-20020a170902ccc100b00151fbe64982mr12716363ple.124.1647039898734; Fri, 11 Mar 2022 15:04:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647039898; cv=none; d=google.com; s=arc-20160816; b=RZF/uf7zXutpCb140OhJXZdsT3074tkA1lz9igAAEtEWneqMdK49mvP7hWYmb8XZsw NfCLgv9Ct3pd2ODhxa+rOURj1dMRZijjefYZkRkPGb/+oPWe98hySNY0BqlxGBeMan+z dwSONdBzVqIWzlqlW6dpMra2slHI8UQB5jgP9Nx+PHGN3Ut0YPVVrk1KsY3tXO7M6SvL Vcc68/Hb7z8/MxGffcvBRKZlo9nBxcvQS1W5IYa90q8jM7sPZEO8YVM1/0+XrHUgEU1R 2CFm+Fg4G7nOBV0A1OWFBZaCoApJId8aLCJZBOQj6Fld//ShOsZ23gMwhOHoTljFX9ma ZywQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=xzv8jPX4OtiXIZf71LRie+tYM2crenu97GwpJpoMgFo=; b=iovFZqELIaVb9Ls8nTVm/xwtn3nspvt8heE58J2CxY1HjuQH/tPt4hykcb9vkYredx /giDOBzA3mMhB591ZKne0uXasn4LBN1GlVwfVj2Vg1ZFYlracwZec/mmQUkb8NlRrz0h LrJqDtlkU6i/KA017ofkX5pNGdJTxWFIv9q/N0NgzBM7jEfAGMeJo/c5J9EUBcSGUt69 74xCw+SuFvw40NwCN/5NMLlzBr5tgUIf9yE5F9g6QT4+PgWNRQnEoR+xh/zpDHz4XMrF kjYvpiPxt7NgtD+j1+LfJfwqvIfa3uOf9iA/3W6c000V9iIXEDkRd4SrFkw2yzTNRZ4O SBlw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j18-20020a63fc12000000b00373e12c3979si9084252pgi.461.2022.03.11.15.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 15:04:58 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2753738A800; Fri, 11 Mar 2022 14:01:27 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345404AbiCKPlI (ORCPT + 99 others); Fri, 11 Mar 2022 10:41:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240607AbiCKPlH (ORCPT ); Fri, 11 Mar 2022 10:41:07 -0500 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF57D1C1EE2; Fri, 11 Mar 2022 07:40:02 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 661BB1BF20B; Fri, 11 Mar 2022 15:39:53 +0000 (UTC) Date: Fri, 11 Mar 2022 16:39:51 +0100 From: Jacopo Mondi To: Mauro Carvalho Chehab Cc: Niklas =?utf-8?Q?S=C3=B6derlund?= , Cai Huoqing , Dillon Min , Dmitry Osipenko , Eugen Hristev , Fabio Estevam , Hans Verkuil , Julia Lawall , Laurent Pinchart , Ming Qian , Mirela Rabulea , NXP Linux Team , Pengutronix Kernel Team , Philipp Zabel , Sakari Ailus , Sascha Hauer , Shawn Guo , Yang Yingliang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2 07/38] media: platform: place NXP drivers on a separate dir Message-ID: <20220311153951.t5shye6hjtvoxfzt@uno.localdomain> References: <723fbc3e03d8817916a085e218befd6400d299a3.1647006877.git.mchehab@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <723fbc3e03d8817916a085e218befd6400d299a3.1647006877.git.mchehab@kernel.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mauro, On Fri, Mar 11, 2022 at 03:07:20PM +0100, Mauro Carvalho Chehab wrote: > In order to cleanup the main platform media directory, move NXP > driver to its own directory. Hans has collected my CSIS patches https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=for-v5.18a&id=85fa189b2c829a005224cab3c2d88635dd36d777 in https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v5.18a which creates a drivers/media/platform/imx directory. Should that one be re-used ? > > Signed-off-by: Mauro Carvalho Chehab > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH v2 00/38] at: https://lore.kernel.org/all/cover.1647006877.git.mchehab@kernel.org/ > > MAINTAINERS | 2 +- > drivers/media/platform/Kconfig | 37 +---------------- > drivers/media/platform/Makefile | 4 +- > drivers/media/platform/nxp/Kconfig | 40 +++++++++++++++++++ > drivers/media/platform/nxp/Makefile | 5 +++ > drivers/media/platform/{ => nxp}/fsl-viu.c | 0 > drivers/media/platform/{ => nxp}/imx-pxp.c | 0 > drivers/media/platform/{ => nxp}/imx-pxp.h | 0 > .../media/platform/{ => nxp}/mx2_emmaprp.c | 0 > 9 files changed, 49 insertions(+), 39 deletions(-) > create mode 100644 drivers/media/platform/nxp/Kconfig > create mode 100644 drivers/media/platform/nxp/Makefile > rename drivers/media/platform/{ => nxp}/fsl-viu.c (100%) > rename drivers/media/platform/{ => nxp}/imx-pxp.c (100%) > rename drivers/media/platform/{ => nxp}/imx-pxp.h (100%) > rename drivers/media/platform/{ => nxp}/mx2_emmaprp.c (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1b6f48a660de..780ef2ef3362 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11841,7 +11841,7 @@ M: Philipp Zabel > L: linux-media@vger.kernel.org > S: Maintained > T: git git://linuxtv.org/media_tree.git > -F: drivers/media/platform/imx-pxp.[ch] > +F: drivers/media/platform/nxp/imx-pxp.[ch] > > MEDIA DRIVERS FOR ASCOT2E > M: Sergey Kozlov > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index ad95a25ae2fc..f5ef28d3e53c 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -36,6 +36,8 @@ config V4L_MEM2MEM_DRIVERS > to capture and output drivers, which use memory buffers for just > one of those. > > +source "drivers/media/platform/nxp/Kconfig" > + > # V4L platform drivers > > source "drivers/media/platform/marvell-ccic/Kconfig" > @@ -68,19 +70,6 @@ config VIDEO_SH_VOU > help > Support for the Video Output Unit (VOU) on SuperH SoCs. > > -config VIDEO_VIU > - tristate "Freescale VIU Video Driver" > - depends on V4L_PLATFORM_DRIVERS > - depends on VIDEO_V4L2 && (PPC_MPC512x || COMPILE_TEST) && I2C > - select VIDEOBUF_DMA_CONTIG > - default y > - help > - Support for Freescale VIU video driver. This device captures > - video data, or overlays video on DIU frame buffer. > - > - Say Y here if you want to enable VIU device on MPC5121e Rev2+. > - In doubt, say N. > - > config VIDEO_MUX > tristate "Video Multiplexer" > depends on V4L_PLATFORM_DRIVERS > @@ -281,16 +270,6 @@ config VIDEO_CODA > config VIDEO_IMX_VDOA > def_tristate VIDEO_CODA if SOC_IMX6Q || COMPILE_TEST > > -config VIDEO_IMX_PXP > - tristate "i.MX Pixel Pipeline (PXP)" > - depends on V4L_MEM2MEM_DRIVERS > - depends on VIDEO_DEV && VIDEO_V4L2 && (ARCH_MXC || COMPILE_TEST) > - select VIDEOBUF2_DMA_CONTIG > - select V4L2_MEM2MEM_DEV > - help > - The i.MX Pixel Pipeline is a memory-to-memory engine for scaling, > - color space conversion, and rotation. > - > source "drivers/media/platform/imx-jpeg/Kconfig" > > config VIDEO_MEDIATEK_JPEG > @@ -431,18 +410,6 @@ config VIDEO_SAMSUNG_S5P_MFC > help > MFC 5.1 and 6.x driver for V4L2 > > -config VIDEO_MX2_EMMAPRP > - tristate "MX2 eMMa-PrP support" > - depends on V4L_MEM2MEM_DRIVERS > - depends on VIDEO_DEV && VIDEO_V4L2 > - depends on SOC_IMX27 || COMPILE_TEST > - select VIDEOBUF2_DMA_CONTIG > - select V4L2_MEM2MEM_DEV > - help > - MX2X chips have a PrP that can be used to process buffers from > - memory to memory. Operations include resizing and format > - conversion. > - > config VIDEO_SAMSUNG_EXYNOS_GSC > tristate "Samsung Exynos G-Scaler driver" > depends on V4L_MEM2MEM_DRIVERS > diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile > index 1a52a1a784b5..e9f982eb034b 100644 > --- a/drivers/media/platform/Makefile > +++ b/drivers/media/platform/Makefile > @@ -22,6 +22,7 @@ obj-y += mtk-jpeg/ > obj-y += mtk-mdp/ > obj-y += mtk-vcodec/ > obj-y += mtk-vpu/ > +obj-y += nxp/ > obj-y += omap/ > obj-y += omap3isp/ > obj-y += qcom/camss/ > @@ -45,10 +46,8 @@ obj-y += vsp1/ > obj-y += xilinx/ > > # Please place here only ancillary drivers that aren't SoC-specific > -obj-$(CONFIG_VIDEO_IMX_PXP) += imx-pxp.o > obj-$(CONFIG_VIDEO_MEM2MEM_DEINTERLACE) += m2m-deinterlace.o > obj-$(CONFIG_VIDEO_MUX) += video-mux.o > -obj-$(CONFIG_VIDEO_MX2_EMMAPRP) += mx2_emmaprp.o > obj-$(CONFIG_VIDEO_PXA27x) += pxa_camera.o > obj-$(CONFIG_VIDEO_RCAR_DRIF) += rcar_drif.o > obj-$(CONFIG_VIDEO_RCAR_ISP) += rcar-isp.o > @@ -58,4 +57,3 @@ obj-$(CONFIG_VIDEO_RENESAS_FDP1) += rcar_fdp1.o > obj-$(CONFIG_VIDEO_RENESAS_JPU) += rcar_jpu.o > obj-$(CONFIG_VIDEO_SH_VOU) += sh_vou.o > obj-$(CONFIG_VIDEO_VIA_CAMERA) += via-camera.o > -obj-$(CONFIG_VIDEO_VIU) += fsl-viu.o > diff --git a/drivers/media/platform/nxp/Kconfig b/drivers/media/platform/nxp/Kconfig > new file mode 100644 > index 000000000000..92724121ff91 > --- /dev/null > +++ b/drivers/media/platform/nxp/Kconfig > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +# V4L drivers > + > +config VIDEO_VIU > + tristate "Freescale/NXP VIU Video Driver" > + depends on V4L_PLATFORM_DRIVERS > + depends on VIDEO_V4L2 && (PPC_MPC512x || COMPILE_TEST) && I2C > + select VIDEOBUF_DMA_CONTIG > + default y > + help > + Support for Freescale VIU video driver. This device captures > + video data, or overlays video on DIU frame buffer. > + > + Say Y here if you want to enable VIU device on MPC5121e Rev2+. > + In doubt, say N. > + > +# mem2mem drivers > + > +config VIDEO_IMX_PXP > + tristate "i.MX Pixel Pipeline (PXP)" > + depends on V4L_MEM2MEM_DRIVERS > + depends on VIDEO_DEV && VIDEO_V4L2 && (ARCH_MXC || COMPILE_TEST) > + select VIDEOBUF2_DMA_CONTIG > + select V4L2_MEM2MEM_DEV > + help > + The i.MX Pixel Pipeline is a memory-to-memory engine for scaling, > + color space conversion, and rotation. > + > +config VIDEO_MX2_EMMAPRP > + tristate "Freescale/NXP MX2 eMMa-PrP support" > + depends on V4L_MEM2MEM_DRIVERS > + depends on VIDEO_DEV && VIDEO_V4L2 > + depends on SOC_IMX27 || COMPILE_TEST > + select VIDEOBUF2_DMA_CONTIG > + select V4L2_MEM2MEM_DEV > + help > + MX2X chips have a PrP that can be used to process buffers from > + memory to memory. Operations include resizing and format > + conversion. > diff --git a/drivers/media/platform/nxp/Makefile b/drivers/media/platform/nxp/Makefile > new file mode 100644 > index 000000000000..147bd7ad4ef4 > --- /dev/null > +++ b/drivers/media/platform/nxp/Makefile > @@ -0,0 +1,5 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +obj-$(CONFIG_VIDEO_IMX_PXP) += imx-pxp.o > +obj-$(CONFIG_VIDEO_VIU) += fsl-viu.o > +obj-$(CONFIG_VIDEO_MX2_EMMAPRP) += mx2_emmaprp.o > diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/nxp/fsl-viu.c > similarity index 100% > rename from drivers/media/platform/fsl-viu.c > rename to drivers/media/platform/nxp/fsl-viu.c > diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c > similarity index 100% > rename from drivers/media/platform/imx-pxp.c > rename to drivers/media/platform/nxp/imx-pxp.c > diff --git a/drivers/media/platform/imx-pxp.h b/drivers/media/platform/nxp/imx-pxp.h > similarity index 100% > rename from drivers/media/platform/imx-pxp.h > rename to drivers/media/platform/nxp/imx-pxp.h > diff --git a/drivers/media/platform/mx2_emmaprp.c b/drivers/media/platform/nxp/mx2_emmaprp.c > similarity index 100% > rename from drivers/media/platform/mx2_emmaprp.c > rename to drivers/media/platform/nxp/mx2_emmaprp.c > -- > 2.35.1 >