Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220310164532.1821490-1-bgardon@google.com> <20220310164532.1821490-8-bgardon@google.com>
 <CABOYuvY8sJgzC2VA=i4gddDu=jZCffFNi5E4G2cJ2B01zg3XcA@mail.gmail.com>
In-Reply-To: <CABOYuvY8sJgzC2VA=i4gddDu=jZCffFNi5E4G2cJ2B01zg3XcA@mail.gmail.com>
From:   Ben Gardon <bgardon@google.com>
Date:   Thu, 10 Mar 2022 11:07:00 -0600
Message-ID: <CANgfPd_=5=Xey14N4=46_dKYHnmmMn=yJFep7M44wE9czCz5dw@mail.gmail.com>
Subject: Re: [PATCH 07/13] selftests: KVM: Add NX huge pages test
To:     David Dunn <daviddunn@google.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Peter Xu <peterx@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        David Matlack <dmatlack@google.com>,
        Jim Mattson <jmattson@google.com>,
        Jing Zhang <jingzhangos@google.com>,
        Junaid Shahid <junaids@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 10, 2022 at 10:59 AM David Dunn <daviddunn@google.com> wrote:
>
> Ben,
>
> Thanks for adding this test.  Nit below.
>
> Reviewed-by: David Dunn <daviddunn@google.com>
>
> On Thu, Mar 10, 2022 at 8:46 AM Ben Gardon <bgardon@google.com> wrote:
>>
>>
>> +       /* Give recovery thread time to run */
>> +       sleep(3);
>>
> Is there any way to make this sleep be based on constants which control t=
he recovery thread?  Looking at the parameters below, this seems excessive.=
  The recovery period is 2ms with a 1/1=3D100% recovery ratio.  So this is =
padded out 1000x.  Maybe it doesn't matter because normally this test runs =
in parallel with other tests, but it does seem like a pretty large hardcode=
d sleep.

Woops, I meant to make the recovery period 2 seconds, which would also
be preposterously large. We absolutely can and should tighten that up.
100ms recovery period and 150ms sleep would probably work perfectly.
I'll make that change if/when I send out a v2.

>
> Dave