Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp791898pxp; Fri, 11 Mar 2022 15:14:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJzfGSqrB4d7Kt7tKJDTVC+oUz7hWv8N8qBqk16gc0r3EoVSjm1B7WuAbQFb+8mPFQw05euT X-Received: by 2002:a17:902:b694:b0:153:1d9a:11a5 with SMTP id c20-20020a170902b69400b001531d9a11a5mr10643919pls.151.1647040491779; Fri, 11 Mar 2022 15:14:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647040491; cv=none; d=google.com; s=arc-20160816; b=V6XLK7Vh6Um/pSGSAYtZDd/B/bfM6xJJ4rlLKlcO8LPc1nlea1HU5bi4ICp8ObyYmY 1h9s9S/1NUNtBa7mKRg431VGA2snu6CUAJAmGy5pcBNpSPWyYWDsu/tSkkepR3SezgEY B5bW12eCi6/mGTSMPTGmVYbnozPf+A1tCzZZTeg5rG5FoPr/LZDMsRxZv1nBCeQ30XJu LeI7rHckL+Py6+ZK1uS5iXBhIk4r6yKCfkkAlJoFxu0U9CmC8xY/kch8nVqbY1JOusC9 WdIkTt7CKkJnkI13nF8Pg0VcA0nYAdEW8iwJng4K8Fi+6DAoHIkp5Ervwi1G1bc7gppA ngOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=qSs+OWs1rd3swR36O2vNgKkkBCsIMZuIXdZ0u3m8Xik=; b=pIxgI+D//wI3mtbrwp6z91jmP034m3XSF/+HCjzcysYj1q7Lu5ZTDuReA0xdXf7Z7r k57qF+h0Xc5fv610p4uJagn39zNZHBJpkusGMz8wxVC3+P9jKXqYn9LH840Y76/35+7G ZAGu4AHWu8RO25YlsCYgsEBdCXEBVXKTa0RQCaqwZ1UT9KTLuyCng9ieAOCs7Wz44cdQ swkHYOJ7lPALTqx9GJLhGmqIJ36CpLvVNnXaYVTsgUTJRw4y3l1sfLfGuJOD5G+2sbTZ gx3nfmfXokXaqdjiczaHE1d78GOe0DEVvpKHj3CfLNgfyPEkIzv4Cq+9DNR3qhBc2IqQ XwZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ms4RRU4Z; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id d2-20020a656b82000000b00378faa5cbdesi9400302pgw.72.2022.03.11.15.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 15:14:51 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ms4RRU4Z; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8DBD03C50E1; Fri, 11 Mar 2022 14:15:03 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344900AbiCJXv0 (ORCPT + 99 others); Thu, 10 Mar 2022 18:51:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344975AbiCJXvW (ORCPT ); Thu, 10 Mar 2022 18:51:22 -0500 Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7344A1A06CD for ; Thu, 10 Mar 2022 15:50:15 -0800 (PST) Received: by mail-oi1-x22e.google.com with SMTP id w127so7653158oig.10 for ; Thu, 10 Mar 2022 15:50:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qSs+OWs1rd3swR36O2vNgKkkBCsIMZuIXdZ0u3m8Xik=; b=ms4RRU4ZyttsdToiIH3Sv1ehttlkGOuaHMYlv/yrwCG7GfF7G7ADyQ3pLWcdiSPTLg /4ZHSGavGVyd5cosnBfTPmshSYtXWjyiVV/xQKK2e9sj3fJDlRx4IJ1FsJWQA/Kyuq76 pddpVo6STWfBplBRrZyUbSlTYnT84S1d69lbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qSs+OWs1rd3swR36O2vNgKkkBCsIMZuIXdZ0u3m8Xik=; b=2Of1KdPPWIwOsDMp88wWGMojoGxugqOW0oT5Iq8TRqWogj5J5UXbiH68P8Z8IbjvKS JVyl+K6lG6UtYlwPLfIhseLfLm9jqU/fnE+J4aZzObs4h3PEsv1xKIBGvMI/2EgKOegr Z2LJKW0psC4e0mZRVS8T7vAZorF5V9c86Sm2Kwy2uO9stRgFjA3ft/kPBIXBJzy4o6iX WKFAk7PCdZW1E9bc0MO8t6uwPyD6ZCNQrs+IA+winm7S50Gb+W+S9AudW/b86h+xG4t9 2uwvCY/jrOQY2eyRKWkSJolslnQq2tXRlKYztkOSdegQ4yvQM0gt5cGP/lqUx50xwzcH ZXfg== X-Gm-Message-State: AOAM5326Mgaw/oslxc3Kt299GspH3JGrqeHFNGLRTs7Nggpo1W/dWxUE 43aTFi26yN8GtQbi52HAtR1x/McWJWizYQ== X-Received: by 2002:a05:6808:13cc:b0:2da:7639:aec8 with SMTP id d12-20020a05680813cc00b002da7639aec8mr2485506oiw.13.1646956214110; Thu, 10 Mar 2022 15:50:14 -0800 (PST) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com. [209.85.161.54]) by smtp.gmail.com with ESMTPSA id t15-20020a056808158f00b002e331356c87sm211867oiw.39.2022.03.10.15.50.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Mar 2022 15:50:12 -0800 (PST) Received: by mail-oo1-f54.google.com with SMTP id l24-20020a4a8558000000b00320d5a1f938so8729762ooh.8 for ; Thu, 10 Mar 2022 15:50:11 -0800 (PST) X-Received: by 2002:a05:6870:b52c:b0:da:b3f:3273 with SMTP id v44-20020a056870b52c00b000da0b3f3273mr4139015oap.291.1646956211126; Thu, 10 Mar 2022 15:50:11 -0800 (PST) MIME-Version: 1.0 References: <20220228202532.869740-1-briannorris@chromium.org> In-Reply-To: <20220228202532.869740-1-briannorris@chromium.org> From: Brian Norris Date: Thu, 10 Mar 2022 15:50:00 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes To: Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Sean Paul Cc: dri-devel , Sean Paul , Jernej Skrabec , Laurent Pinchart , Jonas Karlman , Heiko Stuebner , Linux Kernel , Liu Ying , Doug Anderson Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 28, 2022 at 12:25 PM Brian Norris wrote: > > Hi, > > I've been investigating several eDP issues on a Rockchip RK3399 system > and have two proposed bugfixes. RK3399 has two CRTCs, either of which > can be used for eDP output. For both fixes, we have bugs due to the > relationship between the generalized "self refresh helpers" and the > analogix-dp bridge driver which controls much of the PSR mechanics. > These bugs are most visible when switching between CRTCs. > > I'm not a DRM expert, but I've been poking at a lot of Rockchip display > drivers recently. I'd love some skeptical eyes, so feel free to ask > questions if I haven't explained issues well, or the proposals look > fishy. > > Regards, > Brian Ping for review? Sean, perhaps? (You already reviewed this on the Chromium tracker.) Brian