Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <15acc266-2b92-9064-399b-3d5e4b7ccf85@intel.com>
Date:   Fri, 11 Mar 2022 15:13:15 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH v5 3/6] selftests/resctrl: Fix resctrl_tests' return code
 to work with selftest framework
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        "Shuah Khan" <skhan@linuxfoundation.org>
References: <20220311072147.3301525-1-tan.shaopeng@jp.fujitsu.com>
 <20220311072147.3301525-4-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220311072147.3301525-4-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDVFWXNCTm9uZ3QwK1NjaHNlRzFsVDBacUtCOFY3WndaUDV5TnEyd3NkbWhN?=
 =?utf-8?B?VHhpMUpndFFMUXhuU0QzWmNlTEllRWZWN1Bja004UldST01OaHVLTCtpaHc0?=
 =?utf-8?B?WjQwdTJsTVNXZWNGSmtPOS84Ym9SSitpMzdxYWZsaEJWejJGQ0lUYmxnU2hM?=
 =?utf-8?B?VVBrN25OZVUrUnNQNm1vMmNBM0lPSnVON0UzT00xbXVGaTFNQks3Y1NiR3hm?=
 =?utf-8?B?Y1oya0lhNzc2aDJWb05iNXJ6ZDdLSThRbngvaCtEN1BNM0ZzNzQrU3RYeDhn?=
 =?utf-8?B?ZmZ3MVpJU05nV3VJOEJmTFB3RGowL1V5bWF0M3RTeGVjaUNFRjdYQlh4Z21k?=
 =?utf-8?B?RGtSWW1Ma3NUL09ZdE16RDBEd0d3MkJERVM2Q2JzWXRDM0lieFVrVXFUR0Mz?=
 =?utf-8?B?R0tLNkU4TGJqVW5QVkkxVXp5eGZiODEydXFNZjFPWjNqUXJrZXFoZDRFV3lt?=
 =?utf-8?B?cGRRNlNGcmlJcGtFSFBUWVVza1RQYkJ4U3Y2NmVmTUFSbTdzTGYwTnkvLy9K?=
 =?utf-8?B?WkFrY0drd1YremNjUitwczRGdkFGV3R5KzVRVW5Ib2dDMm1sdkFmbG5VQUNG?=
 =?utf-8?B?cWh2UzZZMW9VMkF1cUlKcGZEeTZCZHV5VW5TZmFYd1NveXlQbGZFK2RwTnJY?=
 =?utf-8?B?Z0tmVU1GRjRVamtMS1h1ZGMyMFU0MVBPSUdqa25Nc3d2bHVuaDZDUHVoZXJN?=
 =?utf-8?B?VDJ0M1pScks4TFBrT0N3Tm5jNk8vQ0NCejJWeXZnV3NJSlpyS3R4bEJNQ0d4?=
 =?utf-8?B?SndhWlhJNmZLSGVyU0RacStWVXI1QTZYS3c1TklOU0dEUDRsVHlVUHVYVzNF?=
 =?utf-8?B?SDBnRmRVYk94YTU4OVVMM05ZWEpyRE5XL0lqWGVOTnJDS1NZbjlCMkh0WWs5?=
 =?utf-8?B?TWpFalpDT25heDVDOWJGTHJDRm8yWkEwNXhjek5oeEdIam5ybTlodmFnY0FI?=
 =?utf-8?B?Ump5ZXJsVk9qVjdJVmNuUE5aWWhiWVoxVFBhdlJsMHpmdzVwZUtsWmNXVExq?=
 =?utf-8?B?RmN1a2EyKyttU0FWazkxb0xiZGx4M0RJRDZTTW5HTmdES2sraE9xTGR0QWRh?=
 =?utf-8?B?cnhVaDVYdVk2WEYwUmp0UlNDYS9ubzFXM1hHSFVLYnRsN1VhZHUweTF0SUF6?=
 =?utf-8?B?RjhPaVFra1ZSVkUwN1BGZzd4Q3FxL2MvQTFTMTZNTlNybjJVbk1Ceml1a0Fw?=
 =?utf-8?B?OTJSdEptSi9lSHl1L0o2SGdkNkJrcHdjQWxMN0pVVEVoWWZWbDJQR0tHOGVY?=
 =?utf-8?B?T0k3Q3UvWGhWZ1pOV2QrN3Zjdmh6K0hmOFFUeG4ySUpNVlcxZFZPVm1HZTQz?=
 =?utf-8?B?RjVIUWhteVZqQWIyYm1wTk9wY1h1NUJtWW45ZU1vRFI2WEZiMXlJN3JGMHor?=
 =?utf-8?B?QWdOblVZUmR1R1JySGo0Qlc2aHZzNlhVNXZHTS93azl3cm10a29IMldDaUhO?=
 =?utf-8?B?YUhkWm1tWXczcFFJNW9LZkE2bENkK21rc0tDV3J4SEdpTDNZTUpzQXFObTFt?=
 =?utf-8?B?RE00bFRLbDR1QXBqMG85RkZUbndWbXgzS3VWa0tHaHBqNTN1amQxSWJQN3dl?=
 =?utf-8?B?MFk5TkpNWks4dTBjUitOV2gyZ2I5TWs5QW1jdkFzanRQQ1B0aUo3Zks3TDVX?=
 =?utf-8?B?RmZ5V090RnluTmdUMmtaQm4yR05Jd1JQSHMwUE5DWnVhckNCRjFmM0NwZnpq?=
 =?utf-8?B?QWh5cnJUM04wVW82ZnhqeVBEb284NnVRY2JoU2d1bVdrc3JhZnduY2Z0RVJV?=
 =?utf-8?B?K3VnOTdTU2FnWU1ucnZyanZHaWJnYWRjaUYwbnJTcG9XRXFmaXU0WWxMaVp6?=
 =?utf-8?B?MHFiNTJIUEU2TkZFQzd4TGpIeHNMQjJmYTFteTBpTGVwcW5zN2wrY0hJY2Nz?=
 =?utf-8?B?RkhjZmdyQ29uVHBrK0dmWlgyY3oycUpIcFBTV2tuZnZqMnR3RVJEaDRmWDhV?=
 =?utf-8?B?QzdCSXJWelhsSFpwYjdUczZMUXdXVHpzQmJxVUNEdnNMQkhEMXRrRG5vb2VG?=
 =?utf-8?B?RGlsakFab2V6d0dXTzBicmhwZWc0bTYycmhhVXlrb3JTdjY2TDBtOWZ4KzZ4?=
 =?utf-8?B?QTNnV3kyMGFHeU5iZTFMLzltRmNVZGVKd1h1dXIzY1AvaUE1K05BUnlZbmk3?=
 =?utf-8?B?eThiQUxXalY1NUVPM245ek1aZVcvQThlWlB2TUNrcG9IZzRQVzhQaDROTTR5?=
 =?utf-8?B?UVlKSGlXRTNNNDg0QUdJa0tqYk93KzM3TUFIbnQ4ZC9QSWJYOCtjNTNuZXBG?=
 =?utf-8?Q?ipNBYfIGutjpPGuUOoI/Cyw30OdWbMzSYl7zybcrNw=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 195fc74a-5198-412f-43eb-08da03b4ba5c
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5740.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 23:13:18.6650
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iaxjYoDbW08mo1NI7AGBMOXYwF9C56K2zSRAFHEm4BiNYE3dysMi+ad39342YmTg3QyK15Znm+2fg7A6ptB5gXgPwCVRAkgt3AoHYv1fHY4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1512
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 3/10/2022 11:21 PM, Shaopeng Tan wrote:
> In kselftest framework, if a sub test can not run by some reasons,
> the test result should be marked as SKIP rather than FAIL.
> Return KSFT_SKIP(4) instead of KSFT_FAIL(1) if resctrl_tests is not run
> as root or it is run on a test environment which does not support resctrl.
> 
>  - ksft_exit_fail_msg(): returns KSFT_FAIL(1)
>  - ksft_exit_skip(): returns KSFT_SKIP(4)
> 
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
> index 973f09a66e1e..a44afb05b848 100644
> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
> @@ -205,7 +205,7 @@ int main(int argc, char **argv)
>  	 * 2. We execute perf commands
>  	 */
>  	if (geteuid() != 0)
> -		return ksft_exit_fail_msg("Not running as root, abort testing.\n");
> +		return ksft_exit_skip("Not running as root. Skipping...\n");
>  
>  	/* Detect AMD vendor */
>  	detect_amd();
> @@ -235,7 +235,7 @@ int main(int argc, char **argv)
>  	sprintf(bm_type, "fill_buf");
>  
>  	if (!check_resctrlfs_support())
> -		return ksft_exit_fail_msg("resctrl FS does not exist\n");
> +		return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL and PROC_CPU_RESCTRL config options.\n");

The resctrl tests do not depend on or exercise the code enabled when PROC_CPU_RESCTRL
is set so there is no need to require users to enable it. It (PROC_CPU_RESCTRL) is
automatically selected anyway if PROC_FS is enabled.

An explicit check for the existence of /proc/{pid}/cpu_resctrl_groups would be
required if somebody ever does add a resctrl test to exercise the code enabled
by that config. There is no need to require that setting now.

Thus could just be "resctrl FS does not exist. Enable X86_CPU_RESCTRL config option."

>  
>  	filter_dmesg();
>  

Reinette