Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <54c1f2f7-5475-6c23-7dbf-3a72c7405c53@intel.com>
Date:   Fri, 11 Mar 2022 15:14:00 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH v5 4/6] selftests/resctrl: Make resctrl_tests run using
 kselftest framework
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20220311072147.3301525-1-tan.shaopeng@jp.fujitsu.com>
 <20220311072147.3301525-5-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220311072147.3301525-5-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVVQRm5oNzNqeEdzN3ErSDVtRmVOalZLL3hjSElUd3VBVkgvcHZpRjBhT2V5?=
 =?utf-8?B?MENCZjhkSTNDdW9OYVU3WGNWaHo0TW5MUGNqTy9VeXEzOE1KMUdMZElUQlFO?=
 =?utf-8?B?RXR2MlBrQXVPTHhWTjdMRVJidXp1akFwNEpSUzJtTkJXeElQUHZ4cVhZaGJa?=
 =?utf-8?B?QWtUT29ON1RNNXk0R0hxNi9SK01nL0dsT2o2Z2pxZXZNamhsUmJ0NlQrU0s4?=
 =?utf-8?B?dHE5UjkxQzVzQk0wNmRtOXFZWk90eWxjVHQ2YjUxaUFVamlSVHAzUTFZc0V4?=
 =?utf-8?B?bWlXSVVNcHo0cUVlV1VPVjVxQmVaRHhlK3o4K0FpZGJYUXpFZVRVaDJnRmh4?=
 =?utf-8?B?dmQ1bkQ0SWphYzk2NFRIZ2NtWVdXQUVXc3NCRStQY3VBZnFJYnJLUG5rSmZx?=
 =?utf-8?B?MjZvamhkVEtmZHdpUEdlbnFGQTVLTUhLZnBveW5LRGF4ZXNiSGVLb1RrMnVZ?=
 =?utf-8?B?dFpWRm51MnJOaE0yZDBiNHExUmFWcHc1V2lONThmNmJpWkRlRzVkNDFGU3JQ?=
 =?utf-8?B?S0tSdVVsYVRQVFBqRlBDZ1M3ZkdrdFpkWitaM0VJcWJQbndyVzRNTmtjZnRY?=
 =?utf-8?B?Q3ZqQnVNNG9BMzk1cXd1VHc4cTBSdmNTNXl6SXN2NXdVaERxdzN5ZVF1ODV4?=
 =?utf-8?B?MUxRRnhyRnlVMDhUbVBOQTlsUHVpbUFvNU8wWE5xeklPWVpnYWVMcFkvN1Nm?=
 =?utf-8?B?YXUraXdjd3ZQMUNkQnFFWEsyVXFqTUJBMjYvWGFxYVJnZ09PcWJQQmxtcTkr?=
 =?utf-8?B?UWtPdC9ScW4ySGZUeHRRWXkyOVkzdnl3WGgvZlA4YmpGOXA3RjhhZlhTRmQw?=
 =?utf-8?B?MXozRW9hOUczSDJJVDBENllwWEpmNE9UTm5xWFIxOHoxMnJZQWtscE15T0dk?=
 =?utf-8?B?SHZudW9CcFZ3aDhLczd1c1VHUVBSb2x3VlljQ3ZVZEJQRmFtYm0yUnA0K2lJ?=
 =?utf-8?B?R0M4Um5iYW1DSXhzVjR0OTN6NE1NVnQ2MjNpSm5MSGNXbTdUZ3hqaU1zdTBZ?=
 =?utf-8?B?NjJkdzhpTGtDNDU0TUVyVDdzZExzMDk2a2E3RXBZYVRaUURQaUVpU2FOeUhC?=
 =?utf-8?B?ZnBzNFZyRS9FMjlYbWpQQ1RLNDIrOHZXSFBYODEyRnljQ0VNbjYvZlUrRUY5?=
 =?utf-8?B?MW0wTzMzZU9tVmlSZjdKVDJaRGRmbU52TFZVZ2U2YkttKy8yQVVuc0ppdVEx?=
 =?utf-8?B?bzZ3STBNZlVFSnYxNTVsa3llTUFGZzJiV2ErejA2dnFyUGtvRENCVDhpV1pJ?=
 =?utf-8?B?ZkVjMXF1WHpPajc2ZVNzV0g3N3pnOU1BSmZRZXluSU11dGtaMWhhZE1FQ3Bl?=
 =?utf-8?B?VU1hTCsreis4K1dXRGk1N2V0RHFpaVFVenNLZFpGd3cxbldNRkdpcTFBOHph?=
 =?utf-8?B?WU8yUkV3NWRtT210aE5rS29TdEtOZlJYNitnbWxKd0U2UDh4aTJFU2t4YXhS?=
 =?utf-8?B?TjIzV0toVS90SFcvVUVjcXJhcG5lZGkzNG9FNExxT1czNmJYZmRYNGRkY3VO?=
 =?utf-8?B?dG4rL3BON2lHcXdBdzg2UG9KaEM5a1NVd0VndXlzUmdiWGo1aVJkWElzeC9m?=
 =?utf-8?B?UmFGVEtZNjNNeHkzSldVcEppY0lKMWg3KzhhZFRMVWFMUDFIRmQvaFN4Slpr?=
 =?utf-8?B?K1ZhRGNrRWhLdHVWVUFhZkpCOUdKMlVMdGhQVEdVV3VGYi8yWHpJd3EvcHVw?=
 =?utf-8?B?SFM1dkRJTElrZ2xmS0dMb2c1VFpsMW1KUE81U3krRlhwWHYvMjEvNUR1MzR4?=
 =?utf-8?B?Y1hhNUlFVFhxekgxK3dBd3NMWHFJTTU0RWxJSTQwdHhlc2dXWDZqNkdRMEt0?=
 =?utf-8?B?UE5pQ1pGODhMQndWMWVvMkZSdEtMVmFsQ1l4akkxck9nUlhVNVZEelpBNk51?=
 =?utf-8?B?ekdRY2MzNHpCeWQvbUIzK3RKc0gxU2I1VDQ3NUcrMmNRWmo2U1RMbmhlVlVn?=
 =?utf-8?B?L2loY1RSUE1ERk9oZzlIOFNWZm5BcVBzNE5tVkxaRmw1MG5YUzZvTDI3WXJE?=
 =?utf-8?B?eGc5MkxJTUxncGlOcE9LSXIxdzl0WkE0SHl0L1lCbzNkazFIbDAvNkIvRVBl?=
 =?utf-8?B?cElyVEh0STA3cTNuZXJ0cG9tTlNHWjZKOTdoOWtEMHc4YWhZKzI4MFk4S1ha?=
 =?utf-8?B?UG0yNDhCbVQyQVlnZ2VmcWl1angreTFDcTRETkVKSFR6MkFiUjF0dlNFdEE4?=
 =?utf-8?B?KzdyQkM1V0drRnV3V3BJdDVtZXlQeVloOEF0VkQxSmpyS0hUWEQwU1FmbGxo?=
 =?utf-8?Q?LLIEL8QfJKAzNkNlgm4ie8w3KGyPcdrbPZGH1nXxy4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a1552b1-9a46-498b-2b0a-08da03b4d52e
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5740.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 23:14:03.4727
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UcLi91JLq1Rd12plOCI+Fi17xhZjlyNkGWCq2WoDL2O9MGiGcmIm5oqKTuvZNFnb1lPG+OWmvcBmYzPnjFgkLufanLEMFLAE6pTF7fddSpU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1512
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 3/10/2022 11:21 PM, Shaopeng Tan wrote:
> In kselftest framework, all tests can be build/run at a time,
> and a sub test also can be build/run individually. As follows:
> $ make kselftest-all TARGETS=resctrl
> $ make -C tools/testing/selftests run_tests
> $ make -C tools/testing/selftests TARGETS=resctrl run_tests
> 
> However, resctrl_tests cannot be run using kselftest framework,
> users have to change directory to tools/testing/selftests/resctrl/,
> run "make" to build executable file "resctrl_tests",
> and run "sudo ./resctrl_tests" to execute the test.
> 
> To build/run resctrl_tests using kselftest framework.
> Modify tools/testing/selftests/Makefile
> and tools/testing/selftests/resctrl/Makefile.
> 
> Even after this change, users can still build/run resctrl_tests
> without using framework as before.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/Makefile         |  1 +
>  tools/testing/selftests/resctrl/Makefile | 18 +++---------------
>  2 files changed, 4 insertions(+), 15 deletions(-)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index d08fe4cfe811..6138354b3760 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -52,6 +52,7 @@ TARGETS += proc
>  TARGETS += pstore
>  TARGETS += ptrace
>  TARGETS += openat2
> +TARGETS += resctrl
>  TARGETS += rlimits
>  TARGETS += rseq
>  TARGETS += rtc
> diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile
> index 6bcee2ec91a9..30af27b07d21 100644
> --- a/tools/testing/selftests/resctrl/Makefile
> +++ b/tools/testing/selftests/resctrl/Makefile
> @@ -1,17 +1,5 @@
> -CC = $(CROSS_COMPILE)gcc
> -CFLAGS = -g -Wall -O2 -D_FORTIFY_SOURCE=2

Please do keep these CFLAGS. You can find motivation in
a9d26a302dea ("selftests/resctrl: Enable gcc checks to detect buffer overflows")

> -SRCS=$(wildcard *.c)
> -OBJS=$(SRCS:.c=.o)
> +TEST_GEN_PROGS := resctrl_tests
>  
> -all: resctrl_tests
> +include ../lib.mk
>  
> -$(OBJS): $(SRCS)
> -	$(CC) $(CFLAGS) -c $(SRCS)
> -
> -resctrl_tests: $(OBJS)
> -	$(CC) $(CFLAGS) -o $@ $^
> -
> -.PHONY: clean
> -
> -clean:
> -	$(RM) $(OBJS) resctrl_tests
> +$(OUTPUT)/resctrl_tests: $(wildcard *.c)

Reinette