Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <73ad2b2f-a07c-d78b-cf1f-002e6a983c6d@intel.com>
Date:   Fri, 11 Mar 2022 15:12:20 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH v5 1/6] selftests/resctrl: Kill child process before
 parent process terminates if SIGTERM is received
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        "Shuah Khan" <skhan@linuxfoundation.org>
References: <20220311072147.3301525-1-tan.shaopeng@jp.fujitsu.com>
 <20220311072147.3301525-2-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220311072147.3301525-2-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkswUHlYM0Zaek11UktWRXVOaFhLZkdpdUhHdmZLV2pVWktIMlAvN3c3MThE?=
 =?utf-8?B?eFdkbm50UnlwenRKcjlJeXVFVDhqbURvSnBQbC9vQ2RtNWdkMVhZSkRjQk04?=
 =?utf-8?B?NDcyK2xUMzFmMGxseTVYNW82S1MvaFdOaklTMmF5K3p0SStyK1NMOFVCckZZ?=
 =?utf-8?B?M0ZGZytuSjJEUkttL29UejcrZjMvTW94ZG84b09EUVd2aFNwUW1RZEFSMktV?=
 =?utf-8?B?NjM5LytuYjVlQUxYTEI1dVVMdGJrQTdzQk1CU0dhbmdmT2NqQXMrQnNhQnNq?=
 =?utf-8?B?VHJjbU01cjV1Wmo2TkRqTWl2N1Q0dDRtMmo5d0ZOb2EwZ2E1VGt3VzZhOUJS?=
 =?utf-8?B?UnZja3ZKV3VEYTdpb3lBZ2NyWHR1NC90TjNlN1JCRWJzektQK2FJUHdsTmpX?=
 =?utf-8?B?ejdnSmJJTU1pWkhIYWJnUXpHMUk1V0NWcmpZS1NDV1RTYmNENXNZeEhhdXBk?=
 =?utf-8?B?dzR6ZTJ1YUxpODdyUjVab2JCa1ZmUHU0Z2hnWWhMOGxaQlVQQXVDeFI2TlZl?=
 =?utf-8?B?cFB0TXduYU4yN0xtOXdZeWRHQnRQdmhzZ2U5Y0E5NEtZRkQ4TDAxK0svMXY0?=
 =?utf-8?B?VW1DZHI4YU41UnBjaFlvdW1mQ3VPR2RobDgzWEQzeDJYUy93ZGdOSEdBNW5B?=
 =?utf-8?B?Z3c4TTloSEpBbkczZHU0bDFtTGM4cFZhdTB2a0pqQWFRanZkV3Foc2hGbUpJ?=
 =?utf-8?B?dVhNNlFyZnJlTlNHanVzUk1hQUg4U0hIR1VKOUw3Rm5vNEdJOUprcUxLUGE3?=
 =?utf-8?B?aWZacjdUOEE0QURsZjlFWkE0QnNRcU1GazZqRDVJTDcrM0psWlRybFZRaUd5?=
 =?utf-8?B?cEhIWHpGbysrMzlScEJ4eU5YamxmY3VIbEl4eFlGVkNpRkpmczJndlVRdnZX?=
 =?utf-8?B?VVkySHVpbVBMVHQwamZoOEpxUWcyS2lwVUQwSzd3RzNCSlhUd213UEk2MUJB?=
 =?utf-8?B?am5wN0FadUNOblhPZ2pEZDRPZlZ4ZEhHVWdMU1pPQkVNSkM1ZVBOVEdHWE1H?=
 =?utf-8?B?RWhwQVRuNFFDMnZMeC9sYmkxTVhGVEI5L00rV0RQOE9WaE9SVUR0ek9DdUVP?=
 =?utf-8?B?MjhGRm5wZmloaGlaL3E5RE84Z2haYTRPY3lwQ3hoUkJoRTYzZzEzY0hPbm5B?=
 =?utf-8?B?OS9ESklUeWxlNURlOE1aWmI5NDRuTXVFOWY3Vlp2TDYzMklFOVcyRklZQmYy?=
 =?utf-8?B?aW9BMXg1OEJ6WGZ2eGM4Ty9oZ3R1L1VTWnRINmtYZmQ2aWRMTWUyQUY1aW05?=
 =?utf-8?B?amxZZTk5VXV0R05jMkFiZWdkM0VEdW5OZ2lOUzc5eFF4d0tjdWI5ZW8yV3o5?=
 =?utf-8?B?b0JLejJzdzBiUzZteWppL2E1aHNtM01RYkJZZ2crZVJxOVlNR29YU3NlNGJX?=
 =?utf-8?B?UFFHOEhPTVRQSUxjYXQrcXhTRVhyOUlBamEwSHdXKzlaRmhPSkx4cUlTelNm?=
 =?utf-8?B?Vm5VejZJellBOWxtNU8rT2wrcmdTV3NDNkthYkFlbGxuZWVZckg0dXVYWHZl?=
 =?utf-8?B?UjdKZnZWUDVxL3U4d202TUlOYTF1R3JFdHNtbTZjWkpkTm5ERjR2bWlMaHZN?=
 =?utf-8?B?ZnY0aFNXbkZrN012ZmhqQ29IUDBIODFCd1JVVEdsZTdaOVNleDJZTS9EcW1K?=
 =?utf-8?B?MjhjbjhkZTF4NjUzRysyeDBzWmxmRlZmUFgxYkEvN0ZWaVdHSzNOUmkzRG1S?=
 =?utf-8?B?bnRPVjlMV09MSTlqQUY2UGN2V3VQYTZrYys5bGMyTnZmK0tKdWM1Rm9KMExD?=
 =?utf-8?B?UlgzZEgvNUxjamY4RnBqaXFTT3kyeEZYU1NydmxxS1pNdVJxWlR4WmJUeTdu?=
 =?utf-8?B?M24vdkR3OUNqcUV5Q01zQ3FTRlBnZXNGdzBRQ1dzY2crNVYxeHh5cWZDSGtw?=
 =?utf-8?B?V0RzWktsZUFVUXNQZG1lZk0zWnFRdFIwRG50aTMxazBHT3FockxMalNzTmV1?=
 =?utf-8?B?K0hMVlpFRUd4VVRWdXpQMXV3TG5qSlNuSGFPdGR0cWNlSDhSMzc5b3QyM3FF?=
 =?utf-8?B?M0tUUWF3azc1SVhNQ0xrak50blNVbEJNa1ZWYkJEcHE0WUppdEVadXpoaFFK?=
 =?utf-8?B?Z1ViNFpFWFRGRTJXOFRPcWdxcmhuSUhlc3h4bnJFeXVmOXljZTFiU0p3K3lJ?=
 =?utf-8?B?Y2F1SnRYcW9Fc1d1Q2dqODBIUnN1RHcwRmFxVmVJZFVueVBYaXRDamZ4Zzk2?=
 =?utf-8?B?MGJLMUhVR20zVWNiYjlCR1BYRjJGTWFVWHJVajV1S2daUjcyYnVSVTROYWFr?=
 =?utf-8?Q?WwuIXKAoCyW+UsixNJvZMtIi9v9GrRCs46ky1WBKQE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d9be124-206d-4f66-cd62-08da03b499a7
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5740.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 23:12:24.7640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ze9S2KlvRNmBOnWOZNEnFDUUt/Bh9JY2rrlO9IhAywqYYXyASvTMJxSaYFJ02IjyXOWaQngRVpq5LajJdWHKigQDTtnkl/Op6dL2hh/iv64=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4945
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 3/10/2022 11:21 PM, Shaopeng Tan wrote:
> In kselftest framework, a sub test is run using the timeout utility
> and it will send SIGTERM to the test upon timeout.
> 
> In resctrl_tests, a child process is created by fork() to
> run benchmark but SIGTERM is not set in sigaction().
> If SIGTERM signal is received, the parent process will be killed,
> but the child process still exists.
> 
> kill child process before parent process terminates
> if SIGTERM signal is received.
> 
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_val.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c
> index 95224345c78e..b32b96356ec7 100644
> --- a/tools/testing/selftests/resctrl/resctrl_val.c
> +++ b/tools/testing/selftests/resctrl/resctrl_val.c
> @@ -678,6 +678,7 @@ int resctrl_val(char **benchmark_cmd, struct resctrl_val_param *param)
>  	sigemptyset(&sigact.sa_mask);
>  	sigact.sa_flags = SA_SIGINFO;
>  	if (sigaction(SIGINT, &sigact, NULL) ||
> +	    sigaction(SIGTERM, &sigact, NULL) ||
>  	    sigaction(SIGHUP, &sigact, NULL)) {
>  		perror("# sigaction");
>  		ret = errno;

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette