Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a007c783-49a2-4ab3-a592-9f37ea41eaae@huawei.com>
Date:   Fri, 11 Mar 2022 14:00:13 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] perf parse-events: Fix null check
To:     Weiguo Li <liwg06@foxmail.com>, <peterz@infradead.org>,
        <mingo@redhat.com>, <acme@kernel.org>
CC:     <mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
        <jolsa@kernel.org>, <namhyung@kernel.org>,
        <linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <tencent_DF39269807EC9425E24787E6DB632441A405@qq.com>
From:   John Garry <john.garry@huawei.com>
In-Reply-To: <tencent_DF39269807EC9425E24787E6DB632441A405@qq.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/03/2022 13:06, Weiguo Li wrote:
> We did a null check after "tmp->symbol = strdup(...)", but we checked
> "list->symbol" other than "tmp->symbol".
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>

Reviewed-by: John Garry <john.garry@huawei.com>

> ---
>   tools/perf/util/parse-events.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 9739b05b999e..dfb50a5f83d0 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -2193,7 +2193,7 @@ int perf_pmu__test_parse_init(void)
>   	for (i = 0; i < ARRAY_SIZE(symbols); i++, tmp++) {
>   		tmp->type = symbols[i].type;
>   		tmp->symbol = strdup(symbols[i].symbol);
> -		if (!list->symbol)
> +		if (!tmp->symbol)
>   			goto err_free;
>   	}
>