Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp801284pxp; Fri, 11 Mar 2022 15:30:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyFPukr8d/G+YeHV1lT6g6gQf+9iWffFnKOm0BdHYTu4Rkuvw2slADwBBAmA9onzomgmFLz X-Received: by 2002:a17:902:b202:b0:151:4f64:e516 with SMTP id t2-20020a170902b20200b001514f64e516mr13056435plr.16.1647041457666; Fri, 11 Mar 2022 15:30:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647041457; cv=none; d=google.com; s=arc-20160816; b=aXyyifvkcPWZ9KDWQUmNB70Q99VHaPPma4uRk8w/8VyqFO+2TJxFaj8qJPeDSn538L W66bb3xTco66fm5r+8c2eJFRitAdWSbcbXAPIvFcxTWbornbnvDsg9iMDkWD6O2J5mD1 CXTj1AMCRSW1UjwPErFkr+VwadcNqX9rFlWEhq84dwh8avEkQZIUOjgFOky4scdHGb5p 2aCnZw0tJYZ1P+wbSuBRRqW3Xp24hjUG84tt95B8U3PuYuAjt2P2UPgfct4fg4rVWxs3 rRpgFM28ywhdpzgf7vgQYLxqLcHJ7FZJZsoUhCxuqKsekvXk6hNZk0d+Ma5UvVOd/Rnb 34Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=3jBYaBb9V/3rmN78VTy1IJ5NcbMPJj+Y3MyfZhiIcDA=; b=z2pDjaWqxW5OPggXI5AGi64bi7mG2SI3UVnacS7CcWiXXmh2/1p2DDTZR0DcPXoz4+ 7xvfWLJGtuA7m0ezUqI9if6AcD6M8ShY02W9if45FDcezYdRkyW5AjVUVNfFdgMu93Nj 3csTLaNrfXnj0MXwUIHWqMzNfdrzV5CpVBlIAfBhJbVDosyrd/PJrI8pe87TxCX0Q7En yrzcjEy/OfJtUx9kpAnxBcbF6seNrbSCyU76ukG2IVr++j3EMCx9l8BOu9ZvH2C2S1Ly 5ow3E3wVE7SYk/X4cmFkE98wS60UeZR+SmozleA9g/nN8U0q4Na7yknhKYdIINoaEevA mMTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZIBNW1cI; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id x21-20020a633115000000b00380ccca93c0si8308378pgx.135.2022.03.11.15.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 15:30:57 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZIBNW1cI; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D08CE2CD62C; Fri, 11 Mar 2022 14:17:05 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344728AbiCJXbZ (ORCPT + 99 others); Thu, 10 Mar 2022 18:31:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344715AbiCJXbP (ORCPT ); Thu, 10 Mar 2022 18:31:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CB416BF8C; Thu, 10 Mar 2022 15:30:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C4605B82977; Thu, 10 Mar 2022 23:30:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 80C7EC340F9; Thu, 10 Mar 2022 23:30:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646955010; bh=OmiH1rkkwDE4MvdTK+ueV6th3KQ1rH29do+nnexNmeM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ZIBNW1cIk0srYcw20shDMZxPiSx7n2DNC1oZF9TPp/bjBXUN+4aEHZn8G6UlZBxxe 1OPIXaekuHJhkz4i2fbg2ebFIvkK/MmCp0GkBwvD5cZgDptuFLrBN93cuA9m9uW783 khSYVo8WULzi40Apccxg663pOgfbs5opKnyeTa+z4EDGPahLn3xX8PypOW7ZkMhJfC LYJvjpoKuvoSYJ0tj+Dc4e7eTDDDmyYkaYmUphCEw19vE/NSSOF/x7jf8gireqIfLf hyye3h1IvPlRbnQmlQKl/lIbqU+/oYd7MXyBkYTvKy7QsogvSqxyxxLGKDcgvLoLAT tg5c3o4YAe+Mg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 6D119EAC095; Thu, 10 Mar 2022 23:30:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] ice: Fix race condition during interface enslave From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164695501044.21304.15926630200023275833.git-patchwork-notify@kernel.org> Date: Thu, 10 Mar 2022 23:30:10 +0000 References: <20220310171641.3863659-1-ivecera@redhat.com> In-Reply-To: <20220310171641.3863659-1-ivecera@redhat.com> To: Ivan Vecera Cc: netdev@vger.kernel.org, poros@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 10 Mar 2022 18:16:41 +0100 you wrote: > Commit 5dbbbd01cbba83 ("ice: Avoid RTNL lock when re-creating > auxiliary device") changes a process of re-creation of aux device > so ice_plug_aux_dev() is called from ice_service_task() context. > This unfortunately opens a race window that can result in dead-lock > when interface has left LAG and immediately enters LAG again. > > Reproducer: > ``` > #!/bin/sh > > [...] Here is the summary with links: - [net] ice: Fix race condition during interface enslave https://git.kernel.org/netdev/net/c/5cb1ebdbc434 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html