Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <26549e0e-d214-ad36-a690-03ac1fbbec54@intel.com>
Date:   Fri, 11 Mar 2022 15:12:33 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH v5 2/6] selftests/resctrl: Change the default limited time
 to 120 seconds
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20220311072147.3301525-1-tan.shaopeng@jp.fujitsu.com>
 <20220311072147.3301525-3-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220311072147.3301525-3-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2JxeGVsMFdZbE1nR1lveDhpclFoMk50QzJONnQyL0c1L3B4QjlPQlVaN2dp?=
 =?utf-8?B?TkpqdW1heUR4QXJHS0dMdWZkUXhZT3FoWTdCWmUyZ3loWG85SmZIbXl5aGNE?=
 =?utf-8?B?Sk92RVhEdy9oRVlFdmtqVlRaNzVZMUpoTUpsdllTQ3lCT0l3TzBCVi96ejlw?=
 =?utf-8?B?RExSY3RjWE1Zd05UOHUwZklXa3dHdkpCRnhtWk1sSnJpQ0orRW5GcWFCZGVV?=
 =?utf-8?B?YWZEQlJuQlB4WnVGWDJiVGNhM2NkaGpvQlpLUXNmeVJ6alVpazBZbmt6K3Vl?=
 =?utf-8?B?TDFDYklFZ01wRHJTajV0K0NGNUxQUVdJWnNLQTRVazRKL2hHNmRiVWdCNmw5?=
 =?utf-8?B?Qys2VkxoZWFHS2x2bEk5NFp1YkEyNktKUXhWMEt2d05hOGpETUdTRGJqTVNC?=
 =?utf-8?B?ZWF6eUlGNnQvbXNob3NWc1NpalUyc2Zxc2VJVlFLaDdVTUxjcFFUK2tsTDhP?=
 =?utf-8?B?bWhGZHNpUWs4UjBpVGtVMUVBcXEvWExOazk4NTFzL20xaDN3NWZjQ3pqMFBh?=
 =?utf-8?B?WEc0alJ6OW1LZlo2UUx3Wk9zdEp5Z3pUOU1KaU5sZXZNU2kyTlZBWDlxZ2ww?=
 =?utf-8?B?bXI5MW5wcmR5dnNuRlBXY3AwclRJSkpoZGtpNmN4OU1sK1crTFh0dXRpMFlY?=
 =?utf-8?B?Q2tNMHhVUzZLa1JlVS85blRoRENoRUgwa3laanBuQXVYZlBudmw5dDA4c1U5?=
 =?utf-8?B?MkRPbUNGdVo1N3E3bFJqUmtLczZoRTNwdDBSeE4wcVVLN0NMVHRiY2FDS3dq?=
 =?utf-8?B?UW1FcTJrdWFEN3c3c3N1R08rN2NOcjhIOXFZNllMZ2FKaVRMOGpjazd2YnRj?=
 =?utf-8?B?VDJzaEZJV0ZXc29ScmRwS1ZwNWQrMnRTOU91WFlrM0ZIczJpYWZoSFpyZHpT?=
 =?utf-8?B?TE56UHJQejY2YzkydHVIUk5QSUZSTG5PcVN0VDAzakhCdUIyaWxQdUFnVmRo?=
 =?utf-8?B?ektXYUUyYmY5Y09jZFNyY0NPMW9sdjA2UTVXVDhWK2FDM2xTKzhUdkhLblhP?=
 =?utf-8?B?a2lRZ3RUNDIweEEwRFlpVnpnRWE5V2pHVGhUTGtTcmJiQUZTazNjazFqMG0x?=
 =?utf-8?B?a08xclljM29QL3UyRmNPMStHbVdnZ1JQZmR6QjRiRFNlWHFPTi9XRXVWVFBz?=
 =?utf-8?B?eGl3Y3RTYUdoUm9weGRwZGtoLzYwQ1VWb3Z6T0g0YW5qRVp5UlA5Vngvb0d1?=
 =?utf-8?B?UVo0YU1QM3lRSkY2OHJwNHhMb05wMm4xSDlMQVFSdXp4MWVwZHdkMysrb0d1?=
 =?utf-8?B?Y1I4aDgxalMwT2k5TUZ5Z0V0dDNGSzJReUpFNUlkNm9CSDBVbmIxWlMvVTNE?=
 =?utf-8?B?bHJDY0hHeTJJcFJzRURxVFp5SE9HbDVCbEp3WGpiczJGN2VnNmdiVHV0dDB2?=
 =?utf-8?B?K0ZCMGZqb015Sm84SElCWDVUc1NzaDZOSjQraXpqR3EzS2YxTVBxMnhESVB0?=
 =?utf-8?B?Mk85SXBVZjM2R1gwY1grNlZRbzg2SHRWVUkzTGJ4MVpOYWR3VVVXQmlBbHVO?=
 =?utf-8?B?djhEYUpYRVo2NG9wcUg0b0t2aGt5UFZZelBpeTdpLzlrVk5FWHpNZXI3SGtn?=
 =?utf-8?B?UStqemM5YnZiTHNZNHpIbnJDbDhFbk12TnFnVXI4dzhhTlpsa1ROd01rM0FM?=
 =?utf-8?B?UUF2a2xIR25KZm9NMDZRNlpQdW1LaGljTWhaWW5hT2RyeHhseTFERFp2WDJr?=
 =?utf-8?B?anZWKzR0YTROTVdtempXbHNOUGRUdUhPWklkNTlxZ1BiNXRIOVV0ZVk3Mnd5?=
 =?utf-8?B?NFlOUUNYOUdQR0lxUWozbUdBTmhFeVN3YzU3RlhBZ2VKdEVzVGphbXF0WnJt?=
 =?utf-8?B?VUgvTS9BWU9lM2hBd1A0VkhLaTZyY1BCS1dGYkNUOEhUMGhXQ1c4dFpvbXMv?=
 =?utf-8?B?cERVLzVwNXl2VURqNDB2cERvQVpzNDhvYnpJZGJKTTV1Rlg2WjdWSmpLeXRy?=
 =?utf-8?B?Y3MwNW9TVC9YWUkzZnI0Zkh5SWxERDNMK3RFQmR1VWQ4encwaGpMTGlIb043?=
 =?utf-8?B?ZzBLTVo3YmNSR1VpcFIrWjdXOTVvWjUrM2tlT2RueklFRDdOU1o4aXRVZm5h?=
 =?utf-8?B?c1FlREZFek03WC9FUTNLQnJXbkFkNkhDQTFWWTlROHh5NUlRUXFULzVtNHAx?=
 =?utf-8?B?cGUxdVBycmpRNFZtTWowTjVxZ1dRWVVqRmF1cVptbjhIZEN6TEpPMjVTY0o4?=
 =?utf-8?B?SVQyT0xGSU43SDRwa1l1V2RRVi83VnpLcWlFakZodmlhaUdUUisrRW04ZU9o?=
 =?utf-8?Q?RHdhi71BmNQ2SCZ9xflilYKxZy5XsgDTGluUCab3+o=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8060cc94-a8a0-4376-0e08-08da03b4c797
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5740.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 23:13:40.5626
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZlA4Mwb1YPhDQi9di7zM0pPZh3rsaaufVCTmaRDg11QNA2v7hWV2N3FFFYbJDxZpNSfg93h9oj+mRmvG/5y5/ypKkicvhknyAqPD2OArxmE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1512
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/10/2022 11:21 PM, Shaopeng Tan wrote:
> When testing on a Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz the resctrl
> selftests fail due to timeout after exceeding the default time limit of
> 45 seconds. On this system the test takes about 68 seconds.
> Since the failing test by default accesses a fixed size of memory, the
> execution time should not vary significantly between different environment.
> A new default of 120 seconds should be sufficient yet easy to customize
> with the introduction of the "settings" file for reference.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/settings | 3 +++
>  1 file changed, 3 insertions(+)
>  create mode 100644 tools/testing/selftests/resctrl/settings
> 
> diff --git a/tools/testing/selftests/resctrl/settings b/tools/testing/selftests/resctrl/settings
> new file mode 100644
> index 000000000000..a383f3d4565b
> --- /dev/null
> +++ b/tools/testing/selftests/resctrl/settings
> @@ -0,0 +1,3 @@
> +# If running time is longer than 120 seconds when new tests are added in
> +# the future, increase timeout here.
> +timeout=120

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette