Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Mar 2022 22:00:50 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 16/24] EDAC/amd64: Define function to make space for
 CS ID
Message-ID: <Yiu4guP6xPUuSzuz@zn.tnic>
References: <20220127204115.384161-1-yazen.ghannam@amd.com>
 <20220127204115.384161-17-yazen.ghannam@amd.com>
 <YgpQLnTd4TyiehS/@zn.tnic>
 <YikpUrojo1cMFfOp@yaz-ubuntu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YikpUrojo1cMFfOp@yaz-ubuntu>
Precedence: bulk

On Wed, Mar 09, 2022 at 10:25:22PM +0000, Yazen Ghannam wrote:
> I guess this could be "addr = func(x, y, addr)", but why not just operate on
> the value directly? There isn't an error condition here that's obvious to me.

Because when you look at the callsite:

	ctx->make_space_for_cs_id(ctx);

and compare it with the version I'm suggesting:

	ctx->ret_addr = ctx->add_coherent_slave_id_slice(ctx);

my version says exactly what it does: it adds the bit slice of CS ID to
ret_addr. You don't even have to look at the function body in order to
know what's going on.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette