Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Subject: Re: [PATCH v4 0/3] x86/mce: Support extended MCA_ADDR address on SMCA
 systems
To:     Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
        x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Tony Luck <tony.luck@intel.com>, "H . Peter Anvin" <hpa@zytor.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        James Morse <james.morse@arm.com>,
        Robert Richter <rric@kernel.org>,
        Yazen Ghannam <yazen.ghannam@amd.com>
References: <20220225193342.215780-1-Smita.KoralahalliChannabasappa@amd.com>
From:   "Koralahalli Channabasappa, Smita" <skoralah@amd.com>
Message-ID: <b6bcde0a-8232-4384-4e48-156fee7a229e@amd.com>
Date:   Fri, 11 Mar 2022 15:00:43 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.1
In-Reply-To: <20220225193342.215780-1-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3BvQ0FHaW5EN2RuTlVkOTIrdFpHeWwrS29EQWczeHlDVEhFd1o1ZDZ5NDZa?=
 =?utf-8?B?a0tvdWhFSHk3RDV5Zlp2aFJGcDlKUzgxMVZ1WTBLeWZyakR1bXFYaEIyN1NS?=
 =?utf-8?B?QW9NZWhmUktJYU1uU3RWK2NHZjA1bHg5c0JIK0Y3a3o2UTBsa1BxaDJBZGZZ?=
 =?utf-8?B?dnYzTDJFSENmYk9UdTIxWnZJSlFCTWVQVjBYcVllM0haM0hrbG9Cd2V4MlZz?=
 =?utf-8?B?SG9GYnpwSE1GUElaQU1IUGJxbDhJcmFseWhqRml4bHVidnZpNi9OQ3krd1Vq?=
 =?utf-8?B?ZjZadVFobDVjVTlkazJWOGtiNlk0SUpNbDdSTFpnRlpSUVBGY0RMUXU1Umk1?=
 =?utf-8?B?Q2FlR2NvSUQxU0FmWmlNc1JUQ3JMWERRbW9hU3RxTGhxZisrdndJQlNjRGsr?=
 =?utf-8?B?ZmF1YXp6dkxxdGhta0RLcVpiNFRlRkpyeGZmMTVHNmpnaTBjU2VaNFFkNEsx?=
 =?utf-8?B?QUllK1FTWDVTK1YvYUZaaVNUWEhNYUg5S2VVVW1mL1BKcGdSVWxKU0xzSnhB?=
 =?utf-8?B?WUFVZy9GMVFXTzgxQ0JHcWpUSWJpSkxhL2xaR2V6d2ZnajZFcFdRRmtMZEJw?=
 =?utf-8?B?aGNFcVIvMk9ISURXQTAvdTRIZ3lWMDV6VGRIM2JZRGRsRUR1RWlwZ0p2dTQy?=
 =?utf-8?B?dU9rMjgvSnRSa2tsVUhXaVlkaVhUQll3RE9Sb0lkc2wvVENHKzBmdjBBZCtN?=
 =?utf-8?B?K0Foam5rLzZrVWxTVklpRFZha0p5bE5RR2pvNjc5c3VoR05US0htaDZzaVFm?=
 =?utf-8?B?eTZ0VHlNRENkZVpjaDBKSjdseXhWNENQb0h3SFNNUkZrQjEyWkVMYyttUlZX?=
 =?utf-8?B?aHNheWZ4akhMQ0lrWWJMYzdFbTVCMWgrVjcvMlN2b3BneFNzcTI1dnVUaFpU?=
 =?utf-8?B?MkVQcE4vaG5haERxTkw5elV1OVYwVWlWWjNQdy9IQmo1bzV4RlhnUWVxYW95?=
 =?utf-8?B?YlU2ejR3SmxpQ3ErQ1ZsUjdXbUwwSGhRMHN2RVVZSFpvd21yK0tldU1ONU5x?=
 =?utf-8?B?Z2xEYTYvL1hnS3Z5S2RJNkx2akQ0TlpRV1lHNmFyYnFIZk1rVlFwNG14YlVj?=
 =?utf-8?B?eUt0VHdBWWVPWVdHbDVDYkpyNi81WTF6MUtCSlZpZER4N2V5MFE2aFhBZTdO?=
 =?utf-8?B?S1AzMTRVdnVIclVjZFluYmdGdDNSaHlOYS9KTUp4N3RaZHhTUHA2YTlSTTJw?=
 =?utf-8?B?dWtSOGFseCswaGNaak1NRk5CaU4wdXlpY0cvcWJHS2ZtYU9Eb2J2d0lVSyt3?=
 =?utf-8?B?MERjOXhXR25wWWpTcWVWallmek1XR1JSaWtwczZuclJKTkg3U1ZkaTJPUVBW?=
 =?utf-8?B?bkNEcGNtRTZnaDNMQmQ4YStvREc4ZGcwdG4wMjczK2tFSCtwbE9yOXNYcXlC?=
 =?utf-8?B?MzQwQldKRmpOSC9hc1JRcmhJVmErUEh1Tm40cmh5b2l0dGY1cEZ1SGZZVWpH?=
 =?utf-8?B?UGQ0MjYyYW0rZU4zSEg3N2UyOXY3YzNneUlxM3VWZ3J0MFY4Q3hlUDIwSFNj?=
 =?utf-8?B?R1N2YTI2Wmg4WXJ4dGRobjhSQkMvcXpQL2dWVGxzZ2NWeFlWemdLREZZU2RM?=
 =?utf-8?B?cmdjMzFzenN0S2Z3Q01zQmRaL0I3N0ltZW5yM2E3Vit2d1FIQkhrb2JHcGNH?=
 =?utf-8?B?TXdLdjB2TFBNZ2E5OWlBZjBJblJPOGsvbXhPcFdxUUJFdDl6b3VqMjF2MXF2?=
 =?utf-8?B?VDNIdmRSbmpFMmxBZmhCVTNZNUJJTXd0MVhoUUtKU3d3S3VaZktDU1E5ZkJm?=
 =?utf-8?B?WUs5dkZCaU8ycU02OEdEMnZja2Z6dlR5QVNuek1Uekp5alhJZWg5TU03L3F2?=
 =?utf-8?B?bzNvbGdCU2FtSmg5ZURlbTEvanI1UlFPbnB5Y2xqWWxsT2pFR3VSeENWOEpM?=
 =?utf-8?B?YmoyOTlXd2JteFJ1bFpUaXc5dklZeWxIcE1meFlsRVY2bEpVQXlYUWpyeXE3?=
 =?utf-8?B?alpqT1VKSzVSbVZEeWhNRnN2ZDEyYWJyZjVDQk5kd1p1OWtOT2dTSWNUbGdK?=
 =?utf-8?B?YUxzL0lsVW9KQlV5SzN0LzZUZ0gxeDM5bDgzbnZyQjlVNFVRcFltaW5URE9p?=
 =?utf-8?B?YkdoajV4VzYvd01CWllYS2ZhbkNOa3dicGpUcWY3R0hoSnFtZndIeWxRSmVN?=
 =?utf-8?B?a0JsOTQ0bjJNMVhiRGtEcHRYQW9OaXJLSGdRcTUwQkJiNFg2MnpQeXNCVzE2?=
 =?utf-8?B?bkhXN0RyZVpSdlMxdXhWV3hxNGlaUW9KbEF5b01jM3JUNG5EbnMvOEFLS0Nn?=
 =?utf-8?Q?plad6Rwh2nt7Z0VDg+jdXlFQXAHVlSaITxQHPuojvE=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 448d6613-c953-4598-9071-08da03a23597
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 21:00:44.9588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rq1ZehWrJRDKbFbr7LcJM1Wq1fm40Ni1wOHla1R3Q6C26Wyx1NO3vdZQIQUTGAFGsJFnYud6k2k/qreJlrVzaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2875
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi all,

Do you have any comments that needs to be addressed on these set of patches?

Thanks,
Smita

On 2/25/22 1:33 PM, Smita Koralahalli wrote:

> This series of patches adds support for extended physical address on newer
> AMD processors such as AMD 'Milan'.
>
> The first patch provides a fix to avoid unnecessary padding in mce_bank
> struct.
>
> The second patch defines a separate helper function to extract
> MCA_ADDR[ErrorAddr].
>
> Finally, the last patch adds support for extended ErrorAddr bits in
> MCA_ADDR.
>
> Link:
> https://lkml.kernel.org/r/20220211223442.254489-1-Smita.KoralahalliChannabasappa@amd.com
>
> Smita Koralahalli (3):
>    x86/mce: Avoid unnecessary padding in struct mce_bank
>    x86/mce: Define function to extract ErrorAddr from MCA_ADDR
>    x86/mce: Add support for Extended Physical Address MCA changes
>
>   arch/x86/include/asm/mce.h         |  4 ++++
>   arch/x86/kernel/cpu/mce/amd.c      | 35 ++++++++++++++++++++++--------
>   arch/x86/kernel/cpu/mce/core.c     | 20 +++++------------
>   arch/x86/kernel/cpu/mce/internal.h | 16 ++++++++++++++
>   4 files changed, 52 insertions(+), 23 deletions(-)
>