Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <44e4d46d-c0cb-8010-4ec9-34441e1d2cb0@intel.com>
Date:   Fri, 11 Mar 2022 15:20:14 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH v5 5/6] selftests/resctrl: Update README about using
 kselftest framework to build/run resctrl_tests
Content-Language: en-US
To:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Shuah Khan <shuah@kernel.org>
CC:     <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20220311072147.3301525-1-tan.shaopeng@jp.fujitsu.com>
 <20220311072147.3301525-6-tan.shaopeng@jp.fujitsu.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220311072147.3301525-6-tan.shaopeng@jp.fujitsu.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWFWdHZMS3h6VE5pK1JleXZ3SzdtVkFxK0NaZDRheVRZY2lTZVdDbmtaSDlQ?=
 =?utf-8?B?YXVEOFNraU1yNUZPTXFTSll3SXBldjE1TWRxS2s4V3RiUGh0M2poY0M5SWVh?=
 =?utf-8?B?dnBhYzREMjF4ZzVpOVlYMjhoeHBuQVpkRHJrZDU2SVVCNXpueVgyTlNWUTM5?=
 =?utf-8?B?TzA4Q29zY0pzQWtKaDZVMEJCc2FyaWN2bkNkZzc0WU9pT3pXVjJoeWFvOE1r?=
 =?utf-8?B?YXg3dGUyUWQrYTFWdkppRHpnZW1BcHdTcWY4MklRSjZXTmUyOEVRZDZ0eXdK?=
 =?utf-8?B?Nm9DeFV0bWJta3BENTBIOTdIZTl3ckI1YXJwSENkMWpLZFBoUzVoWmhQNVZF?=
 =?utf-8?B?WkpVQkpmRG1MWWpZM09zVW52dkFZeUpwY3VIa0hHMk1qMENRMVh0OVdFT1hz?=
 =?utf-8?B?SUNLbmlIZWdEcnJRS1hud2JJK2gvZ2ZqaVljd0dkTElHYXJLclNNclhQY0tk?=
 =?utf-8?B?UStvT01EU0IrMFBDOTBIZUE0MDVjbWI5YWRtWUN3ZmJVV2x4RGtXSDVlR3NU?=
 =?utf-8?B?U2gwblV4WWtBS1pOTm9LbG1Qby9lSkdCYVpCNm5JRG1pd0VteVpHTEI4QXBh?=
 =?utf-8?B?NTlhdjVpQnNTcHZMd2VoOTdQSDJObHpRclNkNjJpOGFqQTVqa0xSOHpuQkh0?=
 =?utf-8?B?L3ZrRWNmdGJML3VWVGxLRWFwREYxQkl3TzdnZmorY0dxekZJZXVOUS9HOW5l?=
 =?utf-8?B?RmhtRjdqdjlnVkZrakdlN1g1czR5YkJUSHVONnVLTHlIaWFPWk9pR01ZblNo?=
 =?utf-8?B?SFdtemhoem1hbTBtQzFST29xYzNvZlJwSTNSQ1piQ1U0K2tuNGt1a3pUZnNl?=
 =?utf-8?B?S3lnVGIrV0RUaHYzdWE3d1h4NVdYODdIUjlvTEJtTzZ3L3N4TWpBVXhlS0w0?=
 =?utf-8?B?THlvL2o1YmhzclAwbE5OMDZPWjZOOEtQWXhVYzhyU0t5OEtrYXcwTlRBNDVv?=
 =?utf-8?B?WmJ5dVlTaXhpVzNGQUNrTExNYURBeUZaOExaT1g5dXFMemRENDFvWG9xS0JK?=
 =?utf-8?B?Mm5YNmc1VThZUVNnTmk2d05nMkE1T293RjJtV0RTTmZpZE00RS9SblhSUXo4?=
 =?utf-8?B?RjZ6WXMxcHJ5UWE2L01CaWxJUk5QeVpjQTJCZFlvNUlMVFhsSFFldVhsN2xM?=
 =?utf-8?B?M0Fkb1RyWW1ydEE4RWtzYmNuYXFMcElmNGs0NGJpeUxSK09uV0dmVEZLV3Rw?=
 =?utf-8?B?T0dxQnArcDlLSFIwakIvQWxQM21uQ2xqeW1OaWl4RjRyMmk4cVRZUVJVTnUy?=
 =?utf-8?B?QzNVSjhhMnIwNlRjaXlJWjlzdkd2MzE4Q3RXbWRYbDd2TDNKaGY3ZnFDT0ZH?=
 =?utf-8?B?NCs3N09udGRrV2c1N2F0TzZnd1RwRjl1RWtSZGVWVWNQR0w1WjhPOUdnaG5I?=
 =?utf-8?B?ZkhvWjNCd3BndC9QcmE4c2JhQmFBK3VvZkJCS04yb3M4Ullkc1RTaUNDa0Za?=
 =?utf-8?B?bk90R0kxbFQrSlRHZko4UVVMSldPZmRna0VGMm9TMEh0VHp2dHl5c1Zhclgr?=
 =?utf-8?B?QVpUK0FBTyt6bHdQSkwzZHQ1VHZocmF4MUlESDJiM2sxL2tUWk9uYjY5UmU5?=
 =?utf-8?B?QnNEc3JxcFBVc2ZrZXMvbVQ5UHNMUU56dHc3N0ZhYlAvWGEzRzdQZmEvWG1H?=
 =?utf-8?B?a2tUcDV5NzBDNmxWS2tZOHZCckY4cGVNL0Y0M0owUk5Wb25MTmpqR2JCWXJo?=
 =?utf-8?B?N3haUy83YlJrLzhYK0hJLzFOeEtUN1djcW1CUm53d09qVnpNeUZpL2E5RG9Y?=
 =?utf-8?B?TlBjdXFwYnFxVmVXMnpJQ3FRTUlvbjNHUG5mUzNnR1NlU3NwZnpia0FDQjhR?=
 =?utf-8?B?R1JJQmtxYWpmbm5wNXB3T2ZRWnZYQkI0K0FzMStnc3VQR01VVUdaR3V2Sjg4?=
 =?utf-8?B?WU5qWUk5TURoRVYyWDhKTFhSazAxc3ZJS0xHa0N3T0QwS1gzMTE3Rks4eDdS?=
 =?utf-8?B?ZGJLNmpJMFpqdHZScEprZjVGTEUxVzFJazVwaDc1MzFMUmZzR1ZRRXp1NEJW?=
 =?utf-8?B?WVpmbEY0TmZBPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8901fe80-49d1-4962-934a-08da03b5b45d
X-MS-Exchange-CrossTenant-AuthSource: CH0PR11MB5740.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2022 23:20:17.8854
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FCzPmK7Kq/y7bASxyNmeUgLvgXZNoSEgAamzmhOv7Q2YZhbbtSdnKekTMAI+Vkv2jqXyxWeqGFI6hbRvGBpZGzxatH0TCTw9IWQJntbhh8Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5180
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shaopeng Tan,

On 3/10/2022 11:21 PM, Shaopeng Tan wrote:
> resctrl_tests can be built or run using kselftests framework.
> Add description on how to do so in README.
> 
> Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/README | 43 ++++++++++++++++++++------
>  1 file changed, 34 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/README b/tools/testing/selftests/resctrl/README
> index 3d2bbd4fa3aa..c74b8246e6c9 100644
> --- a/tools/testing/selftests/resctrl/README
> +++ b/tools/testing/selftests/resctrl/README
> @@ -12,24 +12,49 @@ Allocation test on Intel RDT hardware. More tests will be added in the future.
>  And the test suit can be extended to cover AMD QoS and ARM MPAM hardware
>  as well.
>  
> +resctrl_tests can be run with or without kselftest framework.

Saying "with or without kselftest framework" sounds good. Could you please
keep using that instead of the "use" and "not use" in the new headers?

> +
> +USE KSELFTEST FRAMEWORK
> +=======================

So, here it can be "WITH KSELFTEST FRAMEWORK"

> +
> +* BUILD
> +-------

Please remove the "*" to make it consistent with the "BUILD" later in the file.

> +
> +Build executable file "resctrl_tests" at top level directory of the kernel source.
> + $ make -C tools/testing/selftests TARGETS=resctrl

Please use ":" after the sentence that describes a command that follows. For
example, above would read:

Build executable file "resctrl_tests" from top level directory of the kernel source:
 $ make -C tools/testing/selftests TARGETS=resctrl

(also note me changing "at" to "from")

> +
> +* RUN

Please remove the "*" to make it consistent with the "RUN" later in the file.

> +-----
> +
> +Run resctrl_tests as sudo or root since the test needs to mount resctrl file
> +system and change contents in the file system.
> +Using kselftest framework will run all supported tests of resctrl_tests.

"tests of resctrl_tests." -> "tests within resctrl_tests:"?

> +
> + $ sudo make -C tools/testing/selftests TARGETS=resctrl run_tests
> +
> +More details about kselftest framework as follow.
> +Documentation/dev-tools/kselftest.rst

"More details about kselftest framework can be found in Documentation/dev-tools/kselftest.rst."

> +
> +NOT USE KSELFTEST FRAMEWORK
> +===========================

("WITHOUT KSELFTEST FRAMEWORK")

> +
>  BUILD
>  -----
>  
> -Run "make" to build executable file "resctrl_tests".
> +Build executable file "resctrl_tests" at this directory(tools/testing/selftests/resctrl/).

"at this directory" -> "from this directory"

"." -> ":"

> +  $ make
>  
>  RUN
>  ---
>  
> -To use resctrl_tests, root or sudoer privileges are required. This is because
> -the test needs to mount resctrl file system and change contents in the file
> -system.
> -
> -Executing the test without any parameter will run all supported tests:
> +Run resctrl_tests as sudo or root since the test needs to mount resctrl file
> +system and change contents in the file system.
> +Executing the test without any parameter will run all supported tests.

"." -> ":"

>  
> -	sudo ./resctrl_tests
> + $ sudo ./resctrl_tests
>  
>  OVERVIEW OF EXECUTION
> ----------------------
> +=====================
>  
>  A test case has four stages:
>  
> @@ -41,7 +66,7 @@ A test case has four stages:
>    - teardown: umount resctrl and clear temporary files.
>  
>  ARGUMENTS
> ----------
> +=========
>  
>  Parameter '-h' shows usage information.
>  

Reinette