Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220311074413.14644-1-yusisamerican@gmail.com> <YisE6jjbzJyytqB8@kroah.com>
In-Reply-To: <YisE6jjbzJyytqB8@kroah.com>
From:   Yusuf Khan <yusisamerican@gmail.com>
Date:   Fri, 11 Mar 2022 21:09:45 -0800
Message-ID: <CAJoG2+9w=GP9=+d=pLuNRoR7USH1V7f=DSPURxnxotYs_CwW+w@mail.gmail.com>
Subject: Re: [PATCH v7] drivers: ddcci: upstream DDCCI driver
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jason Wang <jasowang@redhat.com>,
        Michael Kelley <mikelley@microsoft.com>,
        "Michael S. Tsirkin" <mst@redhat.com>, javier@javigon.com,
        Arnd Bergmann <arnd@arndb.de>, Will Deacon <will@kernel.org>,
        Jens Axboe <axboe@kernel.dk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

> How can this ever fail?
If ddcci_verify_device() fails
> Not needed, just do not have it.
I'm assuming you mean the locks?
> This should not be needed in sysfs.  What tool wants this?
Its for the idSerial and modalias part of the userland interface.
> Why "_void"?
suppressing "initialization of =E2=80=98void (*)(struct device *)=E2=80=99 =
from
incompatible pointer type =E2=80=98int (*)(struct device *)=E2=80=99"