Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 11 Mar 2022 18:01:11 -0800 (PST)
From:   Stefano Stabellini <sstabellini@kernel.org>
To:     Miaoqian Lin <linmq006@gmail.com>
cc:     Stefano Stabellini <sstabellini@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Shannon Zhao <shannon.zhao@linaro.org>,
        Julien Grall <julien.grall@arm.com>,
        xen-devel@lists.xenproject.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/xen: Fix refcount leak in xen_dt_guest_init
In-Reply-To: <20220309102442.14726-1-linmq006@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2203111756000.3497@ubuntu-linux-20-04-desktop>
References: <20220309102442.14726-1-linmq006@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 9 Mar 2022, Miaoqian Lin wrote:
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, We should use of_node_put() on it when done
> Add the missing of_node_put() to release the refcount.
> 
> Fixes: 9b08aaa3199a ("ARM: XEN: Move xen_early_init() before efi_init()")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Thanks for the patch!


> ---
>  arch/arm/xen/enlighten.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index ec5b082f3de6..262f45f686b6 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -424,6 +424,7 @@ static void __init xen_dt_guest_init(void)
>  
>  	if (of_address_to_resource(xen_node, GRANT_TABLE_INDEX, &res)) {
>  		pr_err("Xen grant table region is not found\n");
> +		of_node_put(xen_node);
>  		return;
>  	}

This is adding a call to of_node_put on the error path. Shouldn't it
be called also in the non-error path?

Also, there is another instance of of_address_to_resource being called
in this file (in arch_xen_unpopulated_init), does it make sense to call
of_node_put there too?