Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1246626pxp; Sat, 12 Mar 2022 05:33:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7ugV4x/35aryV+JG9lgZxDyNPmYBcjcPHFWS8f5l/OiO8MEvaS3RFHU1X6RbsDihddgad X-Received: by 2002:a05:6402:4c6:b0:406:d579:2c4 with SMTP id n6-20020a05640204c600b00406d57902c4mr12897134edw.52.1647091991604; Sat, 12 Mar 2022 05:33:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1647091991; cv=none; d=google.com; s=arc-20160816; b=ljkvGzQqle14jE8iUWwbsCItEGS/t6f5FN/WLjqTp92Yb+KengmVq1g7J2/y/fwksW ySY+kaIgBfNFAeK7ljAd88Dg+X6SkTv/ilJoRgnjUsxz/w6GC7Rv4kaeQwue1kZSiHF1 mWdDa6eURjWE24nRPByQkI0ZA52NIS3KEGbGwBIFqpRJnSysb750hx4XYMsXCNJKRBC5 pw/HMRZarjxKuXmP3BSv9znSAIwn8F52x6pxu5p+BlSGzTVyOx6l2Yj6MMim58Ov4rJY j2xfAaMc75reY2Ko5BmLNz1i/gjfobYdwsVrpA5/ewyC0Al0VMG0tCtinWngfaFpoWFd V+IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=NLGE532dnntqV6afouWfjgsShrjzn8OlCiiWXYnc8hU=; b=zfJNylJS5alld5P03uQ93PpWEnKzBtfgqw9SFOmET7l3U4VJs4NGvL4oRIiwirCfkK Kx8M8L+Ver6iB/zMHjnbyh89Pmsca/LosT9g9GqDvkd/fRLgLEnJanP15fTLOVqVdiB8 4mz6m8BjzKIwixhGeTeEY3rgWUziYL0q7vQ1XcIARAjjrc1rpBjsgtq4SNAkFlqckqY0 nIDOr8ZqyrDdTseThKe/1EeebkMlmZaxvmSBPDpUjnGqQuiTwbveGE2t4yI15msxZppu 8h2fkBSA5zZltL/NwpDDRC4rSBI5YrPwW8jxnE7nM0txlM4I5QwY5USyn73C2D4KnxTO RqKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb22-20020a170907961600b006d79dcb4628si7017224ejc.102.2022.03.12.05.32.45; Sat, 12 Mar 2022 05:33:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbiCLKcA (ORCPT + 99 others); Sat, 12 Mar 2022 05:32:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229964AbiCLKb6 (ORCPT ); Sat, 12 Mar 2022 05:31:58 -0500 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B53A823C0F4 for ; Sat, 12 Mar 2022 02:30:53 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4KFzbc2DdTz4xcq; Sat, 12 Mar 2022 21:30:52 +1100 (AEDT) From: Michael Ellerman To: mpe@ellerman.id.au, benh@kernel.crashing.org, tyreld@linux.ibm.com, Hangyu Hua , paulus@samba.org Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org In-Reply-To: <20220302021959.10959-1-hbh25y@gmail.com> References: <20220302021959.10959-1-hbh25y@gmail.com> Subject: Re: [PATCH v2] powerpc: kernel: fix refcount leak in format_show() Message-Id: <164708098533.827774.691952258403804628.b4-ty@ellerman.id.au> Date: Sat, 12 Mar 2022 21:29:45 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Mar 2022 10:19:59 +0800, Hangyu Hua wrote: > Refcount leak will happen when format_show returns failure in multiple > cases. Unified management of of_node_put can fix this problem. > > Applied to powerpc/next. [1/1] powerpc: kernel: fix refcount leak in format_show() https://git.kernel.org/powerpc/c/d601fd24e6964967f115f036a840f4f28488f63f cheers