Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8f4a088ffc0fc1d4aa14aa1d0adf575cdc94291b.camel@gmail.com>
Subject: Re: [RESEND V2] ASoC: max98390: Add reset gpio control
From:   Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To:     Steve Lee <steve.lee.analog@gmail.com>, lgirdwood@gmail.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
        ckeepax@opensource.cirrus.com, geert@linux-m68k.org,
        rf@opensource.wolfsonmicro.com, shumingf@realtek.com,
        srinivas.kandagatla@linaro.org, krzk@kernel.org,
        jack.yu@realtek.com, nuno.sa@analog.com,
        ryans.lee@maximintegrated.com, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
Date:   Sat, 12 Mar 2022 13:58:27 +0100
In-Reply-To: <20220312002429.16175-1-steve.lee.analog@gmail.com>
References: <20220312002429.16175-1-steve.lee.analog@gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sat, 2022-03-12 at 09:24 +0900, Steve Lee wrote:
>  Add reset gpio control to support RESET PIN connected to gpio.
> 
> Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> ---
>  sound/soc/codecs/max98390.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/soc/codecs/max98390.c
> b/sound/soc/codecs/max98390.c
> index 40fd6f363f35..9a9299e5cc5a 100644
> --- a/sound/soc/codecs/max98390.c
> +++ b/sound/soc/codecs/max98390.c
> @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client
> *i2c,
>  
>         struct max98390_priv *max98390 = NULL;
>         struct i2c_adapter *adapter = i2c->adapter;
> +       struct gpio_desc *reset_gpio;
>  
>         ret = i2c_check_functionality(adapter,
>                 I2C_FUNC_SMBUS_BYTE
> @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct
> i2c_client *i2c,
>                 return ret;
>         }
>  
> +       reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> +                                            "maxim,reset-gpios",
> GPIOD_OUT_LOW);

A reset GPIO is a standard property so there's no need for a vendor
prefix. This should be devm_gpiod_get_optional(&i2c->dev, "reset",
...). And, as said before, you need to add a reset-gpios property to
the bindings in a different patch.

I'm also not sure why you have this as RESEND...

- Nuno Sá
>