Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <65a1d178-8511-a023-2655-94540114086c@gmail.com>
Date:   Sat, 12 Mar 2022 22:58:18 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] media: stkwebcam: move stk_camera_read_reg() scratch
 buffer to struct stk_camera
Content-Language: en-US
To:     trix@redhat.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
        cai.huoqing@linux.dev, xose.vazquez@gmail.com
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220312173049.1410977-1-trix@redhat.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <20220312173049.1410977-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/12/22 20:30, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> In stk_camera_read_reg() a single byte buffer is alloc-ed and
> freed on every function call.  Since the size is known,
> move the buffer to the struct stk_camera where it will be alloc-ed
> and freed once.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/media/usb/stkwebcam/stk-webcam.c | 11 ++---------
>   drivers/media/usb/stkwebcam/stk-webcam.h |  2 ++
>   2 files changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/media/usb/stkwebcam/stk-webcam.c b/drivers/media/usb/stkwebcam/stk-webcam.c
> index 5b822214ccc5c..787edb3d47c23 100644
> --- a/drivers/media/usb/stkwebcam/stk-webcam.c
> +++ b/drivers/media/usb/stkwebcam/stk-webcam.c
> @@ -150,25 +150,18 @@ int stk_camera_write_reg(struct stk_camera *dev, u16 index, u8 value)
>   int stk_camera_read_reg(struct stk_camera *dev, u16 index, u8 *value)

And just random note: there are 4 possible uninit value bugs.

stk_start_stream() calls stk_camera_read_reg 4 times, but ignores return 
values.

stk_camera_read_reg() should have __must_check annotation and return 
value should be checked on each call.


If you have time you can take care of it :) Or I will fix it one day...


With regards,
Pavel Skripkin