Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220312002429.16175-1-steve.lee.analog@gmail.com> <009acb4c-d59c-c1ad-60b0-cc85fe7ad73d@kernel.org>
In-Reply-To: <009acb4c-d59c-c1ad-60b0-cc85fe7ad73d@kernel.org>
From:   Lee Steve <steve.lee.analog@gmail.com>
Date:   Sun, 13 Mar 2022 14:40:48 +0900
Message-ID: <CA+Fz0PZ0+Fn3_X8vtcL52pQFn3kQCnU1cBFNwif3XkP76HYXYA@mail.gmail.com>
Subject: Re: [RESEND V2] ASoC: max98390: Add reset gpio control
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>,
        perex@perex.cz, tiwai@suse.com, ckeepax@opensource.cirrus.com,
        geert@linux-m68k.org, rf@opensource.wolfsonmicro.com,
        shumingf@realtek.com, srinivas.kandagatla@linaro.org,
        jack.yu@realtek.com, "Sa, Nuno" <nuno.sa@analog.com>,
        ryans.lee@maximintegrated.com, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Mar 12, 2022 at 7:40 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 12/03/2022 01:24, Steve Lee wrote:
> >  Add reset gpio control to support RESET PIN connected to gpio.
> >
> > Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> > ---
> >  sound/soc/codecs/max98390.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
> > index 40fd6f363f35..9a9299e5cc5a 100644
> > --- a/sound/soc/codecs/max98390.c
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
> >
> >       struct max98390_priv *max98390 = NULL;
> >       struct i2c_adapter *adapter = i2c->adapter;
> > +     struct gpio_desc *reset_gpio;
> >
> >       ret = i2c_check_functionality(adapter,
> >               I2C_FUNC_SMBUS_BYTE
> > @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
> >               return ret;
> >       }
> >
> > +     reset_gpio = devm_gpiod_get_optional(&i2c->dev,
> > +                                          "maxim,reset-gpios", GPIOD_OUT_LOW);
> > +
>
> I don't know why did you CC me, but since I am looking at this - you
> have to update bindings.
>
> Do not add random properties to drivers without updating bindings.
>
> Best regards,
> Krzysztof

Thanks for comment. Yes, I update bingding too.