Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Mar 2022 20:41:59 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch,
        robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        maarten.lankhorst@linux.intel.com, mripard@kernel.org,
        tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, alistair@alistair23.me,
        samuel@sholland.org, josua.mayer@jm0.eu,
        letux-kernel@openphoenux.org
Subject: Re: [RFC PATCH 2/6] drm: Add skeleton for EPDC driver
Message-ID: <Yiz3h0GYcyD/hgX3@latitude>
References: <20220206080016.796556-1-andreas@kemnade.info>
 <20220206080016.796556-3-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uMoMbLT3WzEqMEI6"
Content-Disposition: inline
In-Reply-To: <20220206080016.796556-3-andreas@kemnade.info>
Precedence: bulk


--uMoMbLT3WzEqMEI6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 06, 2022 at 09:00:12AM +0100, Andreas Kemnade wrote:
> This driver is for the EPD controller in the i.MX SoCs. Add a skeleton
> and basic things for the driver
>=20
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/gpu/drm/Kconfig                 |   2 +
>  drivers/gpu/drm/Makefile                |   1 +
>  drivers/gpu/drm/mxc-epdc/Kconfig        |  15 +
>  drivers/gpu/drm/mxc-epdc/Makefile       |   5 +
>  drivers/gpu/drm/mxc-epdc/epdc_regs.h    | 442 ++++++++++++++++++++++++
>  drivers/gpu/drm/mxc-epdc/mxc_epdc.h     |  20 ++
>  drivers/gpu/drm/mxc-epdc/mxc_epdc_drv.c | 248 +++++++++++++
>  7 files changed, 733 insertions(+)
>  create mode 100644 drivers/gpu/drm/mxc-epdc/Kconfig
>  create mode 100644 drivers/gpu/drm/mxc-epdc/Makefile
>  create mode 100644 drivers/gpu/drm/mxc-epdc/epdc_regs.h
>  create mode 100644 drivers/gpu/drm/mxc-epdc/mxc_epdc.h
>  create mode 100644 drivers/gpu/drm/mxc-epdc/mxc_epdc_drv.c
>=20
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index b1f22e457fd0..6b6b44ff7556 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -390,6 +390,8 @@ source "drivers/gpu/drm/gud/Kconfig"
> =20
>  source "drivers/gpu/drm/sprd/Kconfig"
> =20
> +source "drivers/gpu/drm/mxc-epdc/Kconfig"

I'd put it under gpu/drm/imx/epdc, perhaps.

> +int mxc_epdc_output(struct drm_device *drm)
> +{
> +	struct mxc_epdc *priv =3D to_mxc_epdc(drm);
> +	int ret;
> +
> +	priv->connector.dpms =3D DRM_MODE_DPMS_OFF;
> +	priv->connector.polled =3D 0;
> +	drm_connector_helper_add(&priv->connector,
> +				 &mxc_epdc_connector_helper_funcs);
> +	ret =3D drm_connector_init(drm, &priv->connector,
> +				 &mxc_epdc_connector_funcs,
> +				 DRM_MODE_CONNECTOR_Unknown);
> +	if (ret)
> +		return ret;
> +	ret =3D of_get_display_timing(drm->dev->of_node, "timing", &priv->timin=
g);
> +	if (ret)
> +		return ret;
> +
> +	return 0;

Possible to simplify to:

	return of_get_display_timing(drm->dev->of_node, "timing", &priv->timing);


Jonathan

--uMoMbLT3WzEqMEI6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmIs91QACgkQCDBEmo7z
X9su8hAApRBwjE74IrtIOWKR416R4XLl1lYHwoeDX5IkWqkKKXQF8nCYB64nSxMf
WVEwd9tp38bm+xZ5Yex8OMlTFtwNzcMcnYAWv8gHSN2dQGOEnGXQfxIOsmoiEaS2
1Oiz8c3rxkw5JUlGXANOeDVgvkiTGaSiXvBze4bAKYU5kpeovfGH8Vd7NlsW+6B4
oudpLG4Cc9VaO8wrN0ch85njP32ctCCphWwR8gfZW76y/1a7lIlZevb+2aIaotPt
BGwk6qOUzArVroHvkdKXmCJg3K1luPA0q3c68GVydewfAR5TBENsLBWjIaQUcTSi
y4Run6OpF7AKOBi8JxpRjSoPDe3MitKMtA9vlL9nlo2CW7DE4ScYb7yxgzLwcOAx
Oz8Ul0qI4e60AKhfEDs1Ugf0FCVF7SK1Kna5sjxOTqL9aeau96H9E44xaKbY+X5a
azx54txrPBQHQxY4h8OS8EOrUNhq/JQzJCMbHZxPSVqcHYruKjQ4poYuRiWlrhaB
RBrkwpfnA77IjjRSjKXEgChVxopS6vYHA+YvFX8QS1u3z7jYvdPx+hIK2WgWGQ9A
D/wsjEjtvBHezCgABsas7pDJJULig5pp89CF9tjIIJWMOHP1bZckzvY+WB7p1gCs
XWfS+v4ZrV/lwVYoKTE160ztJTqyuRLxDvGUfsX5lGS/Pig092s=
=dV4g
-----END PGP SIGNATURE-----

--uMoMbLT3WzEqMEI6--