Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220312002429.16175-1-steve.lee.analog@gmail.com> <8f4a088ffc0fc1d4aa14aa1d0adf575cdc94291b.camel@gmail.com>
In-Reply-To: <8f4a088ffc0fc1d4aa14aa1d0adf575cdc94291b.camel@gmail.com>
From:   Lee Steve <steve.lee.analog@gmail.com>
Date:   Sun, 13 Mar 2022 14:42:50 +0900
Message-ID: <CA+Fz0PaRM7zCShHsK1WDAaFGwz1D2dV5LrvRqnYXkiB5i=rFPQ@mail.gmail.com>
Subject: Re: [RESEND V2] ASoC: max98390: Add reset gpio control
To:     =?UTF-8?B?TnVubyBTw6E=?= <noname.nuno@gmail.com>
Cc:     lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>,
        perex@perex.cz, tiwai@suse.com, ckeepax@opensource.cirrus.com,
        geert@linux-m68k.org, rf@opensource.wolfsonmicro.com,
        shumingf@realtek.com, srinivas.kandagatla@linaro.org,
        krzk@kernel.org, jack.yu@realtek.com,
        "Sa, Nuno" <nuno.sa@analog.com>, ryans.lee@maximintegrated.com,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Mar 12, 2022 at 9:58 PM Nuno S=C3=A1 <noname.nuno@gmail.com> wrote:
>
> On Sat, 2022-03-12 at 09:24 +0900, Steve Lee wrote:
> >  Add reset gpio control to support RESET PIN connected to gpio.
> >
> > Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> > ---
> >  sound/soc/codecs/max98390.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/sound/soc/codecs/max98390.c
> > b/sound/soc/codecs/max98390.c
> > index 40fd6f363f35..9a9299e5cc5a 100644
> > --- a/sound/soc/codecs/max98390.c
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client
> > *i2c,
> >
> >         struct max98390_priv *max98390 =3D NULL;
> >         struct i2c_adapter *adapter =3D i2c->adapter;
> > +       struct gpio_desc *reset_gpio;
> >
> >         ret =3D i2c_check_functionality(adapter,
> >                 I2C_FUNC_SMBUS_BYTE
> > @@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct
> > i2c_client *i2c,
> >                 return ret;
> >         }
> >
> > +       reset_gpio =3D devm_gpiod_get_optional(&i2c->dev,
> > +                                            "maxim,reset-gpios",
> > GPIOD_OUT_LOW);
>
> A reset GPIO is a standard property so there's no need for a vendor
> prefix. This should be devm_gpiod_get_optional(&i2c->dev, "reset",
> ...). And, as said before, you need to add a reset-gpios property to
> the bindings in a different patch.
>
> I'm also not sure why you have this as RESEND...
>
> - Nuno S=C3=A1
> >
>

I forgot to add another patch mail. I will check it before sending patch ag=
ain.