Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Mar 2022 10:48:26 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     John Garry <john.garry@huawei.com>
Cc:     Weiguo Li <liwg06@foxmail.com>, peterz@infradead.org,
        mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        namhyung@kernel.org, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf parse-events: Fix null check
Message-ID: <YiykquZ6QK/294sl@kernel.org>
References: <tencent_DF39269807EC9425E24787E6DB632441A405@qq.com>
 <a007c783-49a2-4ab3-a592-9f37ea41eaae@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a007c783-49a2-4ab3-a592-9f37ea41eaae@huawei.com>
Precedence: bulk

Em Fri, Mar 11, 2022 at 02:00:13PM +0000, John Garry escreveu:
> On 11/03/2022 13:06, Weiguo Li wrote:
> > We did a null check after "tmp->symbol = strdup(...)", but we checked
> > "list->symbol" other than "tmp->symbol".
> > 
> > Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> 
> Reviewed-by: John Garry <john.garry@huawei.com>

Thanks, applied.

- Arnaldo

 
> > ---
> >   tools/perf/util/parse-events.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> > index 9739b05b999e..dfb50a5f83d0 100644
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -2193,7 +2193,7 @@ int perf_pmu__test_parse_init(void)
> >   	for (i = 0; i < ARRAY_SIZE(symbols); i++, tmp++) {
> >   		tmp->type = symbols[i].type;
> >   		tmp->symbol = strdup(symbols[i].symbol);
> > -		if (!list->symbol)
> > +		if (!tmp->symbol)
> >   			goto err_free;
> >   	}

-- 

- Arnaldo