Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62178934-9b16-c79c-387d-91526f7fe732@kernel.org>
Date:   Sun, 13 Mar 2022 18:54:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
From:   Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v1 8/8] dt-bindings: pinctrl: convert ocelot-pinctrl to
 YAML format
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        Paul Burton <paulburton@kernel.org>,
        Quentin Schulz <quentin.schulz@bootlin.com>,
        Antoine Tenart <atenart@kernel.org>,
        Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        "David S . Miller" <davem@davemloft.net>,
        UNGLinuxDriver@microchip.com, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
References: <20220313152924.61931-1-michael@walle.cc>
 <20220313152924.61931-9-michael@walle.cc>
 <869d4fda-e943-1817-17cd-df7b323a1fef@kernel.org>
 <b5a33a3441f829638740204e0c4dc938@walle.cc>
In-Reply-To: <b5a33a3441f829638740204e0c4dc938@walle.cc>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/03/2022 17:36, Michael Walle wrote:
> Hi,
> 
> wow, you're fast!
> 
> Am 2022-03-13 16:55, schrieb Krzysztof Kozlowski:
> 
>>> +  reg: true
>>
>> maxItems
> 
> There are up to two address ranges. The second one is only needed for
> particular controllers (the sparx5 and the lan966x).
> 
> Is the following snippet the correct form?
> 
>    reg:
>      items:
>        - description: Base address
>        - description: Extended pin configuration registers
>      minItems: 1

Yes, it's correct. Please also add proper "if:then" under "allOf:" (and
move such allOf under "required:") which changes minItems to two for
such controllers, based on compatible.

Best regards,
Krzysztof